From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE7FEC282DE for ; Thu, 6 Mar 2025 21:25:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9H78NGtDgrJN8almAooGMPfIHicQD7QyEml+BfISIgg=; b=KWrpVG1HvDPS5xa+8DFq2YRfsZ eZfUYDWbaVJMCq3CUWs3lhq54AZg0s1pxi5d543FjDVlMJwwgj9HqoU1TegzMz5LCS+iO3q2wePRi kX7BUImAlAX9vLV0dzskzTJNcvqZvwr1j0ewH/fpVtt+kMfbfB0ksx17IthtEOG3WBB7oCKpqf00T Q03/aY/r9sOsvrk8v/xLyYOGzQ5tjtkxHOH89ro3jIeRFcnxPtWPhEUWnIXAbMseVJUNiSLnARQ0L nisaUT8yM1rKef7UFx1NtyowUT/pBdCfq9L4abtErena7xK0A7Q5nZrDypSeapJNHu12HKS30NKj5 JXSmBsfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tqIic-0000000CGNQ-0ZVQ; Thu, 06 Mar 2025 21:25:26 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tqIgz-0000000CG4v-0KM7; Thu, 06 Mar 2025 21:23:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9H78NGtDgrJN8almAooGMPfIHicQD7QyEml+BfISIgg=; b=guMhklL/+BIxtizh+xS6aUCkcs xiqV6+jRMkvDCFI1Sdi2vxBbaC8HFPmkFSPNomuM1DaFuR9gXBO5W5pyVze8dw4T1rail/m4jEtUx Sl+bfrPyvulBDrN60FqU93ZP8sEOV2aYu0DUfALLj08VQcaukP31Ov9Z/eDXCzgNeMYfJ7JgOoYxm LPp2dr+vWeNh/k4dbT3BM/AH62dODYTy86qE4hCFZTafmDcEGEjAArTWjqtWhJCGRgRQU2TGorsuO lhbZjQJ6ndCqIFdVoMdRuVoKtIzDJrHoh05ZDgdAg/TKTa1NWtUgxeKTc/aq5QAwqsoVm3sVyDVdT vzH1AxrA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44602) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tqIeb-0006Vr-05; Thu, 06 Mar 2025 21:21:17 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.96) (envelope-from ) id 1tqIeW-00078z-38; Thu, 06 Mar 2025 21:21:12 +0000 Date: Thu, 6 Mar 2025 21:21:12 +0000 From: "Russell King (Oracle)" To: Jonas Karlman Cc: Heiko Stuebner , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH 2/2] net: stmmac: dwmac-rk: Validate rockchip,grf and php-grf during probe Message-ID: References: <20250306210950.1686713-1-jonas@kwiboo.se> <20250306210950.1686713-3-jonas@kwiboo.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250306210950.1686713-3-jonas@kwiboo.se> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250306_132345_115883_057AD39E X-CRM114-Status: UNSURE ( 9.10 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 06, 2025 at 09:09:46PM +0000, Jonas Karlman wrote: > @@ -1813,8 +1564,24 @@ static struct rk_priv_data *rk_gmac_setup(struct platform_device *pdev, > > bsp_priv->grf = syscon_regmap_lookup_by_phandle(dev->of_node, > "rockchip,grf"); > - bsp_priv->php_grf = syscon_regmap_lookup_by_phandle(dev->of_node, > - "rockchip,php-grf"); > + if (IS_ERR(bsp_priv->grf)) { > + ret = PTR_ERR(bsp_priv->grf); > + dev_err_probe(dev, ret, "failed to lookup rockchip,grf\n"); > + return ERR_PTR(ret); Did you consider using ERR_CAST() for these, which would look like this: dev_err_probe(dev, PTR_ERR(bsp_priv->grf), "failed to lookup rockchip,grf\n"); return ERR_CAST(bsp_priv->grf); ? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0026C282D1 for ; Thu, 6 Mar 2025 21:23:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nv/c6VNkzI9EgURw5VJrrPAss3gDwM+gotdfsmLv2A4=; b=jU9DGQ+sx+XEnb FtHP9mov2fZ7zT1nELsbwf9urUciVlojUdYOYaUDTSeoYCTgSfSQNAcQucF0nA7rZxj1sEl0SnoGq 2LiVh2WvjXhfWpBWDLOXcGXT6T1aAeAqkOT1GYvgCslWCmiIyGKDDj91iV2kiD4DX8GZHsmTwob6h TzfkgHx3cX2wwEffr4eZkTmNqevq90OSldKjfOjuP+PMYLSj3hmajqkT2mLSVW/7PkXHNn20F6rXB 3o3n5ZNXJgmcf2XF1cmo2yVuzWGOrNk7Ee+mC/AAL7dmm8s569IyGQjn5WzE/mzHyRn3yli4fnJoH 2bLJbkZYoN43M3oNtJjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tqIh1-0000000CGEH-2XVu; Thu, 06 Mar 2025 21:23:47 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tqIgz-0000000CG4v-0KM7; Thu, 06 Mar 2025 21:23:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9H78NGtDgrJN8almAooGMPfIHicQD7QyEml+BfISIgg=; b=guMhklL/+BIxtizh+xS6aUCkcs xiqV6+jRMkvDCFI1Sdi2vxBbaC8HFPmkFSPNomuM1DaFuR9gXBO5W5pyVze8dw4T1rail/m4jEtUx Sl+bfrPyvulBDrN60FqU93ZP8sEOV2aYu0DUfALLj08VQcaukP31Ov9Z/eDXCzgNeMYfJ7JgOoYxm LPp2dr+vWeNh/k4dbT3BM/AH62dODYTy86qE4hCFZTafmDcEGEjAArTWjqtWhJCGRgRQU2TGorsuO lhbZjQJ6ndCqIFdVoMdRuVoKtIzDJrHoh05ZDgdAg/TKTa1NWtUgxeKTc/aq5QAwqsoVm3sVyDVdT vzH1AxrA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44602) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tqIeb-0006Vr-05; Thu, 06 Mar 2025 21:21:17 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.96) (envelope-from ) id 1tqIeW-00078z-38; Thu, 06 Mar 2025 21:21:12 +0000 Date: Thu, 6 Mar 2025 21:21:12 +0000 From: "Russell King (Oracle)" To: Jonas Karlman Cc: Heiko Stuebner , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH 2/2] net: stmmac: dwmac-rk: Validate rockchip,grf and php-grf during probe Message-ID: References: <20250306210950.1686713-1-jonas@kwiboo.se> <20250306210950.1686713-3-jonas@kwiboo.se> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250306210950.1686713-3-jonas@kwiboo.se> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250306_132345_115883_057AD39E X-CRM114-Status: UNSURE ( 9.10 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Thu, Mar 06, 2025 at 09:09:46PM +0000, Jonas Karlman wrote: > @@ -1813,8 +1564,24 @@ static struct rk_priv_data *rk_gmac_setup(struct platform_device *pdev, > > bsp_priv->grf = syscon_regmap_lookup_by_phandle(dev->of_node, > "rockchip,grf"); > - bsp_priv->php_grf = syscon_regmap_lookup_by_phandle(dev->of_node, > - "rockchip,php-grf"); > + if (IS_ERR(bsp_priv->grf)) { > + ret = PTR_ERR(bsp_priv->grf); > + dev_err_probe(dev, ret, "failed to lookup rockchip,grf\n"); > + return ERR_PTR(ret); Did you consider using ERR_CAST() for these, which would look like this: dev_err_probe(dev, PTR_ERR(bsp_priv->grf), "failed to lookup rockchip,grf\n"); return ERR_CAST(bsp_priv->grf); ? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip