From: Sumit Garg <sumit.garg@kernel.org>
To: Manikandan.M@microchip.com
Cc: eugen.hristev@linaro.org, lukma@denx.de, seanga2@gmail.com,
sumit.garg@linaro.org, kever.yang@rock-chips.com,
marek.vasut+renesas@mailbox.org, jonas@kwiboo.se,
festevam@denx.de, Oliver.Gaskell@analog.com, aford173@gmail.com,
prasad.kummari@amd.com, caleb.connolly@linaro.org,
andre.przywara@arm.com, neil.armstrong@linaro.org,
mibodhi@gmail.com, Nicolas.Ferre@microchip.com,
Mihai.Sain@microchip.com, sjg@chromium.org, u-boot@lists.denx.de
Subject: Re: [PATCH v3 1/8] dt-bindings: clock: rename at91.h to at91-pmc-status.h
Date: Fri, 7 Mar 2025 11:46:31 +0530 [thread overview]
Message-ID: <Z8qPP6Z-DpMFdiKX@sumit-X1> (raw)
In-Reply-To: <02132f8e-79b2-4b47-b4d4-60bb9c9a793f@microchip.com>
On Thu, Mar 06, 2025 at 10:39:28AM +0000, Manikandan.M@microchip.com wrote:
> Hi Sumit,
>
> On 06/03/25 12:30 pm, Sumit Garg wrote:
> > [Some people who received this message don't often get email from sumit.garg@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> >
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > Hi Manikandan,
> >
> > On Wed, Mar 05, 2025 at 11:37:04AM +0530, Manikandan Muralidharan wrote:
> >> Rename the include at91.h to at91-pmc-status.h to avoid conflicts with
> >> the upstream bindings that has the same file and update the
> >> relevant legacy SoC Device Trees to reflect this change.
> >> This is useful while compiling the DT and driver of the new SoC files with
> >> OF_UPSTREAM enabled.
> >>
> >> Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com>
> >> ---
> >> MAINTAINERS | 2 +-
> >> arch/arm/dts/at91-sama7g5ek-u-boot.dtsi | 2 +-
> >> arch/arm/dts/at91sam9260.dtsi | 2 +-
> >> arch/arm/dts/at91sam9261.dtsi | 2 +-
> >> arch/arm/dts/at91sam9263.dtsi | 2 +-
> >> arch/arm/dts/at91sam9g45.dtsi | 2 +-
> >> arch/arm/dts/at91sam9n12.dtsi | 2 +-
> >> arch/arm/dts/at91sam9rl.dtsi | 2 +-
> >> arch/arm/dts/at91sam9x5.dtsi | 2 +-
> >> arch/arm/dts/sama5d3.dtsi | 2 +-
> >> arch/arm/dts/sama5d3_mci2.dtsi | 2 +-
> >> arch/arm/dts/sama5d3_tcb1.dtsi | 2 +-
> >> arch/arm/dts/sama5d3_uart.dtsi | 2 +-
> >> arch/arm/dts/sama5d4.dtsi | 2 +-
> >> include/dt-bindings/clock/{at91.h => at91-pmc-status.h} | 0
> >> 15 files changed, 14 insertions(+), 14 deletions(-)
> >> rename include/dt-bindings/clock/{at91.h => at91-pmc-status.h} (100%)
> >>
> >
> > AFAICS, include/dt-bindings/clock/at91.h is just a subset of
> > dts/upstream/include/dt-bindings/clock/at91.h. If that's true then we
> > should just be able to drop local include/dt-bindings/clock/at91.h from
> > U-Boot tree. Won't that just work fine?
>
>
> Yes, you're right. It's a subset of the upstream at91.h. However, we
> must retain it due to dependencies with legacy SoC files that haven't
> yet been migrated to OF_UPSTREAM. I believe migrating those files now
> would introduce a significant number of changes w.r.t Device Tree files."
>
It's not required for SoCs to be migrated to OF_UPSTREAM to start using
upstream bindings. The DT bindings headers are meant to be stable and
reusable such that we don't have to maintain duplicated headers.
-Sumit
next prev parent reply other threads:[~2025-03-07 6:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 6:07 [PATCH v3 0/8] Add support for sam9x7 SoC and SAM9X75 Curiosity board Manikandan Muralidharan
2025-03-05 6:07 ` [PATCH v3 1/8] dt-bindings: clock: rename at91.h to at91-pmc-status.h Manikandan Muralidharan
2025-03-06 7:00 ` Sumit Garg
2025-03-06 10:39 ` Manikandan.M
2025-03-07 6:16 ` Sumit Garg [this message]
2025-03-17 5:40 ` Manikandan.M
2025-03-07 13:19 ` Eugen Hristev
2025-03-05 6:07 ` [PATCH v3 2/8] clk: at91: sam9x60-pll: add support for core clock frequency inputs Manikandan Muralidharan
2025-03-05 6:07 ` [PATCH v3 3/8] clk: at91: sam9x60-pll: add support for HW PLL freq dividers Manikandan Muralidharan
2025-03-05 6:07 ` [PATCH v3 4/8] clk: at91: sam9x7: add pmc driver for sam9x7 SoC family Manikandan Muralidharan
2025-03-05 6:07 ` [PATCH v3 5/8] ARM: at91: Add sam9x7 soc Manikandan Muralidharan
2025-03-05 6:07 ` [PATCH v3 6/8] ARM: dts: at91: sam9x75_curiosity: add tweaks for sam9x75 curiosity board Manikandan Muralidharan
2025-03-05 6:07 ` [PATCH v3 7/8] board: sam9x75_curiosity: Add support for sam9x75 curiosity Manikandan Muralidharan
2025-03-05 6:07 ` [PATCH v3 8/8] configs: sam9x75_curiosity: Add initial mmc default config Manikandan Muralidharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8qPP6Z-DpMFdiKX@sumit-X1 \
--to=sumit.garg@kernel.org \
--cc=Manikandan.M@microchip.com \
--cc=Mihai.Sain@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=Oliver.Gaskell@analog.com \
--cc=aford173@gmail.com \
--cc=andre.przywara@arm.com \
--cc=caleb.connolly@linaro.org \
--cc=eugen.hristev@linaro.org \
--cc=festevam@denx.de \
--cc=jonas@kwiboo.se \
--cc=kever.yang@rock-chips.com \
--cc=lukma@denx.de \
--cc=marek.vasut+renesas@mailbox.org \
--cc=mibodhi@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=prasad.kummari@amd.com \
--cc=seanga2@gmail.com \
--cc=sjg@chromium.org \
--cc=sumit.garg@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.