From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D5D6C19F32 for ; Fri, 7 Mar 2025 18:11:20 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tqcAK-0000FW-2d; Fri, 07 Mar 2025 18:11:19 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tqcAI-0000FQ-MT for linux-f2fs-devel@lists.sourceforge.net; Fri, 07 Mar 2025 18:11:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8r8Blkk7pG4sIZHgV/OCmTZC+u9Yu+ENFeahze9iWlY=; b=KXj0sEURDyvteLKKxnxxxDKpKe jt82zYxqIUCy2CgdwN3c4aytiw9W/vKEU9v7LZPigzVTBw1/VJGqjntMlaiYOF2BsTeMCQhQ7kliQ OINcp5IqfVRGOFFa+Z6+gTvzSGHZpi3t1xohVfsZdFoOQDkao5c5piRpSJQLoCi9PV6c=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8r8Blkk7pG4sIZHgV/OCmTZC+u9Yu+ENFeahze9iWlY=; b=aHFzR0bBFiUTbrVbiT+OZNP3gd E04/3ggelnEByqJh/i4HZsyr2hcHgXfrosimmYLskGmEAjhcKp2mMPDQZpk8/MCvWoTNGKqd5rPsK VYXvaCf4h4xaSV2natNQ24hXJPD5ftL+h6a4FDWviNe1+fEsI5VQh/Pmi1nVxGZNwYEo=; Received: from nyc.source.kernel.org ([147.75.193.91]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1tqcA7-0002wX-G0 for linux-f2fs-devel@lists.sourceforge.net; Fri, 07 Mar 2025 18:11:18 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 4CAE5A45016 for ; Fri, 7 Mar 2025 18:05:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 050F0C4CED1; Fri, 7 Mar 2025 18:10:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741371056; bh=rsgVaSryA23Jr0XcgqAG14znT/gNWQguaNRK/HSoM2s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T9gXcsQOqAUv0v+GnpZPswM8n+wx71RcC1ayl5S0P9swqsa2dmugS1PmbYweL+ENF IqyaWbyaJgYODB/e036Uip4rIRqumTBAkRE0MZ/tdxv0xlNWQ6UWsoHblmhtkXwaVc 0arlCZ4U0YhCWf1Rmi+/sPjkhx8jWvR+oLdiTkVSwbMYY4Uj1BJD1CEQE9E11CmHUO stOOJTgaZy7XgxYN3AsacueoPilGGS+iOG1VGgg1twImsU97d2CGJgcGifGaXZdXR7 bMzcDGyF7lfm8IaXiWADKcaOPP/SAbLUc3GJquree7eOCSBhPuhwgl4m7/noYlAM9E Ru2G/bTkmU/pQ== Date: Fri, 7 Mar 2025 18:10:54 +0000 To: Chao Yu Message-ID: References: <20250307031838.19164-1-chao@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250307031838.19164-1-chao@kernel.org> X-Headers-End: 1tqcA7-0002wX-G0 Subject: Re: [f2fs-dev] [PATCH] f2fs: disalbe nat_bits by default X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jaegeuk Kim via Linux-f2fs-devel Reply-To: Jaegeuk Kim Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net I meant let's support it conservatively if someone needs to enable in other platform. On 03/07, Chao Yu wrote: > Let's disable nat_bits by default. > > Signed-off-by: Chao Yu > --- > fs/f2fs/node.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index 56873c41436e..3148d9e44e7f 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -3286,6 +3286,9 @@ static int init_node_manager(struct f2fs_sb_info *sbi) > if (!nm_i->nat_bitmap) > return -ENOMEM; > > + /* disable nat_bits feature by default */ > + disable_nat_bits(sbi, true); > + > err = __get_nat_bitmaps(sbi); > if (err) > return err; > -- > 2.40.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B421F23E229 for ; Fri, 7 Mar 2025 18:10:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741371057; cv=none; b=qEo74080Okq467YajgSA8LBE5gjvTaxnV7XrI/46jvpSgECa0hBi3XlWnqdeG5PG8c3qNVGT9tOL/eUj37ToTg0nWTERMTkgKRIdXF+Ucu+QVddHMbqOMGuoeDhClomXRtP1hFjzkWPtl09dPkTyVf9kCfSMR+ut3INdZNZKnNA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741371057; c=relaxed/simple; bh=rsgVaSryA23Jr0XcgqAG14znT/gNWQguaNRK/HSoM2s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QkNgYEM+bGpOWXC3zOP4QR1oWAbppAlfgB8cUdY5ZCdhsqDrQrJJr7uw8HjTCfVFCbNl43T3z7LWuonjGLdGCSKvoyHoYRKyYqFH6cY2i0Q/O484ONWAgaq4TV93NWLmtKZcN2Ohf3JL+SPQWBo8Te0RFcnidV8cg/Zz6ZDrgAE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T9gXcsQO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T9gXcsQO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 050F0C4CED1; Fri, 7 Mar 2025 18:10:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741371056; bh=rsgVaSryA23Jr0XcgqAG14znT/gNWQguaNRK/HSoM2s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T9gXcsQOqAUv0v+GnpZPswM8n+wx71RcC1ayl5S0P9swqsa2dmugS1PmbYweL+ENF IqyaWbyaJgYODB/e036Uip4rIRqumTBAkRE0MZ/tdxv0xlNWQ6UWsoHblmhtkXwaVc 0arlCZ4U0YhCWf1Rmi+/sPjkhx8jWvR+oLdiTkVSwbMYY4Uj1BJD1CEQE9E11CmHUO stOOJTgaZy7XgxYN3AsacueoPilGGS+iOG1VGgg1twImsU97d2CGJgcGifGaXZdXR7 bMzcDGyF7lfm8IaXiWADKcaOPP/SAbLUc3GJquree7eOCSBhPuhwgl4m7/noYlAM9E Ru2G/bTkmU/pQ== Date: Fri, 7 Mar 2025 18:10:54 +0000 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] f2fs: disalbe nat_bits by default Message-ID: References: <20250307031838.19164-1-chao@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250307031838.19164-1-chao@kernel.org> I meant let's support it conservatively if someone needs to enable in other platform. On 03/07, Chao Yu wrote: > Let's disable nat_bits by default. > > Signed-off-by: Chao Yu > --- > fs/f2fs/node.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index 56873c41436e..3148d9e44e7f 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -3286,6 +3286,9 @@ static int init_node_manager(struct f2fs_sb_info *sbi) > if (!nm_i->nat_bitmap) > return -ENOMEM; > > + /* disable nat_bits feature by default */ > + disable_nat_bits(sbi, true); > + > err = __get_nat_bitmaps(sbi); > if (err) > return err; > -- > 2.40.1