From: Keith Busch <kbusch@kernel.org>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: Keith Busch <kbusch@meta.com>,
linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me
Subject: Re: [PATCH] nvme-pci: fix stuck reset on concurrent DPC and HP
Date: Fri, 7 Mar 2025 08:24:48 -0700 [thread overview]
Message-ID: <Z8sPwJw2oQH3slpT@kbusch-mbp> (raw)
In-Reply-To: <46617499-17ea-44b9-9ed0-1fb5d238f54f@linux.ibm.com>
On Fri, Mar 07, 2025 at 06:28:28PM +0530, Nilay Shroff wrote:
> Though one question: IMO, the DPC error handler shall invoke nvme_error_detected() prior
> to nvme_error_resume(). And we already disable the device (and cancel in-flight IO) in
> nvme_error_detected() and so wouldn't that help?
The sequence is error_detected, slot_reset, error_resume.
The slot_reset schedules the nvme controller reset. That work sends
amdin IO, like identify controller.
If the pciehp removal starts after reset work's controller
initialization, then nothing stops the work from sending new admin
commands, and nothing will complete them. This causes the error_resume
to wait for something that will never happen.
next prev parent reply other threads:[~2025-03-07 15:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 0:24 [PATCH] nvme-pci: fix stuck reset on concurrent DPC and HP Keith Busch
2025-03-07 12:58 ` Nilay Shroff
2025-03-07 15:24 ` Keith Busch [this message]
2025-03-08 7:27 ` Nilay Shroff
2025-03-10 14:38 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8sPwJw2oQH3slpT@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.