From: Alice Ryhl <aliceryhl@google.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: "Oliver Mangold" <oliver.mangold@pm.me>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Asahi Lina" <lina@asahilina.net>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 4/4] rust: adding OwnableRefCounted and SimpleOwnableRefCounted
Date: Fri, 7 Mar 2025 15:58:33 +0000 [thread overview]
Message-ID: <Z8sXqXgfhHbNpG6B@google.com> (raw)
In-Reply-To: <CANiq72ktwWOEBFB=y7xun-CDurwsSRe2_PE6RqGS4OhEyPGFkQ@mail.gmail.com>
On Fri, Mar 07, 2025 at 02:53:30PM +0100, Miguel Ojeda wrote:
> On Fri, Mar 7, 2025 at 2:28 PM Alice Ryhl <aliceryhl@google.com> wrote:
> >
> > It's only a warning on older compilers. We could just add this in
> > lib.rs:
> >
> > #![allow(unknown_or_malformed_diagnostic_attributes)]
>
> That is OK too, though we would lose the check for typos until we
> upgrade the minimum.
>
> Hmm... Since we have nowadays the way to create those conditions
> easily, I think it is fine to do it conditionally.
Another possibility is to make the allow conditional.
Alice
next prev parent reply other threads:[~2025-03-07 15:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 10:04 [PATCH v5 0/4] New trait OwnableRefCounted for ARef<->Owned conversion Oliver Mangold
2025-03-07 10:04 ` [PATCH v5 1/4] rust: types: Add Ownable/Owned types Oliver Mangold
2025-03-07 10:04 ` [PATCH v5 2/4] rust: make Owned::into_raw() and Owned::from_raw() public Oliver Mangold
2025-03-07 13:17 ` Miguel Ojeda
2025-03-07 10:04 ` [PATCH v5 3/4] rust: rename AlwaysRefCounted to RefCounted Oliver Mangold
2025-03-07 10:04 ` [PATCH v5 4/4] rust: adding OwnableRefCounted and SimpleOwnableRefCounted Oliver Mangold
2025-03-07 13:16 ` Miguel Ojeda
2025-03-07 13:28 ` Alice Ryhl
2025-03-07 13:53 ` Miguel Ojeda
2025-03-07 15:58 ` Alice Ryhl [this message]
2025-03-09 21:47 ` Miguel Ojeda
2025-03-09 21:48 ` [PATCH] rust: kbuild: provide `RUSTC_HAS_DO_NOT_RECOMMEND` symbol Miguel Ojeda
2025-03-09 21:55 ` Miguel Ojeda
2025-03-10 7:08 ` [PATCH v5 4/4] rust: adding OwnableRefCounted and SimpleOwnableRefCounted Oliver Mangold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8sXqXgfhHbNpG6B@google.com \
--to=aliceryhl@google.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=lina@asahilina.net \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=oliver.mangold@pm.me \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.