Re: [PATCH v1] rust: module: place cleanup_module() in .exit.text section

[Boqun Feng <boqun.feng@gmail.com>]

On Sat, Mar 08, 2025 at 01:45:06PM +0900, FUJITA Tomonori wrote:
> Place cleanup_module() in .exit.text section. Currently,
> cleanup_module() is likely placed in the .text section. It's

Do you mind compiling a module and using readelf or other tools to show
which section the symbol cleanup_module() is? Putting that information
in the changelog would be nice, and it also shows the actual effect of
your patch. Thanks!

Regards,
Boqun

> inconsistent with the layout of C modules, where cleanup_module() is
> placed in .exit.text.
> 
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
> ---
>  rust/macros/module.rs | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/rust/macros/module.rs b/rust/macros/module.rs
> index cdf94f4982df..36daa149a691 100644
> --- a/rust/macros/module.rs
> +++ b/rust/macros/module.rs
> @@ -275,6 +275,7 @@ mod __module_init {{
>                      #[cfg(MODULE)]
>                      #[doc(hidden)]
>                      #[no_mangle]
> +                    #[link_section = \".exit.text\"]
>                      pub extern \"C\" fn cleanup_module() {{
>                          // SAFETY:
>                          // - This function is inaccessible to the outside due to the double
> 
> base-commit: 6ad64bf91728502fe8a4d1419c0a3e4fd323f503
> -- 
> 2.43.0
>