Re: [Buildroot] [PATCH 1/9 v3] support/testing: set date in emulated machine

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Julien, All,

On 2025-03-07 19:49 +0100, Julien Olivain spake thusly:
> On 01/03/2025 16:05, Yann E. MORIN wrote:
> > When time comes to check certificates, the date and time in the emulated
> > machine should be close enough to the actual values, so that certificate
> > validity can be checked.
> > 
> > Set the date to the date of the system. This is going to be accurate to
> > the second, which is, by far, enough for our purpose.
[--SNIP--]
> > +        output, exit_code = self.run(f"date @{int(time.time())}")
> > +        if exit_code:
> > +            raise SystemError("Cannot set date in virtual machine")
> > +
> Is this really needed?

Yes: the skopeo test added in this series would otherwise fail with
(lines wrapped for readability):

    [BRTEST# skopeo --version
    skopeo version 1.18.0
    [BRTEST# echo $?
    0
    [BRTEST# skopeo inspect docker://busybox:latest
    FATA[0000] Error parsing image name "docker://busybox:latest":
        pinging container registry registry-1.docker.io:
        Get "https://registry-1.docker.io/v2/": tls: failed to verify
        certificate: x509: certificate has expired or is not yet valid:
        current time 1970-01-01T00:00:11Z is before 2025-03-05T00:00:00Z

> Arm and Aarch64 qemu machines includes a pl031 RTC.
> x86/x86_64 includes a mc146818 RTC.
> RISC-V has a Goldfish RTC.

The skopeo test uses the bundeled kernel with the "default" virtual
machine, and in that machine, the date is not set on boot: there is no
RTC regferenced in the kernel log, at least.

> If we revert this patch, the podman runtime test still succeed.

The reason to introduce this patch was not for podman, but for skopeo.

[--SNIP--]
> I understand that it is not always guaranteed that the qemu machine
> has a rtc and the used kernel has a driver for it, which is why we
> would like to set the date like this.

Exactly.

> But this could be left to the
> test implementer to make sure this is properly handled. And in the
> podman test case, you did.
> 
> What do you think?

I think that setting the time is a generic topic, and that tests should
not need to do that.

Regards,
Yann E. MORIN.


-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot