From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47834C282EC for ; Sat, 8 Mar 2025 19:14:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qjERdohOh4ya5rJq0pmGySw/zVGEhRUr93iR9A1govQ=; b=TzqoFlY4Hnyvk9 70ITvBIz/ti6pfZjM61ORC9bEZKctFWUluixsuYXOh1QYjEQqvg3FS0ee7wKEwtFGYmDAVSVZwmdc HYg5Kf8ilb3q7UCcxhx+tHf/JtUD/8bzylHXG2eu3/BsiCWIHf5bjZRLrfpqi53ChuGc8lsGEvg1Z QUdbQ8X0BeJmcaBjHA8W2Vv7slGGPQa6CMkmIQdScwUFHGbWw/QUoScUAR4JD/dAIkr8EKO4L7LlT opyCdnTdMMcFssn+SrNu55fhv6+hQXi463kI7Ju0i7fDx1ufnXoiYOVNaB7ZB6O0S3V4Xi8d7MtvT P9k4MZNj7lXd/+vCrlbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tqzcj-0000000H5Wk-2dKW; Sat, 08 Mar 2025 19:14:13 +0000 Received: from mout01.posteo.de ([185.67.36.65]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tqz6U-0000000H1ZN-39F4 for linux-mtd@lists.infradead.org; Sat, 08 Mar 2025 18:40:56 +0000 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id B0444240027 for ; Sat, 8 Mar 2025 19:40:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1741459248; bh=otfbaXRx0KCNwf5peLoJ1CCs5/Kof2zck2m5p70R2NE=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:Content-Transfer-Encoding:From; b=mTBtVL1TWiC8G4clZSZq+BE6ABeCrUGM7K0jQBhRzIPo7NmAjPNhD0py6m7frpeLp PItpcLoQIg2hinHO/Z9QW3ARnQo/UIFRTVRWX/C3JZHSHrnskoLf1yJs7C1NsBwCbw KIABpO4Bgm7f/bVPvVjIDroJpUqd+3b4zHezCF6jBqKikmVHITZPVRwxdsBEkFl2gc wLX1gAz2/2B5ARv4uXa3Z30MEQ4dtIkh9cw7Va9JQcrBkoSzIzCgzdU61YitpynTM9 grmeKFm6j45bnS4EMu5MPE0gDS4RAOHTxZS8x4ljAG9tlQuqEi3n393+TGJ+6flnsR eJ1XtRhmsfOtg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Z9Bmr3JbPz9rxB; Sat, 8 Mar 2025 19:40:43 +0100 (CET) Date: Sat, 8 Mar 2025 18:40:43 +0000 From: =?utf-8?Q?J=2E_Neusch=C3=A4fer?= To: Rob Herring , Miquel Raynal Cc: =?utf-8?Q?J=2E_Neusch=C3=A4fer?= , Richard Weinberger , Michael Ellerman , Nicholas Piggin , Conor Dooley , linux-kernel@vger.kernel.org, Crystal Wood , Christophe Leroy , devicetree@vger.kernel.org, Frank Li , Vignesh Raghavendra , Madhavan Srinivasan , linux-mtd@lists.infradead.org, Krzysztof Kozlowski , Krzysztof Kozlowski , Naveen N Rao , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v3 2/3] dt-bindings: nand: Add fsl,elbc-fcm-nand Message-ID: References: <20250226-ppcyaml-elbc-v3-0-a90ed71da838@posteo.net> <20250226-ppcyaml-elbc-v3-2-a90ed71da838@posteo.net> <174059551678.3319332.12055848852503108874.robh@kernel.org> <20250303140021.GA1732495-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250303140021.GA1732495-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250308_104055_079326_6D72B3FA X-CRM114-Status: GOOD ( 21.92 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org TWlxdWVsLCB3aGF0IGRvIHlvdSB0aGluayBhYm91dCBSb2IncyBzdWdnZXN0aW9uIGJlbG93PwoK T24gTW9uLCBNYXIgMDMsIDIwMjUgYXQgMDg6MDA6MjFBTSAtMDYwMCwgUm9iIEhlcnJpbmcgd3Jv dGU6Cj4gT24gV2VkLCBGZWIgMjYsIDIwMjUgYXQgMTI6NDU6MTdQTSAtMDYwMCwgUm9iIEhlcnJp bmcgKEFybSkgd3JvdGU6Cj4gPiAKPiA+IE9uIFdlZCwgMjYgRmViIDIwMjUgMTg6MDE6NDEgKzAx MDAsIEouIE5ldXNjaMOkZmVyIHdyb3RlOgo+ID4gPiBGb3JtYWxpemUgdGhlIGJpbmRpbmcgYWxy ZWFkeSBzdXBwb3J0ZWQgYnkgdGhlIGZzbF9lbGJjX25hbmQuYyBkcml2ZXIKPiA+ID4gYW5kIHVz ZWQgaW4gc2V2ZXJhbCBkZXZpY2UgdHJlZXMgaW4gYXJjaC9wb3dlcnBjL2Jvb3QvZHRzLy4KPiA+ ID4gCj4gPiA+IHJhdy1uYW5kLWNoaXAueWFtbCBpcyByZWZlcmVuY2VkIGluIG9yZGVyIHRvIGFj Y29tbW9kYXRlIHNpdHVhdGlvbnMgaW4KPiA+ID4gd2hpY2ggdGhlIEVDQyBwYXJhbWV0ZXJzIHNl dHRpbmdzIGFyZSBzZXQgaW4gdGhlIGRldmljZSB0cmVlLiBPbmUgc3VjaAo+ID4gPiBleGFtcGxl IGlzIGluIGFyY2gvcG93ZXJwYy9ib290L2R0cy90dXJyaXMxeC5kdHM6Cj4gPiA+IAo+ID4gPiAJ LyogTVQyOUYyRzA4QUJBRUFXUDpFIE5BTkQgKi8KPiA+ID4gCW5hbmRAMSwwIHsKPiA+ID4gCQlj b21wYXRpYmxlID0gImZzbCxwMjAyMC1mY20tbmFuZCIsICJmc2wsZWxiYy1mY20tbmFuZCI7Cj4g PiA+IAkJcmVnID0gPDB4MSAweDAgMHgwMDA0MDAwMD47Cj4gPiA+IAkJbmFuZC1lY2MtbW9kZSA9 ICJzb2Z0IjsKPiA+ID4gCQluYW5kLWVjYy1hbGdvID0gImJjaCI7Cj4gPiA+IAo+ID4gPiAJCXBh cnRpdGlvbnMgeyAuLi4gfTsKPiA+ID4gCX07Cj4gPiA+IAo+ID4gPiBSZXZpZXdlZC1ieTogRnJh bmsgTGkgPEZyYW5rLkxpQG54cC5jb20+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IEouIE5ldXNjaMOk ZmVyIDxqLm5lQHBvc3Rlby5uZXQ+Cj4gPiA+IC0tLQo+ID4gPiAKPiA+ID4gVjM6Cj4gPiA+IC0g cmVtb3ZlIHVubmVjZXNzYXJ5ICNhZGRyZXNzL3NpemUtY2VsbHMgZnJvbSBuYW5kIG5vZGUgaW4g ZXhhbXBsZQo+ID4gPiAtIGFkZCBGcmFuayBMaSdzIHJldmlldyB0YWcKPiA+ID4gLSBhZGQgbWlz c2luZyBlbmQgb2YgZG9jdW1lbnQgbWFya2VyICguLi4pCj4gPiA+IC0gZXhwbGFpbiBjaG9pY2Ug dG8gcmVmZXJlbmNlIHJhdy1uYW5kLWNoaXAueWFtbAo+ID4gPiAKPiA+ID4gVjI6Cj4gPiA+IC0g c3BsaXQgb3V0IGZyb20gZnNsLGVsYmMgYmluZGluZyBwYXRjaAo+ID4gPiAtIGNvbnN0cmFpbiAj YWRkcmVzcy1jZWxscyBhbmQgI3NpemUtY2VsbHMKPiA+ID4gLSBhZGQgYSBnZW5lcmFsIGRlc2Ny aXB0aW9uCj4gPiA+IC0gdXNlIHVuZXZhbHVhdGVkUHJvcGVydGllcz1mYWxzZSBpbnN0ZWFkIG9m IGFkZGl0aW9uYWxQcm9wZXJ0aWVzPWZhbHNlCj4gPiA+IC0gZml4IHByb3BlcnR5IG9yZGVyIHRv IGNvbXBseSB3aXRoIGR0cyBjb2Rpbmcgc3R5bGUKPiA+ID4gLSBpbmNsdWRlIHJhdy1uYW5kLWNo aXAueWFtbCBpbnN0ZWFkIG9mIG5hbmQtY2hpcC55YW1sCj4gPiA+IC0tLQo+ID4gPiAgLi4uL2Rl dmljZXRyZWUvYmluZGluZ3MvbXRkL2ZzbCxlbGJjLWZjbS1uYW5kLnlhbWwgfCA2OCArKysrKysr KysrKysrKysrKysrKysrCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgNjggaW5zZXJ0aW9ucygrKQo+ ID4gPiAKPiA+IAo+ID4gTXkgYm90IGZvdW5kIGVycm9ycyBydW5uaW5nICdtYWtlIGR0X2JpbmRp bmdfY2hlY2snIG9uIHlvdXIgcGF0Y2g6Cj4gPiAKPiA+IHlhbWxsaW50IHdhcm5pbmdzL2Vycm9y czoKPiA+IAo+ID4gZHRzY2hlbWEvZHRjIHdhcm5pbmdzL2Vycm9yczoKPiA+IC9idWlsZHMvcm9i aGVycmluZy9kdC1yZXZpZXctY2kvbGludXgvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL210ZC9mc2wsZWxiYy1mY20tbmFuZC5leGFtcGxlLmR0YjogbmFuZEAxLDA6ICRub2RlbmFt ZTowOiAnbmFuZEAxLDAnIGRvZXMgbm90IG1hdGNoICdebmFuZEBbYS1mMC05XSQnCj4gPiAJZnJv bSBzY2hlbWEgJGlkOiBodHRwOi8vZGV2aWNldHJlZS5vcmcvc2NoZW1hcy9tdGQvZnNsLGVsYmMt ZmNtLW5hbmQueWFtbCMKPiAKPiBEcm9wIHRoZSB1bml0IGFkZHJlc3MgaW4gcmF3LW5hbmQtY2hp cC55YW1sLiBTbzogCj4gCj4gcHJvcGVydGllczoKPiAgICRub2RlbmFtZToKPiAgICAgcGF0dGVy bjogIl5uYW5kQCIKPiAKCl5eXgoKCgpCZXN0IFJlZ2FyZHMsCkouIE5ldXNjaMOkZmVyCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgg TVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DA9FC282EC for ; Sat, 8 Mar 2025 18:41:03 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Z9Bn96cMDz30Ds; Sun, 9 Mar 2025 05:41:01 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=185.67.36.66 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1741459261; cv=none; b=NSDgj1IAQAooM3pJhmaeymVBaWCTnmoBk2rmbtP6JE4t13OsDFsdgYmCjFMsy4U9aFiuI4gGueCmGFQzWDL/qm1PNutBkB7jNTbuhT9WJ37PWOFMe5w9GCv1u3jY0jNjF/aUW6UWM/DM84mOPwRSQyJRD8vIbHqNOnENwfBAUY2A49LCtUq6dykWprXNmUib1O2u9ZL5o+IOH+AzrceEAL3HXN+hJig2H5VfJUzRakyl0nGdDZ4CQGNcimmnsvrKT615MIgKgyAVC9gyap/pU104I1xJRTdINPOtReKnvdiZYBgJmMUu8Bhkt2WrCcNRAIW/C0y6WwWyi1YLmTudDg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1741459261; c=relaxed/relaxed; bh=ntkAe9xdEV8LjYFQm6YWIiGEYr2aZld7i60Ckc+E4So=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gSrrDXozTjctDpaFS+E8y++9znLYoq7cGQHdqPehRMAWOA11opnwDVHsJe416bOcQQb+/4Zcfa31+S9UFu7ufdS79rAVf0WsJ5ML6H+oI2jSb0aOaucjHuIOq6F/Af3CjaNgsZpDLNB5o24bg3+//Y5gloYZW68rgGibE2UL89UGgZ3J9obd73gMCYoFqCWisxh1uTpwFxcTvaqhz/PLWyco5/cl6yoPOTONzyGhoyYslhbXQ+MIfdO5mGgcXfa0zP48hgl2gouS+d5R//zgA1iY71jRFkZMY4xRR67HTWvCDGgkXvxzNbzCqoqjGv7kM8DxsC6Z2w4F3oMJEoUy2A== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=posteo.net; dkim=pass (2048-bit key; secure) header.d=posteo.net header.i=@posteo.net header.a=rsa-sha256 header.s=2017 header.b=mTBtVL1T; dkim-atps=neutral; spf=pass (client-ip=185.67.36.66; helo=mout02.posteo.de; envelope-from=j.ne@posteo.net; receiver=lists.ozlabs.org) smtp.mailfrom=posteo.net Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=posteo.net Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=posteo.net header.i=@posteo.net header.a=rsa-sha256 header.s=2017 header.b=mTBtVL1T; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=posteo.net (client-ip=185.67.36.66; helo=mout02.posteo.de; envelope-from=j.ne@posteo.net; receiver=lists.ozlabs.org) Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Z9Bn664LFz2yyR for ; Sun, 9 Mar 2025 05:40:54 +1100 (AEDT) Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 7C61D240101 for ; Sat, 8 Mar 2025 19:40:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1741459248; bh=otfbaXRx0KCNwf5peLoJ1CCs5/Kof2zck2m5p70R2NE=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:Content-Transfer-Encoding:From; b=mTBtVL1TWiC8G4clZSZq+BE6ABeCrUGM7K0jQBhRzIPo7NmAjPNhD0py6m7frpeLp PItpcLoQIg2hinHO/Z9QW3ARnQo/UIFRTVRWX/C3JZHSHrnskoLf1yJs7C1NsBwCbw KIABpO4Bgm7f/bVPvVjIDroJpUqd+3b4zHezCF6jBqKikmVHITZPVRwxdsBEkFl2gc wLX1gAz2/2B5ARv4uXa3Z30MEQ4dtIkh9cw7Va9JQcrBkoSzIzCgzdU61YitpynTM9 grmeKFm6j45bnS4EMu5MPE0gDS4RAOHTxZS8x4ljAG9tlQuqEi3n393+TGJ+6flnsR eJ1XtRhmsfOtg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Z9Bmr3JbPz9rxB; Sat, 8 Mar 2025 19:40:43 +0100 (CET) Date: Sat, 8 Mar 2025 18:40:43 +0000 From: =?utf-8?Q?J=2E_Neusch=C3=A4fer?= To: Rob Herring , Miquel Raynal Cc: =?utf-8?Q?J=2E_Neusch=C3=A4fer?= , Richard Weinberger , Michael Ellerman , Nicholas Piggin , Conor Dooley , linux-kernel@vger.kernel.org, Crystal Wood , Christophe Leroy , devicetree@vger.kernel.org, Frank Li , Vignesh Raghavendra , Madhavan Srinivasan , linux-mtd@lists.infradead.org, Krzysztof Kozlowski , Krzysztof Kozlowski , Naveen N Rao , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v3 2/3] dt-bindings: nand: Add fsl,elbc-fcm-nand Message-ID: References: <20250226-ppcyaml-elbc-v3-0-a90ed71da838@posteo.net> <20250226-ppcyaml-elbc-v3-2-a90ed71da838@posteo.net> <174059551678.3319332.12055848852503108874.robh@kernel.org> <20250303140021.GA1732495-robh@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250303140021.GA1732495-robh@kernel.org> Miquel, what do you think about Rob's suggestion below? On Mon, Mar 03, 2025 at 08:00:21AM -0600, Rob Herring wrote: > On Wed, Feb 26, 2025 at 12:45:17PM -0600, Rob Herring (Arm) wrote: > > > > On Wed, 26 Feb 2025 18:01:41 +0100, J. Neuschäfer wrote: > > > Formalize the binding already supported by the fsl_elbc_nand.c driver > > > and used in several device trees in arch/powerpc/boot/dts/. > > > > > > raw-nand-chip.yaml is referenced in order to accommodate situations in > > > which the ECC parameters settings are set in the device tree. One such > > > example is in arch/powerpc/boot/dts/turris1x.dts: > > > > > > /* MT29F2G08ABAEAWP:E NAND */ > > > nand@1,0 { > > > compatible = "fsl,p2020-fcm-nand", "fsl,elbc-fcm-nand"; > > > reg = <0x1 0x0 0x00040000>; > > > nand-ecc-mode = "soft"; > > > nand-ecc-algo = "bch"; > > > > > > partitions { ... }; > > > }; > > > > > > Reviewed-by: Frank Li > > > Signed-off-by: J. Neuschäfer > > > --- > > > > > > V3: > > > - remove unnecessary #address/size-cells from nand node in example > > > - add Frank Li's review tag > > > - add missing end of document marker (...) > > > - explain choice to reference raw-nand-chip.yaml > > > > > > V2: > > > - split out from fsl,elbc binding patch > > > - constrain #address-cells and #size-cells > > > - add a general description > > > - use unevaluatedProperties=false instead of additionalProperties=false > > > - fix property order to comply with dts coding style > > > - include raw-nand-chip.yaml instead of nand-chip.yaml > > > --- > > > .../devicetree/bindings/mtd/fsl,elbc-fcm-nand.yaml | 68 ++++++++++++++++++++++ > > > 1 file changed, 68 insertions(+) > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/fsl,elbc-fcm-nand.example.dtb: nand@1,0: $nodename:0: 'nand@1,0' does not match '^nand@[a-f0-9]$' > > from schema $id: http://devicetree.org/schemas/mtd/fsl,elbc-fcm-nand.yaml# > > Drop the unit address in raw-nand-chip.yaml. So: > > properties: > $nodename: > pattern: "^nand@" > ^^^ Best Regards, J. Neuschäfer