All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Michael Kelley <mhklinux@outlook.com>
Cc: Ard Biesheuvel <ardb@kernel.org>,
	"terrelln@fb.com" <terrelln@fb.com>,
	"dsterba@suse.com" <dsterba@suse.com>,
	"brgerst@gmail.com" <brgerst@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Compile problems w/gcc 9.4.0 in linux-next
Date: Fri, 21 Mar 2025 08:38:14 +0100	[thread overview]
Message-ID: <Z90XZqJVwuWkarnX@gmail.com> (raw)
In-Reply-To: <SN6PR02MB41575C4BA0C467B1C95EEB21D4D82@SN6PR02MB4157.namprd02.prod.outlook.com>


* Michael Kelley <mhklinux@outlook.com> wrote:

> > What are your thoughts as maintainers of lib/zstd?
> 
> FYI, the same segfault occurs with gcc 10.5. The problem is fixed
> in gcc 11.4.

So the patch below would work this around on GCC9 and GCC10?

Thanks,

	Ingo

==============>
 lib/zstd/common/portability_macros.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/zstd/common/portability_macros.h b/lib/zstd/common/portability_macros.h
index 0e3b2c0a527d..0dde8bf56595 100644
--- a/lib/zstd/common/portability_macros.h
+++ b/lib/zstd/common/portability_macros.h
@@ -55,7 +55,7 @@
 #ifndef DYNAMIC_BMI2
   #if ((defined(__clang__) && __has_attribute(__target__)) \
       || (defined(__GNUC__) \
-          && (__GNUC__ >= 5 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 8)))) \
+          && (__GNUC__ >= 11))) \
       && (defined(__x86_64__) || defined(_M_X64)) \
       && !defined(__BMI2__)
   #  define DYNAMIC_BMI2 1


  reply	other threads:[~2025-03-21  7:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-20 18:29 Compile problems w/gcc 9.4.0 in linux-next Michael Kelley
2025-03-20 19:19 ` Ard Biesheuvel
2025-03-20 20:41   ` Michael Kelley
2025-03-20 21:58     ` Michael Kelley
2025-03-21  7:38       ` Ingo Molnar [this message]
2025-03-21 15:16         ` Michael Kelley
2025-03-21 18:06           ` Nick Terrell
2025-03-25 10:18             ` Ingo Molnar
2025-03-25 20:47               ` Nick Terrell
2025-03-25 22:05                 ` Ingo Molnar
2025-03-22  7:36           ` Ingo Molnar
2025-03-23  4:58             ` Nick Terrell
2025-03-23 17:52               ` Michael Kelley
2025-03-21  7:37   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z90XZqJVwuWkarnX@gmail.com \
    --to=mingo@kernel.org \
    --cc=ardb@kernel.org \
    --cc=brgerst@gmail.com \
    --cc=dsterba@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhklinux@outlook.com \
    --cc=terrelln@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.