All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Thompson <danielt@kernel.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: lee@kernel.org, pavel@ucw.cz, jingoohan1@gmail.com,
	deller@gmx.de, simona@ffwll.ch, linux-leds@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	Simona Vetter <simona.vetter@ffwll.ch>
Subject: Re: [PATCH v4 06/11] backlight: Replace fb events with a dedicated function call
Date: Fri, 21 Mar 2025 11:26:25 +0000	[thread overview]
Message-ID: <Z91M4fxbAUJOJy5E@aspen.lan> (raw)
In-Reply-To: <20250321095517.313713-7-tzimmermann@suse.de>

On Fri, Mar 21, 2025 at 10:53:59AM +0100, Thomas Zimmermann wrote:
> Remove support for fb events from backlight subsystem. Provide the
> helper backlight_notify_blank_all() instead. Also export the existing
> helper backlight_notify_blank() to update a single backlight device.
>
> In fbdev, call either helper to inform the backlight subsystem of
> changes to a display's blank state. If the framebuffer device has a
> specific backlight, only update this one; otherwise update all.
>
> v4:
> - protect blacklight declarations with IS_REACHABLE() (kernel test robot)

I was convinced by the replies to other things in v4. Thanks!

> v3:
> - declare empty fb_bl_notify_blank() as static inline (kernel test robot)
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Acked-by: Simona Vetter <simona.vetter@ffwll.ch>


Reviewed-by: Daniel Thompson (RISCstar) <danielt@kernel.org>


Daniel.

  reply	other threads:[~2025-03-21 11:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-21  9:53 [PATCH v4 00/11] backlight, lcd, led: Remove fbdev dependencies Thomas Zimmermann
2025-03-21  9:53 ` [PATCH v4 01/11] fbdev: Rework fb_blank() Thomas Zimmermann
2025-03-21  9:53 ` [PATCH v4 02/11] fbdev: Track display blanking state Thomas Zimmermann
2025-03-21  9:53 ` [PATCH v4 03/11] fbdev: Send old blank state in FB_EVENT_BLANK Thomas Zimmermann
2025-03-21  9:53 ` [PATCH v4 04/11] backlight: Implement fbdev tracking with blank state from event Thomas Zimmermann
2025-03-21  9:53 ` [PATCH v4 05/11] backlight: Move blank-state handling into helper Thomas Zimmermann
2025-03-21  9:53 ` [PATCH v4 06/11] backlight: Replace fb events with a dedicated function call Thomas Zimmermann
2025-03-21 11:26   ` Daniel Thompson [this message]
2025-03-21  9:54 ` [PATCH v4 07/11] backlight: lcd: Move event handling into helpers Thomas Zimmermann
2025-03-21  9:54 ` [PATCH v4 08/11] backlight: lcd: Replace fb events with a dedicated function call Thomas Zimmermann
2025-03-21 11:27   ` Daniel Thompson
2025-03-24  7:43     ` Thomas Zimmermann
2025-03-28  8:42       ` Lee Jones
2025-03-28 13:18         ` Thomas Zimmermann
2025-03-21  9:54 ` [PATCH v4 09/11] leds: backlight trigger: Move blank-state handling into helper Thomas Zimmermann
2025-03-21  9:54 ` [PATCH v4 10/11] leds: backlight trigger: Replace fb events with a dedicated function call Thomas Zimmermann
2025-03-21  9:54 ` [PATCH v4 11/11] fbdev: Remove constants of unused events Thomas Zimmermann
2025-04-10  9:39 ` [PATCH v4 00/11] backlight, lcd, led: Remove fbdev dependencies Lee Jones
2025-04-10  9:41   ` Lee Jones
2025-04-15 17:27 ` [GIT PULL] Immutable branch between Backlight, fbdev and LEDs for the v6.16 merge window Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z91M4fxbAUJOJy5E@aspen.lan \
    --to=danielt@kernel.org \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jingoohan1@gmail.com \
    --cc=lee@kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=simona.vetter@ffwll.ch \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.