From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v1 1/4] t: introduce WITH_BREAKING_CHANGES prerequisite
Date: Tue, 11 Mar 2025 13:57:14 +0100 [thread overview]
Message-ID: <Z9AzKoWLeOJ63j_E@pks.im> (raw)
In-Reply-To: <20250310231652.3742490-2-gitster@pobox.com>
On Mon, Mar 10, 2025 at 04:16:49PM -0700, Junio C Hamano wrote:
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 9001ed3a64..12fe82f660 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -1862,6 +1862,11 @@ test_lazy_prereq CURL '
> curl --version
> '
>
> +test_lazy_prereq WITH_BREAKING_CHANGES '
> + test -n "$WITH_BREAKING_CHANGES"
> +'
> +
> +# DEPRECATED; DO NOT USE THIS IN NEW TESTS
> test_lazy_prereq WITHOUT_BREAKING_CHANGES '
> test -z "$WITH_BREAKING_CHANGES"
> '
Do we maybe want to state that this can be removed once the next release
cycle is over? I find it to be a bit more actionable when stating hard
dates after which something can be dropped as it allows any drive-by
developers to act when they notice that Git v2.50 has been released
already.
Patrick
next prev parent reply other threads:[~2025-03-11 12:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 23:16 [PATCH v1 0/4] drop "name-rev --stdin" support Junio C Hamano
2025-03-10 23:16 ` [PATCH v1 1/4] t: introduce WITH_BREAKING_CHANGES prerequisite Junio C Hamano
2025-03-10 23:53 ` Eric Sunshine
2025-03-11 12:57 ` Patrick Steinhardt [this message]
2025-03-11 17:07 ` Junio C Hamano
2025-03-10 23:16 ` [PATCH v1 2/4] t6120: avoid hiding "git" exit status Junio C Hamano
2025-03-10 23:16 ` [PATCH v1 3/4] t6120: further modernize Junio C Hamano
2025-03-10 23:16 ` [PATCH v1 4/4] name-rev: remove "--stdin" support Junio C Hamano
2025-03-11 12:57 ` Patrick Steinhardt
2025-03-11 17:07 ` Junio C Hamano
2025-03-11 21:24 ` [PATCH v2 0/6] drop "name-rev --stdin" support Junio C Hamano
2025-03-11 21:25 ` [PATCH v2 1/6] t: document test_lazy_prereq Junio C Hamano
2025-03-11 21:25 ` [PATCH v2 2/6] t: extend test_lazy_prereq Junio C Hamano
2025-03-12 7:01 ` Patrick Steinhardt
2025-03-13 11:56 ` Junio C Hamano
2025-03-11 21:25 ` [PATCH v2 3/6] t: introduce WITH_BREAKING_CHANGES prerequisite Junio C Hamano
2025-03-12 7:01 ` Patrick Steinhardt
2025-03-11 21:25 ` [PATCH v2 4/6] t6120: avoid hiding "git" exit status Junio C Hamano
2025-03-11 21:25 ` [PATCH v2 5/6] t6120: further modernize Junio C Hamano
2025-03-11 21:25 ` [PATCH v2 6/6] name-rev: remove "--stdin" support Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9AzKoWLeOJ63j_E@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.