From: Henrique Carvalho <henrique.carvalho@suse.com>
To: Enzo Matsumiya <ematsumiya@suse.de>
Cc: sfrench@samba.org, pc@manguebit.com, ronniesahlberg@gmail.com,
sprasad@microsoft.com, tom@talpey.com, bharathsm@microsoft.com,
linux-cifs@vger.kernel.org
Subject: Re: [PATCH] smb: client: Fix match_session bug causing duplicate session creation
Date: Tue, 11 Mar 2025 15:27:29 -0300 [thread overview]
Message-ID: <Z9CAkVAr8O9EQwsL@precision> (raw)
In-Reply-To: <qzsu6rfpof7ipuaaszyt6opjoepnmxfgdgqzecmrnz4itdl5rn@gb3haoqrul55>
On Tue, Mar 11, 2025 at 10:39:37AM -0300, Enzo Matsumiya wrote:
> Minor nit: I think your reproducer results are inverted -- on my tests,
> the session is reused when sec=ntlmssp is passed on first mount, not the
> other way around.
> Calling select_sectype() with ctx->sectype as argument works fine for
> Unspecified and ntlmssp* cases (because Unspecified will default to
> ntlmssp if server supports it), but if you do the first mount with
> sec=krb5 and the second with sec=ntlmssp/no sec=, the krb5 session
> will be reused (which is wrong).
Both fixed on v2.
Thanks, Enzo.
Henrique
prev parent reply other threads:[~2025-03-11 18:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 1:32 [PATCH] smb: client: Fix match_session bug causing duplicate session creation Henrique Carvalho
2025-03-11 2:53 ` Steve French
2025-03-11 13:39 ` Enzo Matsumiya
2025-03-11 18:27 ` Henrique Carvalho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9CAkVAr8O9EQwsL@precision \
--to=henrique.carvalho@suse.com \
--cc=bharathsm@microsoft.com \
--cc=ematsumiya@suse.de \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@manguebit.com \
--cc=ronniesahlberg@gmail.com \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.