From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2 1/3] tests/functional/asset: Fail assert fetch when retries are exceeded
Date: Wed, 12 Mar 2025 12:27:28 +0000 [thread overview]
Message-ID: <Z9F9sIDl4EfQ0uVX@redhat.com> (raw)
In-Reply-To: <20250312122559.944533-2-npiggin@gmail.com>
On Wed, Mar 12, 2025 at 10:25:56PM +1000, Nicholas Piggin wrote:
> Currently the fetch code does not fail gracefully when retry limit is
> exceeded, it just falls through the loop with no file, which ends up
> hitting other errors.
>
> Add a check for non-existing file, which indicates the retry limit was
> exceeded.
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> tests/functional/qemu_test/asset.py | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-03-12 12:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 12:25 [PATCH v2 0/3] tests/functional/asset: improve partial-download handling Nicholas Piggin
2025-03-12 12:25 ` [PATCH v2 1/3] tests/functional/asset: Fail assert fetch when retries are exceeded Nicholas Piggin
2025-03-12 12:27 ` Daniel P. Berrangé [this message]
2025-03-12 12:25 ` [PATCH v2 2/3] tests/functional/asset: Verify downloaded size Nicholas Piggin
2025-03-12 12:27 ` Daniel P. Berrangé
2025-03-12 12:25 ` [PATCH v2 3/3] tests/functional/asset: Add AssetError exception class Nicholas Piggin
2025-03-12 12:29 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9F9sIDl4EfQ0uVX@redhat.com \
--to=berrange@redhat.com \
--cc=npiggin@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.