Re: [PATCH 6.13.y] mm/slab/kvfree_rcu: Switch to WQ_MEM_RECLAIM wq

[Uladzislau Rezki <urezki@gmail.com>]

On Tue, Mar 11, 2025 at 09:33:38PM +0100, Vlastimil Babka wrote:
> On 3/11/25 17:59, Uladzislau Rezki (Sony) wrote:
> 
> The first line of the changelog needs to say:
> 
> commit dfd3df31c9db752234d7d2e09bef2aeabb643ce4 upstream.
> 
> I think Greg prefers if you resend with that fixed rather than fixing up
> locally.
> If the same backport applies to both 6.12 and 6.13 (it seems to me it does?)
> I guess a single mail with [PATCH 6.12.y 6.13.y] could be enough.
> 
Thank you. I will make one for both kernels.

> > Apart of that, since kvfree_rcu() does reclaim memory it is worth
> > to go with WQ_MEM_RECLAIM type of wq because it is designed for
> > this purpose.
> > 
> > Fixes: 6c6c47b063b5 ("mm, slab: call kvfree_rcu_barrier() from kmem_cache_destroy()"),
> > Reported-by: Keith Busch <kbusch@kernel.org>
> > Closes: https://lore.kernel.org/all/Z7iqJtCjHKfo8Kho@kbusch-mbp/
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
> > Reviewed-by: Joel Fernandes <joelagnelf@nvidia.com>
> > Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
> 
> I don't know if you need to add another
> Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
> 
> opinions on that differ and not sure where stable stands...
> (does "git commit -s" add it or detects your previous one?)
> 
"-s" IMO should add it. But i will check.

Thank you for the comments!

--
Uladzislau Rezki