From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Kohei Enju <enjuk@amazon.com>
Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org,
syzbot+83fed965338b573115f7@syzkaller.appspotmail.com,
Jozsef Kadlecsik <kadlec@netfilter.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Yi-Hung Wei <yihung.wei@gmail.com>,
Florian Westphal <fw@strlen.de>,
kohei.enju@gmail.com
Subject: Re: [PATCH net v1] netfilter: nf_conncount: Fully initialize struct nf_conncount_tuple in insert_tree()
Date: Wed, 12 Mar 2025 15:36:28 +0100 [thread overview]
Message-ID: <Z9Gb7O7puuERyyww@calendula> (raw)
In-Reply-To: <20250309080816.87224-2-enjuk@amazon.com>
On Sun, Mar 09, 2025 at 05:07:38PM +0900, Kohei Enju wrote:
> Since commit b36e4523d4d5 ("netfilter: nf_conncount: fix garbage
> collection confirm race"), `cpu` and `jiffies32` were introduced to
> the struct nf_conncount_tuple.
>
> The commit made nf_conncount_add() initialize `conn->cpu` and
> `conn->jiffies32` when allocating the struct.
> In contrast, count_tree() was not changed to initialize them.
>
> By commit 34848d5c896e ("netfilter: nf_conncount: Split insert and
> traversal"), count_tree() was split and the relevant allocation
> code now resides in insert_tree().
> Initialize `conn->cpu` and `conn->jiffies32` in insert_tree().
Applied to nf.git, thanks
prev parent reply other threads:[~2025-03-12 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-09 8:07 [PATCH net v1] netfilter: nf_conncount: Fully initialize struct nf_conncount_tuple in insert_tree() Kohei Enju
2025-03-09 9:42 ` Florian Westphal
2025-03-12 14:36 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9Gb7O7puuERyyww@calendula \
--to=pablo@netfilter.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=coreteam@netfilter.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=enjuk@amazon.com \
--cc=fw@strlen.de \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kadlec@netfilter.org \
--cc=kohei.enju@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+83fed965338b573115f7@syzkaller.appspotmail.com \
--cc=yihung.wei@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.