From: Joerg Roedel <jroedel@suse.de>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Joerg Roedel <joro@8bytes.org>,
x86@kernel.org, hpa@zytor.com, Nikunj A Dadhania <nikunj@amd.com>,
Larry.Dewey@amd.com, linux-kernel@vger.kernel.org,
linux-coco@lists.linux.dev, Juergen Gross <jgross@suse.com>,
kirill.shutemov@linux.intel.com, alexey.gladkov@intel.com
Subject: Re: [PATCH 2/2] x86/sev: Make SEV_STATUS available via SYSFS
Date: Wed, 12 Mar 2025 15:56:57 +0100 [thread overview]
Message-ID: <Z9GguXasI5AaLMKv@suse.de> (raw)
In-Reply-To: <8d58b03e-9017-c800-4379-f2a667fb8a9b@amd.com>
Hi Tom,
On Wed, Mar 12, 2025 at 09:46:45AM -0500, Tom Lendacky wrote:
> On 3/12/25 09:41, Joerg Roedel wrote:
> > +static ssize_t sev_status_show(struct kobject *kobj,
> > + struct kobj_attribute *attr, char *buf)
> > +{
> > + return sysfs_emit(buf, "%llx\n", sev_status);
>
> Should it be prefixed with '0x'? That would make use of functions like
> atoi() and strtol() easier.
Yes, it probably should. Currently I see just a '7' in the file, which
gives no clue about the used base. I will change that in the next
version.
Regards,
--
Jörg Rödel
jroedel@suse.de
SUSE Software Solutions Germany GmbH
Frankenstraße 146
90461 Nürnberg
Germany
https://www.suse.com/
Geschäftsführer: Ivo Totev, Andrew McDonald, Werner Knoblich
(HRB 36809, AG Nürnberg)
next prev parent reply other threads:[~2025-03-12 14:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 14:41 [PATCH 0/2 v2] Move SEV sysfs information and expose MSR_SEV_STATUS Joerg Roedel
2025-03-12 14:41 ` [PATCH 1/2] x86/coco/sev: Move SEV SYSFS group to /sys/hypervisor/ Joerg Roedel
2025-03-12 15:11 ` Tom Lendacky
2025-03-12 15:13 ` Joerg Roedel
2025-03-12 15:32 ` Liam Merwick
2025-03-12 15:43 ` Joerg Roedel
2025-03-12 14:41 ` [PATCH 2/2] x86/sev: Make SEV_STATUS available via SYSFS Joerg Roedel
2025-03-12 14:46 ` Tom Lendacky
2025-03-12 14:56 ` Joerg Roedel [this message]
2025-03-12 14:57 ` Dave Hansen
2025-03-12 15:07 ` Joerg Roedel
2025-03-12 16:04 ` Dave Hansen
2025-03-12 16:19 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9GguXasI5AaLMKv@suse.de \
--to=jroedel@suse.de \
--cc=Larry.Dewey@amd.com \
--cc=alexey.gladkov@intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=joro@8bytes.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=nikunj@amd.com \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.