From: Ido Schimmel <idosch@nvidia.com>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: amcohen@nvidia.com, horms@kernel.org, davem@davemloft.net,
edumazet@google.com, ivecera@redhat.com, jiri@resnulli.us,
kuba@kernel.org, netdev@vger.kernel.org, olteanv@gmail.com,
pabeni@redhat.com, petrm@nvidia.com, tobias@waldekranz.com
Subject: Re: [PATCH net] net: switchdev: Convert blocking notification chain to a raw one
Date: Wed, 12 Mar 2025 19:50:11 +0200 [thread overview]
Message-ID: <Z9HJUx4mnGKLBZMn@shredder> (raw)
In-Reply-To: <20250311081418.12713-1-kuniyu@amazon.com>
On Tue, Mar 11, 2025 at 01:12:50AM -0700, Kuniyuki Iwashima wrote:
> From: Simon Horman <horms@kernel.org>
> > As you may be aware there is quite some activity to reduce the reliance on
> > RTNL. However, as the events in question are already protected by RTNL
> > I think the approach you have taken here is entirely reasonable.
>
> It would be appreicated if Amit you can post a follow-up patch against
> net-next.git to convert the rtnl_lock() to another lock or rtnl_net_lock().
We're obviously aware of the RTNL related work and we thought about
making these notification chains (atomic and blocking) per-netns, but
it's not something that can be submitted as a fix.
I will look into it, but there are some listeners that I'm not sure how
to convert. I can register them with "&init_net" for RFC. Hopefully the
relevant maintainers will be able to help with that.
Note that we will need to keep ASSERT_RTNL() in
call_switchdev_blocking_notifiers() until all the callers are converted
to per-netns RTNL.
next prev parent reply other threads:[~2025-03-12 17:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 12:15 [PATCH net] net: switchdev: Convert blocking notification chain to a raw one Amit Cohen
2025-03-10 6:17 ` Simon Horman
2025-03-11 8:12 ` Kuniyuki Iwashima
2025-03-12 17:50 ` Ido Schimmel [this message]
2025-03-11 0:11 ` Vladimir Oltean
2025-03-11 11:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9HJUx4mnGKLBZMn@shredder \
--to=idosch@nvidia.com \
--cc=amcohen@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=tobias@waldekranz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.