From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Jean Delvare <jdelvare@suse.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] firmware: dmi: Respect buffer size in get_modalias
Date: Wed, 12 Mar 2025 22:54:03 +0300 [thread overview]
Message-ID: <Z9HmWxbTulCfBJfL@grain> (raw)
In-Reply-To: <Z7eWSCCqp_HP3iSh@grain>
On Thu, Feb 20, 2025 at 11:53:28PM +0300, Cyrill Gorcunov wrote:
> When we collect data from DMI data the result is accumulated either
> in a page buffer from sysfs entry or from uevent environment buffer.
> Both are big enough (4K and 2K) and it is hard to imagine that we
> overflow 4K page with the data, still the situation is different for
> uevent buffer where buffer may be already filled with data and we
> possibly may overflow it.
>
> Thus lets respect buffer size given by a caller and never write
> data unconditionally.
>
> CC: Jean Delvare <jdelvare@suse.com>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
Ping?
next prev parent reply other threads:[~2025-03-12 19:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 20:53 [PATCH] firmware: dmi: Respect buffer size in get_modalias Cyrill Gorcunov
2025-03-12 19:54 ` Cyrill Gorcunov [this message]
2025-03-13 18:41 ` Jean Delvare
2025-03-13 22:11 ` Cyrill Gorcunov
2025-03-29 22:39 ` [PATCH v2] " Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9HmWxbTulCfBJfL@grain \
--to=gorcunov@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.