From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C70E1C282DE for ; Thu, 13 Mar 2025 10:16:56 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.911813.1318207 (Exim 4.92) (envelope-from ) id 1tsfcH-0002H9-JB; Thu, 13 Mar 2025 10:16:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 911813.1318207; Thu, 13 Mar 2025 10:16:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tsfcH-0002H2-GH; Thu, 13 Mar 2025 10:16:41 +0000 Received: by outflank-mailman (input) for mailman id 911813; Thu, 13 Mar 2025 10:16:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tsfcF-0002Gw-G9 for xen-devel@lists.xenproject.org; Thu, 13 Mar 2025 10:16:39 +0000 Received: from mail128-10.atl41.mandrillapp.com (mail128-10.atl41.mandrillapp.com [198.2.128.10]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3f4f883e-fff4-11ef-9ab9-95dc52dad729; Thu, 13 Mar 2025 11:16:37 +0100 (CET) Received: from pmta08.mandrill.prod.atl01.rsglab.com (localhost [127.0.0.1]) by mail128-10.atl41.mandrillapp.com (Mailchimp) with ESMTP id 4ZD3Lr2QTMzLfHTDM for ; Thu, 13 Mar 2025 10:16:36 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id d96656fc4bef4c46a67b20849d138f86; Thu, 13 Mar 2025 10:16:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f4f883e-fff4-11ef-9ab9-95dc52dad729 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; s=mte1; t=1741860996; x=1742130996; bh=9OLHqGV56y1iWNtM4YA49so3Lpe1f8FMl65Ei94dkao=; h=From:Subject:To:Cc:Message-Id:References:In-Reply-To:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=U/GlslXtcnLPKmODogomWnYEBesd0WJxIzutbah4YoL5jye6COSHUT4fvBAYvoUps 2Cgm7omOupCpM6ACz7aGUVHYpaoMevA8uQwY8/Av8oU3YOiDgFlV5m0F6sY0uPOmZJ UFfUHzEf8qyaeL07u4bLq94O7ms9evN0Zif26GwZFtUTeiZ3ITXAgmRNrxOhyPbvUd KNQW1t1Vun1HG1cvDGEohtreGBbOl8JGKaIEAYq0oY3XVd2YwogYIoEZRCH7M/lrYA RFJ90mRZSDdgrO2nUTDP2fWhcJN4JpjaUBivT4iVhUmSIFKJtR6jIvTDPlaW5suJ0z 10LXMWXkDid9w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; s=mte1; t=1741860996; x=1742121496; i=anthony.perard@vates.tech; bh=9OLHqGV56y1iWNtM4YA49so3Lpe1f8FMl65Ei94dkao=; h=From:Subject:To:Cc:Message-Id:References:In-Reply-To:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=h8tIiW59Z9bTtud3IPzgnD6wwJ+9t6h91BLOq1Ku7qFMuY0gl6kwioh71kph6rdw+ aIeFTfPlJYfKBsADH3E3FczYLQYP6nvuVJ7uKF8ivCYwBgOhRF9voNyQMOMOYYb6uq Wzv5NdtJriHrgVcXpMdaNBcSnGHSiw34eoJJrBoWiKfGV0tDrJUajm90V6uTPgCfSa gH6A+Fg/rK6NnMwoT8DrdszmoUnrGLUs5rWAJx4HezgRwDrCcZ1f3SNe13Bxt8JDUt 2RCZpdLimGFOUgeOz8Oytvo+nfgsj88QeMt18auR5WPuODbSMIXYLhB7ZEFUZRk+jX YHlzIWTH9WNdA== From: "Anthony PERARD" Subject: =?utf-8?Q?Re:=20[PATCH=20v3]=20docs:=20specify=20numerical=20values=20of=20Xenstore=20commands?= X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1741860994568 To: "=?utf-8?Q?J=C3=BCrgen=20Gro=C3=9F?=" Cc: xen-devel@lists.xenproject.org, "Andrew Cooper" , "Michal Orzel" , "Jan Beulich" , "Julien Grall" , "=?utf-8?Q?Roger=20Pau=20Monn=C3=A9?=" , "Stefano Stabellini" Message-Id: References: <20250312084143.14045-1-jgross@suse.com> In-Reply-To: X-Native-Encoded: 1 X-Report-Abuse: =?UTF-8?Q?Please=20forward=20a=20copy=20of=20this=20message,=20including=20all=20headers,=20to=20abuse@mandrill.com.=20You=20can=20also=20report=20abuse=20here:=20https://mandrillapp.com/contact/abuse=3Fid=3D30504962.d96656fc4bef4c46a67b20849d138f86?= X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20250313:md Date: Thu, 13 Mar 2025 10:16:36 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Thu, Mar 13, 2025 at 10:51:06AM +0100, J=C3=BCrgen Gro=C3=9F wrote: > On 12.03.25 17:46, Anthony PERARD wrote: > > On Wed, Mar 12, 2025 at 09:41:43AM +0100, Juergen Gross wrote: > > > diff --git a/docs/misc/xenstore.txt b/docs/misc/xenstore.txt > > > index 7e1f031520..72db73deef 100644 > > > --- a/docs/misc/xenstore.txt > > > +++ b/docs/misc/xenstore.txt > > > @@ -86,6 +86,67 @@ parts of xenstore inaccessible to some clients. I= n any case passing > > > +XS_CONTROL 0 optional > > > + If not supported, xenstore-control command will not work. > > > + XS_DEBUG is a deprecated alias of XS_CONTROL. > > > +XS_DIRECTORY 1 > > > +XS_READ 2 > > > +XS_GET_PERMS 3 > > > > This new table prefix message type names with "XS_", but the rest of th= e > > document describe each type without the prefix. Isn't it going to be > > confusing, and make it slightly harder to link this table to rest of th= e > > document? (I often search by full word, like '\', because > > that one key stroke in vim '*', so having different prefix makes it > > harder to search) > > Question is, should I change the table to drop "XS_", or the rest documen= t > to add "XS_" instead? After all xs_wire.h is defining the names with "XS_= ". > > I'm slightly leaning towards a preparatory patch adding "XS_". Well, I'm actually for dropping the prefix from the table. The prefix is more of a C specific namespace than anything else. The ocaml implementation in tree doesn't use this prefix, but a different one (if we ignore the different case: > Xenbus.Xb.Op.Watch https://elixir.bootlin.com/xen/v4.20.0/source/tools/ocaml/xenstored/process= .ml#L632 And have a link to a string without the prefix: > | Watch=09=09=09-> "WATCH" https://elixir.bootlin.com/xen/v4.20.0/source/tools/ocaml/libs/xb/op.ml#L49 There's also a version in Rust which also use a different prefix, "XsMessageType::". https://github.com/Wenzel/xenstore/blob/f82bd45cbcd1aa98306c57d35847e3d77f7= cc8ee/src/wire.rs#L55 So the prefix is really programming language specific and I don't think introducing it to this document would be useful. Thanks, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech