All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
Subject: Re: [PATCH v2 13/13] arch, mm: make releasing of memory to page allocator more explicit
Date: Thu, 13 Mar 2025 17:34:55 +0200	[thread overview]
Message-ID: <Z9L7H2uugWRNCDVL@kernel.org> (raw)
In-Reply-To: <CAMuHMdWCBL_cg1NgbHCA3e9GTob_P9mTuN_Tepvigci6rxDmbg@mail.gmail.com>

(reduced 'cc to m68k list)

Hi Geert,

On Thu, Mar 13, 2025 at 04:19:10PM +0100, Geert Uytterhoeven wrote:
> On Thu, 13 Mar 2025 at 14:53, Mike Rapoport <rppt@kernel.org> wrote:
> > From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
> >
> > The point where the memory is released from memblock to the buddy allocator
> > is hidden inside arch-specific mem_init()s and the call to
> > memblock_free_all() is needlessly duplicated in every artiste cure and
> > after introduction of arch_mm_preinit() hook, mem_init() implementation on
> > many architecture only contains the call to memblock_free_all().
> >
> > Pull memblock_free_all() call into mm_core_init() and drop mem_init() on
> > relevant architectures to make it more explicit where the free memory is
> > released from memblock to the buddy allocator and to reduce code
> > duplication in architecture specific code.
> >
> > Acked-by: Dave Hansen <dave.hansen@linux.intel.com>     # x86
> > Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> 
> >  arch/m68k/mm/init.c          |  2 --
> 
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> # m68k

Thanks :)

While working on this I was wondering if init_pointer_tables() can be moved
from mem_init() to motorola::paging_init(). It seems to me that it can, but
I wasn't sure enough so I left it there for now.
 
> Gr{oetje,eeting}s,
> 
>                         Geert

-- 
Sincerely yours,
Mike.

  reply	other threads:[~2025-03-13 15:35 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-13 13:49 [PATCH v2 00/13] arch, mm: reduce code duplication in mem_init() Mike Rapoport
2025-03-13 13:49 ` Mike Rapoport
2025-03-13 13:49 ` Mike Rapoport
2025-03-13 13:49 ` [PATCH v2 01/13] arm: mem_init: use memblock_phys_free() to free DMA memory on SA1111 Mike Rapoport
2025-03-13 13:49   ` Mike Rapoport
2025-03-13 13:49   ` Mike Rapoport
2025-03-13 13:49 ` [PATCH v2 02/13] csky: move setup_initrd() to setup.c Mike Rapoport
2025-03-13 13:49   ` Mike Rapoport
2025-03-13 13:49   ` Mike Rapoport
2025-03-13 13:49 ` [PATCH v2 03/13] hexagon: move initialization of init_mm.context init to paging_init() Mike Rapoport
2025-03-13 13:49   ` Mike Rapoport
2025-03-13 13:49   ` Mike Rapoport
2025-03-13 13:49 ` [PATCH v2 04/13] MIPS: consolidate mem_init() for NUMA machines Mike Rapoport
2025-03-13 13:49   ` Mike Rapoport
2025-03-13 13:49   ` Mike Rapoport
2025-03-13 13:49 ` [PATCH v2 05/13] MIPS: make setup_zero_pages() use memblock Mike Rapoport
2025-03-13 13:49   ` Mike Rapoport
2025-03-13 13:49   ` Mike Rapoport
2025-03-13 13:49 ` [PATCH v2 06/13] nios2: move pr_debug() about memory start and end to setup_arch() Mike Rapoport
2025-03-13 13:49   ` Mike Rapoport
2025-03-13 13:49   ` Mike Rapoport
2025-03-17 12:40   ` Dinh Nguyen
2025-03-17 12:40     ` Dinh Nguyen
2025-03-17 12:40     ` Dinh Nguyen
2025-03-13 13:49 ` [PATCH v2 07/13] s390: make setup_zero_pages() use memblock Mike Rapoport
2025-03-13 13:49   ` Mike Rapoport
2025-03-13 13:49   ` Mike Rapoport
2025-03-13 13:49 ` [PATCH v2 08/13] xtensa: split out printing of virtual memory layout to a function Mike Rapoport
2025-03-13 13:49   ` Mike Rapoport
2025-03-13 13:49   ` Mike Rapoport
2025-03-13 17:14   ` Max Filippov
2025-03-13 17:14     ` Max Filippov
2025-03-13 17:14     ` Max Filippov
2025-03-13 13:49 ` [PATCH v2 09/13] arch, mm: set max_mapnr when allocating memory map for FLATMEM Mike Rapoport
2025-03-13 13:49   ` Mike Rapoport
2025-03-13 13:49   ` Mike Rapoport
2025-03-14  9:25   ` Christophe Leroy
2025-03-14  9:25     ` Christophe Leroy
2025-03-14  9:25     ` Christophe Leroy
2025-04-08  5:48     ` Christophe Leroy
2025-04-08  5:48       ` Christophe Leroy
2025-04-08  5:48       ` Christophe Leroy
2025-03-13 13:50 ` [PATCH v2 10/13] arch, mm: set high_memory in free_area_init() Mike Rapoport
2025-03-13 13:50   ` Mike Rapoport
2025-03-13 13:50   ` Mike Rapoport
2025-04-02 12:19   ` Thomas Weißschuh
2025-04-02 12:46     ` Mike Rapoport
2025-04-02 13:07       ` Thomas Weißschuh
2025-04-02 16:31         ` Thomas Weißschuh
2025-04-02 19:12           ` Naresh Kamboju
2025-04-02 20:18           ` Mike Rapoport
2025-04-02 22:19             ` Andrew Morton
2025-05-16 15:28   ` Pratyush Yadav
2025-05-16 15:28     ` Pratyush Yadav
2025-05-16 15:28     ` Pratyush Yadav
2025-05-16 17:01     ` Mike Rapoport
2025-05-16 17:01       ` Mike Rapoport
2025-05-16 17:01       ` Mike Rapoport
2025-05-19 15:54       ` Alexandre Ghiti
2025-05-19 15:54         ` Alexandre Ghiti
2025-05-19 15:54         ` Alexandre Ghiti
2025-05-19 17:19         ` Mike Rapoport
2025-05-19 17:19           ` Mike Rapoport
2025-05-19 17:19           ` Mike Rapoport
2025-03-13 13:50 ` [PATCH v2 11/13] arch, mm: streamline HIGHMEM freeing Mike Rapoport
2025-03-13 13:50   ` Mike Rapoport
2025-03-13 13:50   ` Mike Rapoport
2025-03-23 19:06   ` Nathan Chancellor
2025-03-13 13:50 ` [PATCH v2 12/13] arch, mm: introduce arch_mm_preinit Mike Rapoport
2025-03-13 13:50   ` Mike Rapoport
2025-03-13 13:50   ` Mike Rapoport
2025-03-13 13:50 ` [PATCH v2 13/13] arch, mm: make releasing of memory to page allocator more explicit Mike Rapoport
2025-03-13 13:50   ` Mike Rapoport
2025-03-13 13:50   ` Mike Rapoport
2025-03-13 15:19   ` Geert Uytterhoeven
2025-03-13 15:19     ` Geert Uytterhoeven
2025-03-13 15:19     ` Geert Uytterhoeven
2025-03-13 15:34     ` Mike Rapoport [this message]
2025-03-13 15:51       ` Geert Uytterhoeven
2025-03-13 15:56         ` Geert Uytterhoeven
2025-03-13 16:39         ` Mike Rapoport
2025-03-13 18:31         ` Michael Schmitz
2025-03-14  8:51           ` Geert Uytterhoeven
2025-03-14  9:06             ` Michael Schmitz
2025-03-14  9:13               ` Geert Uytterhoeven
2025-03-13 16:39 ` [PATCH v2 00/13] arch, mm: reduce code duplication in mem_init() Mark Brown
2025-03-13 16:39   ` Mark Brown
2025-03-13 16:39   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z9L7H2uugWRNCDVL@kernel.org \
    --to=rppt@kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.