From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>
Cc: Mark Brown <broonie@kernel.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
sound-open-firmware@alsa-project.org,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Liam Girdwood <lgirdwood@gmail.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>
Subject: Re: [PATCH v1 1/1] ASoC: SOF: ipc4-topology: Allocate ref_params on stack
Date: Thu, 13 Mar 2025 13:27:44 +0200 [thread overview]
Message-ID: <Z9LBMEvlRoiVNsvi@smile.fi.intel.com> (raw)
In-Reply-To: <bdc7b218-8f14-4bfd-8a76-2f35e5a9393c@linux.intel.com>
On Thu, Mar 13, 2025 at 01:21:17PM +0200, Péter Ujfalusi wrote:
> On 12/03/2025 18:05, Andy Shevchenko wrote:
> > Currently the compiler (clang 19.1.7) is not happy about the size of
> > the stack frame in sof_ipc4_prepare_copier_module:
> >
> > sound/soc/sof/ipc4-topology.c:1800:1: error: stack frame size (1288) exceeds limit (1024) in 'sof_ipc4_prepare_copier_module' [-Werror,-Wframe-larger-than]
> > 1800 | sof_ipc4_prepare_copier_module(struct snd_sof_widget *swidget,
> > | ^
> >
> > Work around this by allocating ref_params on stack, as it looks the biggest
> > variable on stack right now.
> >
> > Note, this only happens when compile for 32-bit machines (x86_32 in my case).
>
> I don't have better idea for fix, apart from somehow refactor this huge
> function.
> Thank you for the fix,
>
> Acked-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Thank you for looking into it!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-03-13 11:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 16:05 [PATCH v1 1/1] ASoC: SOF: ipc4-topology: Allocate ref_params on stack Andy Shevchenko
2025-03-13 11:21 ` Péter Ujfalusi
2025-03-13 11:27 ` Andy Shevchenko [this message]
2025-03-13 19:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9LBMEvlRoiVNsvi@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=justinstitt@google.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.