From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail177-1.suw61.mandrillapp.com (mail177-1.suw61.mandrillapp.com [198.2.177.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8CF21FFC43 for ; Fri, 14 Mar 2025 13:35:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.2.177.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741959304; cv=none; b=RnENPPEmqay64sHp3m88xWtx8eBj6owN+SMo/ZkeWzzAjS4Koehx8jPgYywkq6IKpUvxWI/8XtueX+8vi8Ox4Jo/XsVvqDW3gdsKWrjbQW2+/39Rqp9AKaznIcIV6DUzBiUlNjtbV8u8Ap3nT2j5fcwp+y/MqZzrJ0oXjRa8VBg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741959304; c=relaxed/simple; bh=7GbmtLroPdOLeL7Hde3KJhDExoaO1SitOpm9AV+s6hw=; h=From:Subject:To:Cc:Message-Id:References:In-Reply-To:Date: MIME-Version:Content-Type; b=SHy6FIK0zyWV6CFzDi2PEj++NY56MtDh9oX3HOk/hgKU+FS7veR3IMDQJTck4MAwcwjUl7xMFkz7kv+KBuagUvtc2vVsFsM5FUit7naGm75Sk7JSqHwdW04em+qRvH9jfmcW9EHSvKmLJDLWm4lqdX/oN4yCbqpWSzXrF0tp69I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vates.tech; spf=pass smtp.mailfrom=bounce.vates.tech; dkim=pass (2048-bit key) header.d=mandrillapp.com header.i=@mandrillapp.com header.b=H3ia/hIF; dkim=pass (2048-bit key) header.d=vates.tech header.i=anthony.perard@vates.tech header.b=xXviNbD/; arc=none smtp.client-ip=198.2.177.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vates.tech Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bounce.vates.tech Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mandrillapp.com header.i=@mandrillapp.com header.b="H3ia/hIF"; dkim=pass (2048-bit key) header.d=vates.tech header.i=anthony.perard@vates.tech header.b="xXviNbD/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; s=mte1; t=1741959301; x=1742229301; bh=uG1KcJgwcW9T2cGN3oyD/12pz8pEMNAmvmnymfhPGS4=; h=From:Subject:To:Cc:Message-Id:References:In-Reply-To:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=H3ia/hIF/AvPIg2zvwqJJ/XG53RwDPeyxXpzzwqVB97t/cXZDqEczwu6aBV17xDcy ZomkPHanrox4PXIm4b1nsQzoBZ+g7+A5amnJtuYgc+xPVFX1xAZcjGfJ6eoMnbKL+u H8nuIfz2GLHCHi/7/S6BsMn6X/x1hUIoDSKYtXOEm0QU6r8tgvMvQMslpIasw5V+0g mvJgB28UT/Omci0aus2UW5mynCwm1CZrnCpmksc+TP3gCGmFTlv3FMj3Kmgxw4E8JJ QpeW3t2wPWP5RlUc3p8DyxvjGIhbKvnsjbcOC+yKaldFZT7wWvGypIHWGu5tKnw4EQ p//D5o6V1ILJQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; s=mte1; t=1741959301; x=1742219801; i=anthony.perard@vates.tech; bh=uG1KcJgwcW9T2cGN3oyD/12pz8pEMNAmvmnymfhPGS4=; h=From:Subject:To:Cc:Message-Id:References:In-Reply-To:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=xXviNbD/+I9vW+blP78O91Jq2Bu8xSZd60y1qpnpoWTl02j4F1eOuh6YUjeqakom4 AYOTPZp4gOtLKtyclf80bbw5maHHV7fSRruOtvhlPa+uD63TIcNmMqVWHzuiIVwT4l LuS7LbhGJ9Glnf0ikqLTzpIlZfHbOsGPKMbne53NRIlKa5xEdV4+Ufzfz2CXPqt7yZ O1eYERBfcZkrjhSCj5m3sRl+Nf6AnYU2/rX0CdwSBNml0AHCyMMkJ/v+agPRPNlVnK A+KB53PJfKmj3tyQkM1yewApW9fD28OMfHK6wF9b6F9ztn6gz9SPN/pOTr55y+PIto hTkgtPuETVL/Q== Received: from pmta14.mandrill.prod.suw01.rsglab.com (localhost [127.0.0.1]) by mail177-1.suw61.mandrillapp.com (Mailchimp) with ESMTP id 4ZDljK4L6QzBsTwYQ for ; Fri, 14 Mar 2025 13:35:01 +0000 (GMT) From: "Anthony PERARD" Subject: =?utf-8?Q?Re:=20[PATCH=20v4=2012/17]=20hw/xen:=20add=20stubs=20for=20various=20functions?= Received: from [37.26.189.201] by mandrillapp.com id a73312c2cedc4c94ab96628d4e4f7041; Fri, 14 Mar 2025 13:35:01 +0000 X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1741959300664 To: "Pierrick Bouvier" Cc: qemu-devel@nongnu.org, "Paul Durrant" , "=?utf-8?Q?Philippe=20Mathieu-Daud=C3=A9?=" , "Harsh Prateek Bora" , "Liu Zhiwei" , "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, "Peter Xu" , alex.bennee@linaro.org, manos.pitsidianakis@linaro.org, "Stefano Stabellini" , "Paolo Bonzini" , qemu-ppc@nongnu.org, "Richard Henderson" , kvm@vger.kernel.org, "David Hildenbrand" , "Palmer Dabbelt" , "Weiwei Li" , qemu-riscv@nongnu.org, "Alistair Francis" , "Yoshinori Sato" , "Daniel Henrique Barboza" , "Nicholas Piggin" Message-Id: References: <20250313163903.1738581-1-pierrick.bouvier@linaro.org> <20250313163903.1738581-13-pierrick.bouvier@linaro.org> In-Reply-To: <20250313163903.1738581-13-pierrick.bouvier@linaro.org> X-Native-Encoded: 1 X-Report-Abuse: =?UTF-8?Q?Please=20forward=20a=20copy=20of=20this=20message,=20including=20all=20headers,=20to=20abuse@mandrill.com.=20You=20can=20also=20report=20abuse=20here:=20https://mandrillapp.com/contact/abuse=3Fid=3D30504962.a73312c2cedc4c94ab96628d4e4f7041?= X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20250314:md Date: Fri, 14 Mar 2025 13:35:01 +0000 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On Thu, Mar 13, 2025 at 09:38:58AM -0700, Pierrick Bouvier wrote: > Those functions are used by system/physmem.c, and are called only if > xen is enabled (which happens only if CONFIG_XEN is not set). You mean, 's/is not set/is set/'? > > So we can crash in case those are called. > > Acked-by: Richard Henderson > Signed-off-by: Pierrick Bouvier > --- > diff --git a/hw/xen/xen_stubs.c b/hw/xen/xen_stubs.c > new file mode 100644 > index 00000000000..19cee84bbb4 > --- /dev/null > +++ b/hw/xen/xen_stubs.c > + > +void xen_invalidate_map_cache(void) > +{ Is this stub actually necessary? xen_invalidate_map_cache() doesn't seems to be used outside of xen's code. In anycase: Acked-by: Anthony PERARD Thanks, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B60F1C282EC for ; Fri, 14 Mar 2025 16:45:56 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tt8AH-00065f-2W; Fri, 14 Mar 2025 12:45:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tt5Sl-00033h-Px for qemu-riscv@nongnu.org; Fri, 14 Mar 2025 09:52:36 -0400 Received: from mail177-1.suw61.mandrillapp.com ([198.2.177.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tt5Si-0000ec-Qc for qemu-riscv@nongnu.org; Fri, 14 Mar 2025 09:52:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; s=mte1; t=1741959302; x=1742229302; bh=uG1KcJgwcW9T2cGN3oyD/12pz8pEMNAmvmnymfhPGS4=; h=From:Subject:To:Cc:Message-Id:References:In-Reply-To:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=g9hfdA/eM7vcBcCDkScEmdyush/aDVF9niLOhO1Tls29AehJMunYoTLPcqPx4URix /aMh2g12ndPjgUTy22QDmBO2Q/RAv0cXaFZI+qOcWz1ZgrHfQZCrr1K3y464VLIJyL qwG0X7PDYl8MR1m8vayWQ7hjrpV24L5fx3uL30NrDreDdDALoHwoF2h0fysd+K3iam uuGcNVID5TPwnEu+AzI8k4h0x2P7SOTZNSkGAuW/rTouVWcrQV+q0j9IK/9Uc1NvBZ Z7+4wG6V3IKm+zhLAqIfOwcWPE+QHkNe69r5WmAQgVIJNVrhCRzbohvB2D7UahSoln xxQo5w3wwGFsA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; s=mte1; t=1741959302; x=1742219802; i=anthony.perard@vates.tech; bh=uG1KcJgwcW9T2cGN3oyD/12pz8pEMNAmvmnymfhPGS4=; h=From:Subject:To:Cc:Message-Id:References:In-Reply-To:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=JLfWifvyw3oMpzh/DIkhmNZnn3FOeOLirZx5hCQxLEpJmiyfjBrlmwr/pGpcuVoIu fByVYbcweMsQZSr7P+jLoVx6FJX4LBZ/iPwhvohnmYlx2QihXR4olRcsJr2TAYMy5/ hudYvliyweXeQ59PZIeXS3fEzmoqQIVSV6WfgZ8kP/fcI+MggULGuM1sVWsTSFvWHP wXDJuAaRWZnF/BAQRml7SWQp9RISG2jZlaNr/J+RKpmHFJEJy5WNTAhhvlfN+4YBHH UwqWVJizjxihe4lGii0OSWJTOD6a2L1zM3QHS6AxlxRtem1HD3UbiF+zgVJ/AFupkT hzdtfbtU4eblQ== Received: from pmta14.mandrill.prod.suw01.rsglab.com (localhost [127.0.0.1]) by mail177-1.suw61.mandrillapp.com (Mailchimp) with ESMTP id 4ZDljL4NMWzBsTwYN for ; Fri, 14 Mar 2025 13:35:02 +0000 (GMT) From: "Anthony PERARD" Subject: =?utf-8?Q?Re:=20[PATCH=20v4=2012/17]=20hw/xen:=20add=20stubs=20for=20various=20functions?= Received: from [37.26.189.201] by mandrillapp.com id 957ea96c0f704cfba5fbb6ca474f632c; Fri, 14 Mar 2025 13:35:02 +0000 X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1741959300664 To: "Pierrick Bouvier" Cc: qemu-devel@nongnu.org, "Paul Durrant" , "=?utf-8?Q?Philippe=20Mathieu-Daud=C3=A9?=" , "Harsh Prateek Bora" , "Liu Zhiwei" , "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, "Peter Xu" , alex.bennee@linaro.org, manos.pitsidianakis@linaro.org, "Stefano Stabellini" , "Paolo Bonzini" , qemu-ppc@nongnu.org, "Richard Henderson" , kvm@vger.kernel.org, "David Hildenbrand" , "Palmer Dabbelt" , "Weiwei Li" , qemu-riscv@nongnu.org, "Alistair Francis" , "Yoshinori Sato" , "Daniel Henrique Barboza" , "Nicholas Piggin" Message-Id: References: <20250313163903.1738581-1-pierrick.bouvier@linaro.org> <20250313163903.1738581-13-pierrick.bouvier@linaro.org> In-Reply-To: <20250313163903.1738581-13-pierrick.bouvier@linaro.org> X-Native-Encoded: 1 X-Report-Abuse: =?UTF-8?Q?Please=20forward=20a=20copy=20of=20this=20message, =20including=20all=20headers, =20to=20abuse@mandrill.com.=20You=20can=20also=20report=20abuse=20here:=20https://mandrillapp.com/contact/abuse=3Fid=3D30504962.957ea96c0f704cfba5fbb6ca474f632c?= X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20250314:md Date: Fri, 14 Mar 2025 13:35:02 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=198.2.177.1; envelope-from=bounce-md_30504962.67d43086.v1-957ea96c0f704cfba5fbb6ca474f632c@bounce.vates.tech; helo=mail177-1.suw61.mandrillapp.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 14 Mar 2025 12:45:38 -0400 X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org On Thu, Mar 13, 2025 at 09:38:58AM -0700, Pierrick Bouvier wrote: > Those functions are used by system/physmem.c, and are called only if > xen is enabled (which happens only if CONFIG_XEN is not set). You mean, 's/is not set/is set/'? > > So we can crash in case those are called. > > Acked-by: Richard Henderson > Signed-off-by: Pierrick Bouvier > --- > diff --git a/hw/xen/xen_stubs.c b/hw/xen/xen_stubs.c > new file mode 100644 > index 00000000000..19cee84bbb4 > --- /dev/null > +++ b/hw/xen/xen_stubs.c > + > +void xen_invalidate_map_cache(void) > +{ Is this stub actually necessary? xen_invalidate_map_cache() doesn't seems to be used outside of xen's code. In anycase: Acked-by: Anthony PERARD Thanks, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech