From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.zeus03.de (zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14A54A41 for ; Sat, 15 Mar 2025 09:00:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742029253; cv=none; b=BEQ+rGf2UhWHK9h34Amakyu8ZqaS0rRrlDz5HjMRY5YqU5P5XF2PxEUsC7hN9khn+e/rvCnVDtQR7HuydQ2+TrK5WI+P7rmv6dTiSb1gv6uLJmTWYm6RJovPjciFmk3f0cI8uS6BMSeaL0LDXv/oOeJ140FEi4DUMjRTikBrnx0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742029253; c=relaxed/simple; bh=mlpE0AG1lyL0zxlfyH82SbA0+rBvYIjktuoXn2my7U4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uD+3dI2byG4pn6mqbdQk1+LoTUsLp1tmZCYwxSg5n7iFIbnPPmsTIq4Gu8WDQ7gklcbSPHpEv/2hUjgdstg9ojLP0nV4hL7gb2pPzuaE5Tw4KuwgkYATN8emgYA96kX5Hbg6lCSHwYUaeL2iHRAIx6cep7D/i93x6aIvQYN05kE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=SSP9D8vc; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="SSP9D8vc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=k1; bh=MGev xMFs+AEeVD/g7S+xfiPUbsNw/tIHCnRkwS+P0V4=; b=SSP9D8vc5MsumtPvxp/d CVUk8n5Wde3V8zMT88IWNmIwVlaH7DQCxkDXU4uNeoTi/PNa5hjH4lUIAWxgZM33 Q4w7+EPRwO+CSxj80Znxm0sk5tYB/rWOWFxfmarqpxm0iG+7oIvRRcjA1QTMYFX5 YrGz5y9PXi8rg9PYKQ7b05qTm8tbBTVqIEh9YdGAwoBIfFM/Cryj3Ez6hbtfCtsM qju6xL3NONpDDmPaj79L1QoapOGiN7sUDs5Jli9ec+Pb2u1mllu8kSfTVGz3y6hP ehiV7pGqhWwNTBSWO44c7oiXaiPUY0dTS9s7r+SdCREB2nlcTnxlf5hcC+KHijqz WQ== Received: (qmail 2329603 invoked from network); 15 Mar 2025 10:00:37 +0100 Received: by mail.zeus03.de with UTF8SMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 15 Mar 2025 10:00:37 +0100 X-UD-Smtp-Session: l3s3148p1@NA/iyV0wwKkujnuL Date: Sat, 15 Mar 2025 10:00:37 +0100 From: Wolfram Sang To: Doug Anderson Cc: linux-renesas-soc@vger.kernel.org, Phong Hoang , Jacopo Mondi , Laurent Pinchart , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2] drm/bridge: ti-sn65dsi86: Check bridge connection failure Message-ID: Mail-Followup-To: Wolfram Sang , Doug Anderson , linux-renesas-soc@vger.kernel.org, Phong Hoang , Jacopo Mondi , Laurent Pinchart , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org References: <20250314224202.13128-2-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+4ueQPdkORSXQcLW" Content-Disposition: inline In-Reply-To: --+4ueQPdkORSXQcLW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Doug, > Seems reasonable to me. I would probably put an error message in this > case, though? I don't think regmap_read() necessarily prints an error > so it would just be a mysterious failure for why things didn't probe, > right? OK, can do that. > This also only solves the problems for one of the 4 devices in this > file. I think the GPIO device, PWM device, and DP-AUX device will > still confusingly stick around. It's probably better to add a bogus > regmap read in ti_sn65dsi86_probe(). Could be argued. I just wonder about all the other error cases in ti_sn_attach_host() plus ti_sn_bridge_probe(). They have the same problem with the other devices dangling? Happy hacking, Wolfram --+4ueQPdkORSXQcLW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmfVQbEACgkQFA3kzBSg KbZiqg/8D10WbcbFyncxpYgi27s6gdp/L1rYAeXUQUXCWh54FbAiYMgfpTUCkdyJ 0c/f6cWzX5d1f3hLQtZUTQ1U0cWqwzWkwi299jZbl08hUvm71nP4OCXAD6CMtjX8 FsfApv5NuFJ22TOq7H+vXuvY9HyZNPaMneq97mVXD/WxkKg2qgHjIebM4xuziI2g RPsOVd9RAQtbvZgHwl9HAXYm6Np1x3mizZs3OXf+ZpoqLBDFholgCMiUIUQ0S89s MBIgrTDWftEHuwaGmevvYpV/hyGLiN6bMi6xPIu4mtjkRFuMeTePmWkWfZ+wh3M+ I0sfy4x3l823KDqq0sNtdjJ6Q8fXsjVzh1hvzJWSfpX76jJ+cpnsirF4FyEimRNu NLG0UdP0QZhLZ1bfRwX6VyblUTyKes9QOSWLu36bzAWs7mTtYmV7G93p1t2XFAF9 4SSxtmzn7jMFyfJXlktZb/FC307FW7mp8IS78+PXZKbYNHDY8wEx5v4nwhGE3RU2 gtV9bimE17QE3F6gN2/1+vc2aFSipkq+DptfTnEx9kGLhZJ/37SJyZPZszMnIBKh CgrmSBfyAtKXSc4PSV2JF2k833wxd//VPGYfaFau+T3pPhiWSjQjjx+MI0TP7Q8l Sn/eoIWi/gGib1xY7pMMHHCQp7cMAzQ8iXNZgUVrCQEtupCiPNE= =bZOD -----END PGP SIGNATURE----- --+4ueQPdkORSXQcLW--