Re: [PATCH 1/2] tcp: fix races in tcp_abort()

[Youngmin Nam <youngmin.nam@samsung.com>]

[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]

On Fri, Mar 14, 2025 at 01:24:09PM +0100, Greg KH wrote:
> On Fri, Mar 14, 2025 at 06:24:45PM +0900, Youngmin Nam wrote:
> > From: Eric Dumazet <edumazet@google.com>
> > 
> > tcp_abort() has the same issue than the one fixed in the prior patch
> > in tcp_write_err().
> > 
> > commit 5ce4645c23cf5f048eb8e9ce49e514bababdee85 upstream.
> > 
> > To apply commit bac76cf89816bff06c4ec2f3df97dc34e150a1c4,
> > this patch must be applied first.
> > 
> > In order to get consistent results from tcp_poll(), we must call
> > sk_error_report() after tcp_done().
> > 
> > We can use tcp_done_with_error() to centralize this logic.
> > 
> > Fixes: c1e64e298b8c ("net: diag: Support destroying TCP sockets.")
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
> > Acked-by: Neal Cardwell <ncardwell@google.com>
> > Link: https://lore.kernel.org/r/20240528125253.1966136-4-edumazet@google.com
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> > Cc: <stable@vger.kernel.org> # v5.10+
> 
> Did not apply to 5.10.y, what did you want this added to?
> 
> thanks,
> 
> greg k-h
> 

Hi Greg,

Sorry about that.

As for 5.10, it seems to have more dependencies for the backport.
I think the maintainer should handle it to ensure a safe backport.

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]