From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Michael Klein <michael@fossekall.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next,v3,1/2] net: phy: realtek: Clean up RTL8211E ExtPage access
Date: Mon, 17 Mar 2025 11:13:04 +0000 [thread overview]
Message-ID: <Z9gDwDgpeU2iSZT-@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250316121424.82511-2-michael@fossekall.de>
On Sun, Mar 16, 2025 at 01:14:22PM +0100, Michael Klein wrote:
> +static int rtl8211e_modify_ext_page(struct phy_device *phydev, u16 ext_page,
> + u32 regnum, u16 mask, u16 set)
> +{
> + int oldpage, ret = 0;
> +
> + oldpage = phy_select_page(phydev, RTL8211E_SET_EXT_PAGE);
> + if (oldpage >= 0) {
> + ret = __phy_write(phydev, RTL8211E_EXT_PAGE_SELECT, ext_page);
> + if (!ret)
Only a nit, but !ret "reads" weirdly when you consider what the code is
doing, "ret == 0" seems more natural. It's only a nit so feel free to
ignore.
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-03-17 11:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-16 12:14 [net-next,v3,0/2] net: phy: realtek: Add support for PHY LEDs on Michael Klein
2025-03-16 12:14 ` [net-next,v3,1/2] net: phy: realtek: Clean up RTL8211E ExtPage access Michael Klein
2025-03-17 11:13 ` Russell King (Oracle) [this message]
2025-03-16 12:14 ` [net-next,v3,2/2] net: phy: realtek: Add support for PHY LEDs on RTL8211E Michael Klein
2025-03-17 11:15 ` Russell King (Oracle)
2025-03-17 17:23 ` Michael Klein
2025-03-17 17:26 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9gDwDgpeU2iSZT-@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@fossekall.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.