Re: [PATCH RFC] multipath-tools: add Generic SCSI in hwtable

[Benjamin Marzinski <bmarzins@redhat.com>]

On Mon, Mar 17, 2025 at 06:33:51PM +0100, Xose Vazquez Perez wrote:
> Cc: Martin Wilck <mwilck@suse.com>
> Cc: Benjamin Marzinski <bmarzins@redhat.com>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: DM-DEVEL ML <dm-devel@lists.linux.dev>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
>  libmultipath/hwtable.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index f8cf3fa9..34b1fd2f 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -79,6 +79,17 @@
>  #endif
>  

If we wanted to make these changes, we could just change
DEFAULT_PGPOLICY, DEFAULT_FAILBACK, and DEFAULT_NO_PATH_RETRY. But I
still think that for completely unknown devices, we should stick with
our current defaults. They're safe and I haven't heard any complaints
about them.

-Ben

>  static struct hwentry default_hw[] = {
> +	/*
> +	 * Generic SCSI devices
> +	 */
> +	{
> +		/* Generic SCSI */
> +		.vendor        = ".*",
> +		.product       = ".*",
> +		.pgpolicy      = GROUP_BY_PRIO,
> +		.pgfailback    = -FAILBACK_IMMEDIATE,
> +		.no_path_retry = 30,
> +	},
>  	/*
>  	 * Generic NVMe devices
>  	 *
> -- 
> 2.48.1