From: Roman Gushchin <roman.gushchin@linux.dev>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Shakeel Butt <shakeel.butt@linux.dev>,
Muchun Song <muchun.song@linux.dev>, Zi Yan <ziy@nvidia.com>,
David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v2 1/5] mm: Separate folio_split_memcg_refs() from split_page_memcg()
Date: Tue, 18 Mar 2025 03:14:27 +0000 [thread overview]
Message-ID: <Z9jlE1G4MYa6SJrF@google.com> (raw)
In-Reply-To: <20250314133617.138071-2-willy@infradead.org>
On Fri, Mar 14, 2025 at 01:36:11PM +0000, Matthew Wilcox wrote:
> Folios always use memcg_data to refer to the mem_cgroup while pages
> allocated with GFP_ACCOUNT have a pointer to the obj_cgroup. Since the
> caller already knows what it has, split the function into two and then
> we don't need to check.
>
> Move the assignment of split folio memcg_data to the point where we set
> up the other parts of the new folio. That leaves folio_split_memcg_refs()
> just handling the memcg accounting.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
> Acked-by: Zi Yan <ziy@nvidia.com>
Acked-by: Roman Gushchin <roman.gushchin@linux.dev>
next prev parent reply other threads:[~2025-03-18 3:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 13:36 [PATCH v2 0/5] Minor memcg cleanups & prep for memdescs Matthew Wilcox (Oracle)
2025-03-14 13:36 ` [PATCH v2 1/5] mm: Separate folio_split_memcg_refs() from split_page_memcg() Matthew Wilcox (Oracle)
2025-03-14 21:49 ` David Hildenbrand
2025-03-14 23:15 ` Zi Yan
2025-03-15 23:02 ` David Hildenbrand
2025-03-18 3:14 ` Roman Gushchin [this message]
2025-03-14 13:36 ` [PATCH v2 2/5] mm: Simplify split_page_memcg() Matthew Wilcox (Oracle)
2025-03-18 3:17 ` Roman Gushchin
2025-03-14 13:36 ` [PATCH v2 3/5] mm: Remove references to folio in split_page_memcg() Matthew Wilcox (Oracle)
2025-03-14 21:53 ` David Hildenbrand
2025-03-18 3:19 ` Roman Gushchin
2025-03-14 13:36 ` [PATCH v2 4/5] mm: Simplify folio_memcg_charged() Matthew Wilcox (Oracle)
2025-03-18 3:22 ` Roman Gushchin
2025-03-14 13:36 ` [PATCH v2 5/5] mm: Remove references to folio in __memcg_kmem_uncharge_page() Matthew Wilcox (Oracle)
2025-03-18 3:24 ` Roman Gushchin
2025-03-14 21:53 ` [PATCH v2 0/5] Minor memcg cleanups & prep for memdescs David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9jlE1G4MYa6SJrF@google.com \
--to=roman.gushchin@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.