From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] src: replace struct stmt_ops by type field in struct stmt
Date: Tue, 18 Mar 2025 14:29:51 +0100 [thread overview]
Message-ID: <Z9l1T85xloDQEidF@strlen.de> (raw)
In-Reply-To: <20250317224333.2037199-1-pablo@netfilter.org>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> Shrink struct stmt in 8 bytes.
>
> __stmt_ops_by_type() provides an operation for STMT_INVALID since this
> is required by -o/--optimize.
We could have lots of statements in a ruleset, so I think this makes
sense to compact things.
>
> Similar to:
>
> 68e76238749f ("src: expr: add and use expr_name helper").
> 72931553828a ("src: expr: add expression etype")
> 2cc91e6198e7 ("src: expr: add and use internal expr_ops helper")
... and it makes statements more like expressions wrt. ops, so this is
good too.
Acked-by: Florian Westphal <fw@strlen.de>
prev parent reply other threads:[~2025-03-18 13:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 22:43 [PATCH nft] src: replace struct stmt_ops by type field in struct stmt Pablo Neira Ayuso
2025-03-18 13:29 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9l1T85xloDQEidF@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.