All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, Doug Goldstein <cardoe@cardoe.com>
Subject: Re: [PATCH 7/8] automation/console.exp: do not assume expect is always at /usr/bin/
Date: Tue, 18 Mar 2025 10:45:46 +0100	[thread overview]
Message-ID: <Z9lAylFTyLA5SIzU@macbook.local> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2503171647450.3477110@ubuntu-linux-20-04-desktop>

On Mon, Mar 17, 2025 at 04:48:05PM -0700, Stefano Stabellini wrote:
> On Mon, 17 Mar 2025, Roger Pau Monne wrote:
> > Instead use env to find the location of expect.
> > 
> > Additionally do not use the -f flag, as it's only meaningful when passing
> > arguments on the command line, which we never do for console.exp.  From the
> > expect 5.45.4 man page:
> > 
> > > The -f flag prefaces a file from which to read commands from.  The flag
> > > itself is optional as it is only useful when using the #! notation (see
> > > above), so  that other arguments may be supplied on the command line.
> > 
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Do you have a link to a successful Gitlab and Cirrus CI?

Yes.  They are here:

https://cirrus-ci.com/build/4981406134173696
https://gitlab.com/xen-project/people/royger/xen/-/pipelines/1719913362

> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Thanks, Roger.


  reply	other threads:[~2025-03-18  9:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-17 12:16 [PATCH 0/8] automation/cirrus-ci: add smoke tests of the FreeBSD builds Roger Pau Monne
2025-03-17 12:16 ` [PATCH 1/8] automation/cirrus-ci: add timestamps Roger Pau Monne
2025-03-17 23:48   ` Stefano Stabellini
2025-03-17 12:16 ` [PATCH 2/8] automation/cirrus-ci: update FreeBSD to 13.5 Roger Pau Monne
2025-03-17 23:48   ` Stefano Stabellini
2025-03-17 12:16 ` [PATCH 3/8] automation/cirrus-ci: store Xen Kconfig before doing a build Roger Pau Monne
2025-03-17 23:50   ` Stefano Stabellini
2025-03-17 12:16 ` [PATCH 4/8] automation/cirrus-ci: use matrix keyword to generate per-version build tasks Roger Pau Monne
2025-03-18  0:06   ` Stefano Stabellini
2025-03-17 12:16 ` [PATCH 5/8] automation/cirrus-ci: build XTF Roger Pau Monne
2025-03-18  0:07   ` Stefano Stabellini
2025-03-18  9:43     ` Roger Pau Monné
2025-03-17 12:16 ` [PATCH 6/8] automation/cirrus-ci: store XTF and Xen build artifacts Roger Pau Monne
2025-03-18  0:07   ` Stefano Stabellini
2025-03-17 12:16 ` [PATCH 7/8] automation/console.exp: do not assume expect is always at /usr/bin/ Roger Pau Monne
2025-03-17 23:48   ` Stefano Stabellini
2025-03-18  9:45     ` Roger Pau Monné [this message]
2025-03-17 12:16 ` [PATCH 8/8] automation/cirrus-ci: add smoke tests for the FreeBSD builds Roger Pau Monne
2025-03-17 16:45   ` Oleksii Kurochko
2025-03-18  0:09   ` Stefano Stabellini
2025-03-18  9:47     ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z9lAylFTyLA5SIzU@macbook.local \
    --to=roger.pau@citrix.com \
    --cc=cardoe@cardoe.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.