Re: [PATCH v2 10/14] rust/vmstate: Support vmstate_validate

[Zhao Liu <zhao1.liu@intel.com>]

On Tue, Mar 18, 2025 at 01:32:03PM +0100, Paolo Bonzini wrote:
> Date: Tue, 18 Mar 2025 13:32:03 +0100
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: Re: [PATCH v2 10/14] rust/vmstate: Support vmstate_validate
> 
> Il mar 18 mar 2025, 13:03 Zhao Liu <zhao1.liu@intel.com> ha scritto:
> 
> > >  /// This macro can be used (by just passing it a type) to forward the
> > `VMState`
> > > @@ -572,9 +548,9 @@ const fn phantom__<T>(_: &T) ->
> > ::core::marker::PhantomData<T> {
> > >                  }
> > >                  Some(test_cb_builder__::<$struct_name,
> > _>(phantom__(&$test_fn)))
> > >              },
> >
> > I want to keep the comment here as C version did, because there's an array
> > flag
> >
> 
> Ok, let's add it. No need to send v3 since it's just a single patch and
> with no changes further down.
> 

Thanks and sorry, I missed your notification because I didn't actively
pull my mutt just now... but, v3 might also be worthwhile.

While setting flags for vmstate_validate, I also took the opportunity to
do a little cleanup on vmstate_clock. I hope it didn't cause any extra
burden. :-)

Regards,
Zhao