All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel@lists.xenproject.org, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH 1/7] x86/boot: clarify comment about trampoline_setup usage
Date: Wed, 19 Mar 2025 09:46:01 +0100	[thread overview]
Message-ID: <Z9qESYLU3wMjwS-c@macbook.local> (raw)
In-Reply-To: <720af946-5c2a-43b4-a9fb-163e41bfdeb7@citrix.com>

On Tue, Mar 18, 2025 at 05:45:09PM +0000, Andrew Cooper wrote:
> On 18/03/2025 5:35 pm, Roger Pau Monne wrote:
> > Clarify that trampoline_setup is only used for EFI when booted using the
> > multiboot2 entry point.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > ---
> >  xen/arch/x86/boot/head.S | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S
> > index 1b3bd16fe575..59a2b5005cf6 100644
> > --- a/xen/arch/x86/boot/head.S
> > +++ b/xen/arch/x86/boot/head.S
> > @@ -505,7 +505,8 @@ trampoline_bios_setup:
> >  
> >  trampoline_setup:
> >          /*
> > -         * Called on legacy BIOS and EFI platforms.
> > +         * Called on legacy BIOS and EFI platforms when using multiboot (either
> > +         * 1 or 2).
> >           */
> 
> /* Called for Mutiboot entry, including MB2+EFI. */
> 
> is a little more concise?

That's fine.  Would you like me to resend the adjusted version?

Thanks, Roger.


  reply	other threads:[~2025-03-19  8:46 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-18 17:35 [PATCH 0/7] x86: generate xen.efi image with no write-execute sections Roger Pau Monne
2025-03-18 17:35 ` [PATCH 1/7] x86/boot: clarify comment about trampoline_setup usage Roger Pau Monne
2025-03-18 17:45   ` Andrew Cooper
2025-03-19  8:46     ` Roger Pau Monné [this message]
2025-03-19 12:22       ` Andrew Cooper
2025-03-18 17:35 ` [PATCH 2/7] x86/mkelf32: account for offset when detecting note segment placement Roger Pau Monne
2025-03-18 17:45   ` Andrew Cooper
2025-03-19 10:07   ` Jan Beulich
2025-03-19 14:16     ` Roger Pau Monné
2025-03-19 14:33       ` Jan Beulich
2025-03-18 17:35 ` [PATCH 3/7] xen: remove -N from the linker command line Roger Pau Monne
2025-03-18 17:53   ` Andrew Cooper
2025-03-19 10:20   ` Jan Beulich
2025-03-21 16:28   ` Oleksii Kurochko
2025-03-18 17:35 ` [PATCH 4/7] x86/boot: apply trampoline relocations at destination position Roger Pau Monne
2025-03-18 19:05   ` Frediano Ziglio
2025-03-18 19:17     ` Andrew Cooper
2025-03-19 12:00     ` Frediano Ziglio
2025-03-18 20:10   ` [PATCH] x86/boot: Untangle the trampoline copying/entry logic Andrew Cooper
2025-03-19  9:05     ` Roger Pau Monné
2025-03-20 13:59       ` Andrew Cooper
2025-03-18 20:14   ` [PATCH 4/7] x86/boot: apply trampoline relocations at destination position Andrew Cooper
2025-03-18 17:35 ` [PATCH 5/7] x86/mkreloc: remove warning about relocations to RO section Roger Pau Monne
2025-03-18 18:14   ` Andrew Cooper
2025-03-19 10:32   ` Jan Beulich
2025-03-19 10:46     ` Jan Beulich
2025-03-19 10:53       ` Jan Beulich
2025-03-20  8:14       ` Roger Pau Monné
2025-03-20  8:34         ` Jan Beulich
2025-03-20  9:53           ` Jan Beulich
2025-03-20 10:18             ` Jan Beulich
2025-03-20 11:00               ` Andrew Cooper
2025-03-20 11:11                 ` Jan Beulich
2025-03-18 17:35 ` [PATCH 6/7] x86/efi: do not merge all .init sections Roger Pau Monne
2025-03-18 18:08   ` Andrew Cooper
2025-03-19 10:39   ` Jan Beulich
2025-03-18 17:35 ` [PATCH 7/7] xen/build: warn about RWX load segments Roger Pau Monne
2025-03-18 18:07   ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z9qESYLU3wMjwS-c@macbook.local \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.