All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephan Gerhold <stephan.gerhold@linaro.org>
To: bjorn.andersson@oss.qualcomm.com
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Aleksandrs Vinarskis <alex.vinarskis@gmail.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: x1e80100-dell-xps13-9345: Disable PM8010
Date: Wed, 19 Mar 2025 11:06:12 +0100	[thread overview]
Message-ID: <Z9qXFLmnae86_GT9@linaro.org> (raw)
In-Reply-To: <20250318-xps13-no-pm8010-v1-1-c46236d96428@oss.qualcomm.com>

On Tue, Mar 18, 2025 at 10:17:02PM -0500, Bjorn Andersson via B4 Relay wrote:
> From: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
> 
> The Qualcomm X Elite reference design uses the PM8010 PMIC for camera
> use cases, but the Dell XPS13 doesn't. Disable this PMIC to avoid the
> error in the kernel log caused by an attempt to access it during boot.
> 
> Fixes: f5b788d0e8cd ("arm64: dts: qcom: Add support for X1-based Dell XPS 13 9345")
> Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>

Usually we do the opposite: disable nodes by default that may or may not
be there and enable them where needed. E.g. for the 4 SMB2360 instances
in x1e80100-pmics.dtsi.

I think the same approach would also be preferable here. You shouldn't
get an error in the log just because you didn't go through all of your
DT includes and checked if you really have all of the components listed
there. I think it's okay to enable PMICs that are more or less
guaranteed to be there, but clearly this is not the case for PM8010.

Thanks,
Stephan

  reply	other threads:[~2025-03-19 10:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-19  3:17 [PATCH] arm64: dts: qcom: x1e80100-dell-xps13-9345: Disable PM8010 Bjorn Andersson
2025-03-19  3:17 ` Bjorn Andersson via B4 Relay
2025-03-19 10:06 ` Stephan Gerhold [this message]
2025-03-19 11:55   ` Johan Hovold
2025-03-19 14:00   ` Bjorn Andersson
2025-06-15 18:29     ` Aleksandrs Vinarskis
2025-06-16  8:09       ` Bryan O'Donoghue
2025-06-23 11:37         ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z9qXFLmnae86_GT9@linaro.org \
    --to=stephan.gerhold@linaro.org \
    --cc=alex.vinarskis@gmail.com \
    --cc=andersson@kernel.org \
    --cc=bjorn.andersson@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.