All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	GIT Mailing-list <git@vger.kernel.org>,
	Adam Dinwoodie <git@dinwoodie.org>
Subject: Re: [PATCH 01/12] meson.build: remove -DCURL_DISABLE_TYPECHECK
Date: Wed, 19 Mar 2025 14:36:48 +0100	[thread overview]
Message-ID: <Z9rIcPprrsKtJkmV@pks.im> (raw)
In-Reply-To: <d230e5a7-1b3d-4cf9-b30e-69471d1fbe9a@ramsayjones.plus.com>

On Sat, Mar 15, 2025 at 02:46:23AM +0000, Ramsay Jones wrote:
> 
> Commit 9371322a60 ("sparse: suppress some \"using sizeof on a function\"
> warnings", 2013-10-06) used target-specific variable assignments to add
> -DCURL_DISABLE_TYPECHECK to SPARSE_FLAGS for each of the files affected
> by the "typecheck-gcc.h" warnings. (http-push.c, http.c, http-walker.c
> and remote-curl.c).
> 
> These warnings are only issued by sparse, and not by gcc, so we do not
> want to disable the 'type checking' for non-sparse targets. The meson
> build does not provide any sparse targets, so there is no need to use
> the CURL_DISABLE_TYPECHECK preprocessor flag with the c compiler.
> 
> In order to re-enable the curl 'type checking' in the meson build, remove
> the assignment of -DCURL_DISABLE_TYPECHECK to libgit_c_args.
> 
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>

Makes sense indeed.

Patrick

      reply	other threads:[~2025-03-19 13:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-15  2:46 [PATCH 01/12] meson.build: remove -DCURL_DISABLE_TYPECHECK Ramsay Jones
2025-03-19 13:36 ` Patrick Steinhardt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z9rIcPprrsKtJkmV@pks.im \
    --to=ps@pks.im \
    --cc=git@dinwoodie.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.