All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Howard Chu <howardchu95@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Ian Rogers <irogers@google.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org, bpf@vger.kernel.org,
	Song Liu <song@kernel.org>
Subject: Re: [PATCH v2] perf trace: Implement syscall summary in BPF
Date: Wed, 19 Mar 2025 15:07:01 -0700	[thread overview]
Message-ID: <Z9tABRzmYYYUyEFO@google.com> (raw)
In-Reply-To: <CAH0uvogx1-oz4ZjLpcTRArTb2YJOyY1h1pccMXYSgCnHYD9bPA@mail.gmail.com>

Hello Howard,

On Wed, Mar 19, 2025 at 12:00:10PM -0700, Howard Chu wrote:
> Hello Namhyung,
> 
> Can you please rebase it? I cannot apply it, getting:
> 
> perf $ git apply --reject --whitespace=fix
> ./v2_20250317_namhyung_perf_trace_implement_syscall_summary_in_bpf.mbx
> Checking patch tools/perf/Documentation/perf-trace.txt...
> Checking patch tools/perf/Makefile.perf...
> Hunk #1 succeeded at 1198 (offset -8 lines).
> Checking patch tools/perf/builtin-trace.c...
> error: while searching for:
>         bool       hexret;
> };
> 
> enum summary_mode {
>         SUMMARY__NONE = 0,
>         SUMMARY__BY_TOTAL,
>         SUMMARY__BY_THREAD,
> };
> 
> struct trace {
>         struct perf_tool        tool;
>         struct {
> 
> error: patch failed: tools/perf/builtin-trace.c:140

Oops, I think I forgot to say it's on top of Ian's change.
Please try this first.  Sorry for the confusion.

https://lore.kernel.org/r/20250319050741.269828-1-irogers@google.com

Thanks,
Namhyung


  reply	other threads:[~2025-03-19 22:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-17 18:08 [PATCH v2] perf trace: Implement syscall summary in BPF Namhyung Kim
2025-03-17 18:37 ` Ian Rogers
2025-03-20  6:07   ` Namhyung Kim
2025-03-19 19:00 ` Howard Chu
2025-03-19 22:07   ` Namhyung Kim [this message]
2025-03-19 22:19     ` Howard Chu
2025-03-19 23:39       ` Howard Chu
2025-03-20  0:17         ` Namhyung Kim
2025-03-21  2:35 ` Howard Chu
2025-03-21  5:54   ` Namhyung Kim
2025-03-21 17:19     ` Howard Chu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z9tABRzmYYYUyEFO@google.com \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=bpf@vger.kernel.org \
    --cc=howardchu95@gmail.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.