From: Patrick Steinhardt <ps@pks.im>
To: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [GSoC PATCH 2/2] t4018: add tests for gitconfig in userdiff
Date: Thu, 20 Mar 2025 09:38:27 +0100 [thread overview]
Message-ID: <Z9vUAzt-5FNgSEKd@pks.im> (raw)
In-Reply-To: <20250319172016.2115-3-lucasseikioshiro@gmail.com>
On Wed, Mar 19, 2025 at 02:20:16PM -0300, Lucas Seiki Oshiro wrote:
> Add userdiff tests for gitconfig files. These files define sections and
> subsections, with and without indentation.
I think it would make sense to suqash this commit into the first one.
> diff --git a/t/t4018/gitconfig-section b/t/t4018/gitconfig-section
> new file mode 100644
> index 0000000000..866aa70b24
> --- /dev/null
> +++ b/t/t4018/gitconfig-section
> @@ -0,0 +1,5 @@
> +[RIGHT]
> + # comment
> + ; comment
> + name = value
> + ChangeMe
> \ No newline at end of file
You're missing newlines at the end of al test files. I don't think this
is intentional, is it?
Patrick
next prev parent reply other threads:[~2025-03-20 8:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 17:20 [GSoC PATCH 0/2] add userdiff driver for gitconfig Lucas Seiki Oshiro
2025-03-19 17:20 ` [GSoC PATCH 1/2] userdiff: add builtin driver for gitconfig syntax Lucas Seiki Oshiro
2025-03-20 8:38 ` Patrick Steinhardt
2025-03-21 2:11 ` D. Ben Knoble
2025-03-19 17:20 ` [GSoC PATCH 2/2] t4018: add tests for gitconfig in userdiff Lucas Seiki Oshiro
2025-03-20 8:38 ` Patrick Steinhardt [this message]
2025-03-23 16:08 ` Lucas Seiki Oshiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9vUAzt-5FNgSEKd@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=lucasseikioshiro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.