From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2400C28B30 for ; Thu, 20 Mar 2025 09:08:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F71810E039; Thu, 20 Mar 2025 09:08:52 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="fc9AIbDz"; dkim-atps=neutral X-Greylist: delayed 435 seconds by postgrey-1.36 at gabe; Thu, 20 Mar 2025 09:08:51 UTC Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id C39EB10E039 for ; Thu, 20 Mar 2025 09:08:51 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id B1ABF43BC1; Thu, 20 Mar 2025 09:01:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A702C4CEE8; Thu, 20 Mar 2025 09:01:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742461286; bh=5l9jwMAcnsf1oLxy6ZmyjDg3hozK14Egdv9q6rSt7pk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fc9AIbDzyhmJe5F843Vik1qG222uAdC5zlcrjHv/RASdem/9w5AuR2Fc2CYxVPLkk xILD6Dr72N6r9c0ay6SqY7zzwaWqvP1gX+R4a0yajJk/7lWDqW77WIBRYxRuZR9C05 e+wn/tnrOe+kNjDh+fWenmHiOevyGSTOIol0T3pHB+ISaX0KLUZqzINEjhpERz8zkn aDPAKRkIVY0IQtvrFBosMxoT1Jcst+tA+rKebqj95HEi8AnAzknkBNC6SF/QF0zWC/ sg4TiPEnMEzgRkT9KuE3XwlESIl8CzwuvQGxU+t2pk0MrdZj23sASvPjXGyKtI1W6i 57ZXEI3d7fm6g== Date: Thu, 20 Mar 2025 10:01:20 +0100 From: Ingo Molnar To: Balbir Singh Cc: Bert Karwatzki , Alex Deucher , Kees Cook , Bjorn Helgaas , Linus Torvalds , Peter Zijlstra , Andy Lutomirski , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org Subject: Re: commit 7ffb791423c7 breaks steam game Message-ID: References: <146277bb0ecbb392d490683c424b8ae0dfa82838.camel@web.de> <7866593f-0322-4fb3-9729-82366940fc85@nvidia.com> <5d34bfc5109b8d104fd4f8550dd17945344f9d07.camel@web.de> <551b9797-20d6-4bfe-b54c-84dd7aae7794@nvidia.com> <9be36dfab79b17e108f71d51a6ebf39073e110c6.camel@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" * Balbir Singh wrote: > On 3/17/25 00:09, Bert Karwatzki wrote: > > This is related to the admgpu.gttsize. My laptop has the maximum amount  > > of memory (64G) and usually gttsize is half of main memory size. I just  > > tested with cmdline="nokaslr amdgpi.gttsize=2048" and the problem does  > > not occur. So I did some more testing with varying gttsize and got this > > for the built-in GPU > > > > 08:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] > > Cezanne [Radeon Vega Series / Radeon Vega Mobile Series] (rev c5) > > > > (nokaslr is always enabeld) > > gttssize input behaviour > > 2048 GOOD > > 2064 GOOD > > 2080 SEMIBAD (i.e. noticeable input lag but not as bad as below) > > 3072 BAD > > 4096 BAD > > 8192 BAD > > 16384 BAD > > > > As the build-in GPU has ~512 VRAM there seems to be problems when gttsize > > > 4*VRAM so I tested for the discrete GPU with 8G of VRAM > > gttsize input behaviour > > 49152 GOOD > > 64000 GOOD > > > > So for the discrete GPU increasing gttsize does no reproduce the bug. > > > > Very interesting, I am not a GTT expert, but with these experiments do you > find anything interesting in > > /sys/kernel/debug/x86/pat_memtype_list? > > It's weird that you don't see any issues in Xorg (Xfce), just the games. > May be we should get help from the amd-gfx experts to further diagnose/debug > the interaction of nokaslr with the game. So basically your commit: 7ffb791423c7 ("x86/kaslr: Reduce KASLR entropy on most x86 systems") inflicts part of the effects of a 'nokaslr' boot command line option, and triggers the regression due to that? Or is there some other cause? Thanks, Ingo