From: Jarkko Sakkinen <jarkko@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Stefano Garzarella <sgarzare@redhat.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-integrity@vger.kernel.org,
Dov Murik <dovmurik@linux.ibm.com>,
Dionna Glaze <dionnaglaze@google.com>,
linux-coco@lists.linux.dev,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Claudio Carvalho <cclaudio@linux.ibm.com>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH v3 1/4] x86/sev: add SVSM vTPM probe/send_command functions
Date: Thu, 20 Mar 2025 19:30:43 +0200 [thread overview]
Message-ID: <Z9xQw8QpRKk26G6R@kernel.org> (raw)
In-Reply-To: <20250320171619.GOZ9xNY4W54avW2a-u@fat_crate.local>
On Thu, Mar 20, 2025 at 06:16:19PM +0100, Borislav Petkov wrote:
> On Thu, Mar 20, 2025 at 05:03:09PM +0200, Jarkko Sakkinen wrote:
> > > I can do that, I slightly prefer BIT_ULL() macro, but I don't have a strong
> > > opinion on my side.
> > > @Borislav since you suggested it, WDYT?
> >
> > Either goes for me. Sorry for nitpicking that :-) The first comment
> > stil applies.
>
> Bit 8 is a lot better than 0x100.
>
> Let's give a better example:
>
> 0x0000000008000000
>
> or
>
> BIT_ULL(27)
>
> :-)
Sure, I'm fine with using BIT_ULL() :-)
>
> While I'm here: I'm guessing I'll route patches 1 and 4 through tip once
> they're ready to go and give Jarkko an immutable branch he can base the other
> two ontop.
>
> Agreed?
Works for me.
>
> Thx.
>
> --
> Regards/Gruss,
> Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette
BR, Jarkko
next prev parent reply other threads:[~2025-03-20 17:30 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 9:42 [PATCH v3 0/4] Enlightened vTPM support for SVSM on SEV-SNP Stefano Garzarella
2025-03-11 9:42 ` [PATCH v3 1/4] x86/sev: add SVSM vTPM probe/send_command functions Stefano Garzarella
2025-03-11 9:56 ` Jarkko Sakkinen
2025-03-12 10:56 ` Stefano Garzarella
2025-03-14 15:04 ` Jarkko Sakkinen
2025-03-14 15:27 ` Tom Lendacky
2025-03-17 13:36 ` Jarkko Sakkinen
2025-03-18 10:07 ` Stefano Garzarella
2025-03-20 15:03 ` Jarkko Sakkinen
2025-03-20 17:16 ` Borislav Petkov
2025-03-20 17:30 ` Jarkko Sakkinen [this message]
2025-03-21 9:01 ` Stefano Garzarella
2025-03-21 22:05 ` Borislav Petkov
2025-03-22 20:17 ` Jarkko Sakkinen
2025-03-24 9:00 ` Stefano Garzarella
2025-03-11 9:42 ` [PATCH v3 2/4] svsm: add header with SVSM_VTPM_CMD helpers Stefano Garzarella
2025-03-11 10:07 ` Jarkko Sakkinen
2025-03-12 11:47 ` Stefano Garzarella
2025-03-11 9:42 ` [PATCH v3 3/4] tpm: add SNP SVSM vTPM driver Stefano Garzarella
2025-03-14 16:48 ` Tom Lendacky
2025-03-17 13:43 ` Jarkko Sakkinen
2025-03-18 10:38 ` Stefano Garzarella
2025-03-18 14:54 ` Tom Lendacky
2025-03-18 16:18 ` Stefano Garzarella
2025-03-19 23:44 ` Jason Gunthorpe
2025-03-20 11:18 ` Stefano Garzarella
2025-03-20 15:00 ` Jarkko Sakkinen
2025-03-20 14:56 ` Jarkko Sakkinen
2025-03-11 9:42 ` [PATCH v3 4/4] x86/sev: register tpm-svsm platform device Stefano Garzarella
2025-03-14 16:56 ` Tom Lendacky
2025-03-17 13:34 ` Jarkko Sakkinen
2025-03-18 10:44 ` Stefano Garzarella
2025-03-20 15:02 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9xQw8QpRKk26G6R@kernel.org \
--to=jarkko@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=bp@alien8.de \
--cc=cclaudio@linux.ibm.com \
--cc=dave.hansen@linux.intel.com \
--cc=dionnaglaze@google.com \
--cc=dovmurik@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=jgg@ziepe.ca \
--cc=jroedel@suse.de \
--cc=linux-coco@lists.linux.dev \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterhuewe@gmx.de \
--cc=sgarzare@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.