From: Andrea Righi <arighi@nvidia.com>
To: Tejun Heo <tj@kernel.org>
Cc: David Vernet <void@manifault.com>,
Changwoo Min <changwoo@igalia.com>,
Joel Fernandes <joelagnelf@nvidia.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] sched_ext: idle: Extend topology optimizations to all tasks
Date: Thu, 20 Mar 2025 23:08:21 +0100 [thread overview]
Message-ID: <Z9yR1TYxni6wddnE@gpd3> (raw)
In-Reply-To: <Z9xHK8xgnWjXQ1-p@slm.duckdns.org>
Hi Tejun,
On Thu, Mar 20, 2025 at 06:49:47AM -1000, Tejun Heo wrote:
> On Thu, Mar 20, 2025 at 08:36:41AM +0100, Andrea Righi wrote:
> > +static const struct cpumask *task_cpumask(const struct task_struct *p, const struct cpumask *cpus,
> > + struct cpumask *local_cpus)
> > +{
> > + /*
> > + * If the task is allowed to run on all CPUs, simply use the
> > + * architecture's cpumask directly. Otherwise, compute the
> > + * intersection of the architecture's cpumask and the task's
> > + * allowed cpumask.
> > + */
> > + if (!cpus || p->nr_cpus_allowed >= num_possible_cpus() ||
> > + cpumask_subset(cpus, p->cpus_ptr))
> > + return cpus;
> > +
> > + if (!cpumask_equal(cpus, p->cpus_ptr) &&
>
> Weren't we talkign about removing this test?
sorry, it's actually removed in PATCH 3/6, but I'll clean it up also in
this one.
Thanks,
-Andrea
>
> Thanks.
>
> --
> tejun
next prev parent reply other threads:[~2025-03-20 22:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 7:36 [PATCHSET v5 sched_ext/for-6.15] sched_ext: Enhance built-in idle selection with allowed CPUs Andrea Righi
2025-03-20 7:36 ` [PATCH 1/6] sched_ext: idle: Extend topology optimizations to all tasks Andrea Righi
2025-03-20 16:49 ` Tejun Heo
2025-03-20 22:08 ` Andrea Righi [this message]
2025-03-20 7:36 ` [PATCH 2/6] sched_ext: idle: Explicitly pass allowed cpumask to scx_select_cpu_dfl() Andrea Righi
2025-03-21 10:15 ` changwoo
2025-03-21 22:02 ` Andrea Righi
2025-03-20 7:36 ` [PATCH 3/6] sched_ext: idle: Accept an arbitrary cpumask in scx_select_cpu_dfl() Andrea Righi
2025-03-20 7:36 ` [PATCH 4/6] sched_ext: idle: Introduce scx_bpf_select_cpu_and() Andrea Righi
2025-03-20 7:36 ` [PATCH 5/6] selftests/sched_ext: Add test for scx_bpf_select_cpu_and() Andrea Righi
2025-03-20 7:36 ` [PATCH 6/6] sched_ext: idle: Deprecate scx_bpf_select_cpu_dfl() Andrea Righi
2025-03-20 14:05 ` [PATCHSET v5 sched_ext/for-6.15] sched_ext: Enhance built-in idle selection with allowed CPUs Joel Fernandes
2025-03-20 15:33 ` Andrea Righi
-- strict thread matches above, loose matches on Subject: below --
2025-03-21 22:10 [PATCHSET v6 " Andrea Righi
2025-03-21 22:10 ` [PATCH 1/6] sched_ext: idle: Extend topology optimizations to all tasks Andrea Righi
2025-03-17 17:53 [PATCHSET v4 sched_ext/for-6.15] sched_ext: Enhance built-in idle selection with allowed CPUs Andrea Righi
2025-03-17 17:53 ` [PATCH 1/6] sched_ext: idle: Extend topology optimizations to all tasks Andrea Righi
2025-03-17 18:22 ` Tejun Heo
2025-03-18 4:43 ` Andrea Righi
2025-03-18 7:31 ` Andrea Righi
2025-03-18 17:31 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9yR1TYxni6wddnE@gpd3 \
--to=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.