From: Khadija Kamran <kamrankhadijadj@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
outreachy@lists.linux.dev,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] staging: axis-fifo: initialize read_timeout and write_timeout once in probe function
Date: Mon, 13 Mar 2023 20:18:20 +0500 [thread overview]
Message-ID: <ZA8+vC0e6EUdm9q/@khadija-virtual-machine> (raw)
In-Reply-To: <f545dc88-717b-4fa0-851a-733dd5fc2eff@kili.mountain>
On Mon, Mar 13, 2023 at 06:04:45PM +0300, Dan Carpenter wrote:
> On Mon, Mar 13, 2023 at 07:48:43PM +0500, Khadija Kamran wrote:
> > Also, I had one question. Is it okay to write a long subject as I have
> > used in this patch?
>
> People say subject should be 50 chars (I forget the exact limit) but
> there is a little bit of flexibility. This subject is too long though.
> Perhaps I would use something like:
>
> [PATCH v5] staging: axis-fifo: initialize timeouts in probe only
>
Thanks Dan,
I am going to use this for the next patch O:)
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2023-03-13 15:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 17:33 [PATCH v4] staging: axis-fifo: initialize read_timeout and write_timeout once in probe function Khadija Kamran
2023-03-13 6:37 ` Greg Kroah-Hartman
2023-03-13 14:13 ` Fabio M. De Francesco
2023-03-13 14:48 ` Khadija Kamran
2023-03-13 15:04 ` Dan Carpenter
2023-03-13 15:18 ` Khadija Kamran [this message]
2023-03-13 17:12 ` Alison Schofield
2023-03-13 18:26 ` Khadija Kamran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZA8+vC0e6EUdm9q/@khadija-virtual-machine \
--to=kamrankhadijadj@gmail.com \
--cc=error27@gmail.com \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.