From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98FA9C61DA4 for ; Mon, 13 Mar 2023 14:11:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 231726B0072; Mon, 13 Mar 2023 10:11:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DE696B0075; Mon, 13 Mar 2023 10:11:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CD646B0078; Mon, 13 Mar 2023 10:11:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F3B906B0072 for ; Mon, 13 Mar 2023 10:11:41 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C5A24AB17E for ; Mon, 13 Mar 2023 14:11:41 +0000 (UTC) X-FDA: 80564063202.27.A83F901 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 24FEE4000B for ; Mon, 13 Mar 2023 14:11:39 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf11.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678716700; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7+T6dHnWMt0eTApJmWeFLXC470KkyilznOFKbSywGK0=; b=DjNnWtrGyRjETHPUN0/9x2bA27Ij3Q1ZsNSX2mGEgBC9c3ZdWvWhUAbkRJOgXpS3N6ShLQ 6qCoMowe4kkZ3Txt4pM7kPvP9tEpPu9FfLRfwol4psX674qpFIS3A0izoDysqdjrfrr73x BaewPT2SJdhU64yUv0xW5cseS+cWhSI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf11.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678716700; a=rsa-sha256; cv=none; b=Rz6Tf2FdvyOui2/3kLRWO50t5qPEKbY6MAD/O43PmNGvUrloDxa+jEIVusBrViTOgCAUcK tKaAOOj9fKlVxkNNpjeDCE0cxjMnT9d6ZhVGFwRFF2/u2QKFiuYXky4OpKPV3reaM8lUpa w+l9EGdrO7QroEXXqMw3LVDxaZX49KQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 28715612E8; Mon, 13 Mar 2023 14:11:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4A13C433D2; Mon, 13 Mar 2023 14:11:36 +0000 (UTC) Date: Mon, 13 Mar 2023 14:11:33 +0000 From: Catalin Marinas To: Joey Gouly Cc: Andrew Morton , nd@arm.com, acme@redhat.com, izbyshev@ispras.ru, peterx@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Shuah Khan , Kees Cook Subject: Re: [PATCH v1 2/4] mm: fix error handling for map_deny_write_exec Message-ID: References: <20230308190423.46491-1-joey.gouly@arm.com> <20230308190423.46491-3-joey.gouly@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230308190423.46491-3-joey.gouly@arm.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 24FEE4000B X-Stat-Signature: 4cn5frzu959p3geocwcmcaftb18wkigp X-HE-Tag: 1678716699-383294 X-HE-Meta: U2FsdGVkX19PUc0jkCM2b+c+L7Hz4DjjgoUeUcr1inLWIdeFJkHANeFOh/4BDgWYQH/kcGWXudYRP90wkOQ9J9B28YLYb3/QqYjySYBG/p4UWHry0UcKt2EzEDBpztCSDeFx5mUEu92A/JmxciBB7iVI5IENlqcll2yM7YZeZGBmx6eAN+Y6iSzmur7AjJl34QUrdXLkcx6EMkoB8dlB5HBVaxms2oVasw1HwRP42n3viRfW7V39iXMqTmg8wD0fLAQz5cQQDzPEACC9OIJwWE3KPZt9gd4UEBD06QO0NrEC8WU8uIfI8d4ew7wwmPJ1JFKzLAznYyqcWzXRTJsSJiw+UGSz+Ceo2apLS2sc17sp/QKh2k9lDSwgwklkz8brCFca8iR0HwnLbVofDCQXL19NGEKn5iEuuHRVt24mV5iSGp5gm5/ZAgenGYcUTIa2eQSLzGBtWA7PrFtcy2W6Lm3pcMMIgskyLATaIz4/SWSxz7+0ebWwWLFhZlS7ivKyBZXGdIX+jC9+OoSVdHCv6h2g8L/MYAK+53QTDiYLryeraLA3IiZ6E3YlQjQ55wFFC/JerhbDg2E2j9rPS9z7VmlQeihJPKg8XgVgOG3xT/qMtH499+SMoMOBFGdXFeI8m8u32dYUM6EB6omQls+OzZcU0A0K9WN8gsRPuJWPxxTwn+yDbjM1XBoYZhWWXp9LYNweHE7LRONnRLHiIDeVa/dY/Nvt5SgviiiGdL9IFAunYqG3KzxfPwg19wJYiPl20Xr1T4lckJ4MwXyhw/bDlJ8g/123Fg99ss9xjGq4V2CtKmDdD4DjpaN9HFPfsXSlkKocXDtL3WpbfOLVHCgvID5Day8OjvfjEoPIdPAXj0lyFkAmxkOwxkAu91veAO/BbjV5Dy0cwRJZNaLhhf250KANQevb/RtVawqaqhRX5xhSnQdzpYNFrQNFZx09U2xDobQZHLRU+9PPREy/JZ1 cG5DLS7f K0rMZU34zknnHmYeLnt9JwDDSqg7klf2mCPKe8J+zPQWmRBChVZc3Zu+0mS4tknu/0fUaPwD7nYLYnvdS/eBiu5Haj6v0l4zdJZNmiDv0RYWHaM53W6zxPvFEDq2xbCtrH3wEZfQdMg1YIPN4Xlbb+cS3wXkomHb1ri1FzHI74OneKAYNc+w5rXfizo/jbYsGL+vVtsX0huOeFM27HQ0DH3AONvi4KSU1zE0CR8iajqabXvpV2abNuUx8NVpYpGV1AzlZY3fpESgnWJ8/os5lFMbwD0zhw58Gdl/rqzjn1AulMeeP0mW/5HfzY0uPZIUvetD3G9UWJ2S8tNgQuIhiGe6RER7fmBePSUx9iJCrOVcEYchN5vmduMyfUTl7N9J9QcWNItRBNNntplBLp8lNqtIenmyuBblqqAfJNmtp0VWOdFHxd54B5+Mh1AfSFGyWPskDQbCQqaFYP12bvtDqtgUPXEFOSwwkgOT+D2kh/D5m0VaqssZsAu9BzGxvriVncnBBiRUwW6gQ8/CT8QrfzNbtmm00wFK1J2WibL6euKqav1FS7XArFLJVkVezz59haOaL9levREKFjH9RmYV6HU+G5DtMjF1uzdJUR0UKUNWnDfQ8ayBFyobRKSTOmJoINTRhttAGTknk+sHlrWDPI/GDHRIig5928B4uBrokuQeJibeb5xwBRbtq9Jp7CrZWlPRspXRO0z7m6ICA8Q2iXixl8lcHRwVgTPPJrg/Z0n5QOGWq5EwTb9keitTNm4vIHmd6CTDtRgWnWKJdY8JeHrI3oijH+z+Jfop22yAUjTqLDhAZMFQI6aI9etZhpQcZrH6FmnBMx6lssywCGhKtRK1wWA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 08, 2023 at 07:04:21PM +0000, Joey Gouly wrote: > Commit 4a18419f71cd ("mm/mprotect: use mmu_gather") changed 'goto out;' > to 'break' in the loop. > This wasn't noticed while rebasing the MDWE patches, so fix it now. > > Fixes: b507808ebce2 ("mm: implement memory-deny-write-execute as a prctl") > Reported-by: Alexey Izbyshev > Link: https://lore.kernel.org/linux-arm-kernel/8408d8901e9d7ee6b78db4c6cba04b78@ispras.ru/ > Signed-off-by: Joey Gouly > Cc: Catalin Marinas > Cc: Andrew Morton Reviewed-by: Catalin Marinas