From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: Radoslaw Tyl <radoslawx.tyl@intel.com>
Cc: intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH net v1] i40e: fix flow director packet filter programming
Date: Mon, 13 Mar 2023 16:40:56 +0100 [thread overview]
Message-ID: <ZA9ECCdK8uShOKib@localhost.localdomain> (raw)
In-Reply-To: <20230313140733.4140757-1-radoslawx.tyl@intel.com>
On Mon, Mar 13, 2023 at 03:07:33PM +0100, Radoslaw Tyl wrote:
> Initialize to zero structures to build a valid
> Tx Packet used for the filter programming.
>
> Fixes: a9219b332f52 ("i40e: VLAN field for flow director")
> Signed-off-by: Radoslaw Tyl <radoslawx.tyl@intel.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
> index 924f972b91fa..72b091f2509d 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
> @@ -171,10 +171,10 @@ static char *i40e_create_dummy_packet(u8 *dummy_packet, bool ipv4, u8 l4proto,
> struct i40e_fdir_filter *data)
> {
> bool is_vlan = !!data->vlan_tag;
> - struct vlan_hdr vlan;
> - struct ipv6hdr ipv6;
> - struct ethhdr eth;
> - struct iphdr ip;
> + struct vlan_hdr vlan = {};
> + struct ipv6hdr ipv6 = {};
> + struct ethhdr eth = {};
> + struct iphdr ip = {};
> u8 *tmp;
>
> if (ipv4) {
> --
> 2.31.1
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Feel free to add review tag when someone paste it on ML (even internal
one):
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-03-13 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 14:07 [Intel-wired-lan] [PATCH net v1] i40e: fix flow director packet filter programming Radoslaw Tyl
2023-03-13 15:40 ` Michal Swiatkowski [this message]
2023-03-21 4:45 ` Arland, ArpanaX
2023-03-22 7:53 ` Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZA9ECCdK8uShOKib@localhost.localdomain \
--to=michal.swiatkowski@linux.intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=radoslawx.tyl@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.