From: Cyril Hrubis <chrubis@suse.cz>
To: Wei Gao <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 1/2] rseq: Copy linux rseq test header files to ltp
Date: Mon, 13 Mar 2023 16:48:50 +0100 [thread overview]
Message-ID: <ZA9F4vz/qVAjx4OB@yuki> (raw)
In-Reply-To: <20230221013446.19399-2-wegao@suse.com>
Hi!
> Signed-off-by: Wei Gao <wegao@suse.com>
> ---
> include/lapi/compiler.h | 30 +
> include/lapi/rseq-abi.h | 151 +++
> include/lapi/rseq-arm.h | 827 ++++++++++++
> include/lapi/rseq-arm64.h | 695 ++++++++++
> include/lapi/rseq-generic-thread-pointer.h | 25 +
> include/lapi/rseq-mips.h | 777 +++++++++++
> include/lapi/rseq-ppc-thread-pointer.h | 30 +
> include/lapi/rseq-ppc.h | 791 ++++++++++++
> include/lapi/rseq-riscv.h | 677 ++++++++++
> include/lapi/rseq-s390.h | 610 +++++++++
> include/lapi/rseq-skip.h | 65 +
> include/lapi/rseq-thread-pointer.h | 19 +
> include/lapi/rseq-x86-thread-pointer.h | 40 +
> include/lapi/rseq-x86.h | 1365 ++++++++++++++++++++
We actually does not need most of the code. The only thing that we use
from the architecture specific headers is the RSEQ_SIG constant. So
unless you actually plan to write tests that use the assembly code in
these headers I would put just the RSEQ_SIG into the lapi/rseq.h instead.
There is no point in adding complex code that is not going to the be
used.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-03-13 15:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 13:46 [LTP] [PATCH v1] rseq01: basic test rseq Wei Gao via ltp
2023-02-14 11:46 ` Cyril Hrubis
2023-02-15 2:34 ` [LTP] [PATCH v2] " Wei Gao via ltp
2023-02-16 10:58 ` Cyril Hrubis
2023-02-17 4:17 ` Wei Gao via ltp
2023-02-17 9:33 ` Cyril Hrubis
2023-02-21 1:34 ` [LTP] [PATCH v3 0/2] Move linux rseq test into ltp Wei Gao via ltp
2023-02-21 1:34 ` [LTP] [PATCH v3 1/2] rseq: Copy linux rseq test header files to ltp Wei Gao via ltp
2023-03-13 15:48 ` Cyril Hrubis [this message]
2023-03-14 13:49 ` Wei Gao via ltp
2023-03-14 16:29 ` Cyril Hrubis
2023-03-14 22:40 ` Wei Gao via ltp
2023-02-21 1:34 ` [LTP] [PATCH v3 2/2] rseq01: basic test rseq Wei Gao via ltp
2023-03-09 2:04 ` [LTP] [PATCH v4] " Wei Gao via ltp
2023-03-09 8:16 ` [LTP] [PATCH v5] " Wei Gao via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZA9F4vz/qVAjx4OB@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=wegao@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.