From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12E28C6FD19 for ; Mon, 13 Mar 2023 17:58:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229622AbjCMR6a (ORCPT ); Mon, 13 Mar 2023 13:58:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229516AbjCMR63 (ORCPT ); Mon, 13 Mar 2023 13:58:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44D1F1CF45; Mon, 13 Mar 2023 10:58:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C0752611DA; Mon, 13 Mar 2023 17:58:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCF52C433D2; Mon, 13 Mar 2023 17:58:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678730305; bh=R/CebLcuOYIfi6x1vLEG3j/yHBC7GgWxI/SYarquQus=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LH3JvtinkJ1j4GUObgdL7Upg9la09ptXBp3ufoB6TvF4MtA8uc8T/r/9d8kyc1mFL 1z1Vm8lD0lh+jIajBWC0NYvJj97QqHTagnC5X3QGVALu5n9TqBQbjZGmuM7g+KBVhf 8E9iqFGrfN+FTvqzIAz9GoWTn4KWVdpv9K6jY0FzXVMj0bvlN25rDGlMftEBqny3ar 0OpyZfn19uogCz0ijMZBAVkJCKKDf2bss8h7IAdE6+RyzyYCX/nr8e1GWyezBchUDO VnyxX8MwWtKizX4/GKOYdOU6QUc3v8MJAh7QztxOeY2GhJ90xeZVR9e5iF11FOINIO p4P52qnPDCpFw== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 2C6974049F; Mon, 13 Mar 2023 14:58:22 -0300 (-03) Date: Mon, 13 Mar 2023 14:58:22 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Jiri Olsa , Namhyung Kim , Ian Rogers , John Garry , James Clark , Adrian Hunter , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 04/16] perf kvm: Use subtraction for comparison metrics Message-ID: References: <20230313114018.543254-1-leo.yan@linaro.org> <20230313114018.543254-5-leo.yan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230313114018.543254-5-leo.yan@linaro.org> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Mon, Mar 13, 2023 at 07:40:06PM +0800, Leo Yan escreveu: > Currently the metrics comparison uses greater operator (>), it returns > the boolean value (0 or 1). > > This patch changes to use subtraction as comparison result, which can > be used by histograms sorting. Since the subtraction result is u64 > type, we change the function return type from int to int64_t to avoid > overflow. Not building at his point in the series: LD /tmp/build/perf-tools-next/util/perf-in.o builtin-kvm.c:80:18: error: initialization of ‘int (*)(struct kvm_event *, struct kvm_event *, int)’ from incompatible pointer type ‘int64_t (*)(struct kvm_event *, struct kvm_event *, int)’ {aka ‘long int (*)(struct kvm_event *, struct kvm_event *, int)’} [-Werror=incompatible-pointer-types] 80 | { #name, cmp_event_ ## compare_key } | ^~~~~~~~~~ builtin-kvm.c:83:9: note: in expansion of macro ‘DEF_SORT_NAME_KEY’ 83 | DEF_SORT_NAME_KEY(sample, count), | ^~~~~~~~~~~~~~~~~ builtin-kvm.c:80:18: note: (near initialization for ‘keys[0].key’) 80 | { #name, cmp_event_ ## compare_key } | ^~~~~~~~~~ builtin-kvm.c:83:9: note: in expansion of macro ‘DEF_SORT_NAME_KEY’ 83 | DEF_SORT_NAME_KEY(sample, count), | ^~~~~~~~~~~~~~~~~ builtin-kvm.c:80:18: error: initialization of ‘int (*)(struct kvm_event *, struct kvm_event *, int)’ from incompatible pointer type ‘int64_t (*)(struct kvm_event *, struct kvm_event *, int)’ {aka ‘long int (*)(struct kvm_event *, struct kvm_event *, int)’} [-Werror=incompatible-pointer-types] 80 | { #name, cmp_event_ ## compare_key } | ^~~~~~~~~~ builtin-kvm.c:84:9: note: in expansion of macro ‘DEF_SORT_NAME_KEY’ 84 | DEF_SORT_NAME_KEY(time, mean), | ^~~~~~~~~~~~~~~~~ builtin-kvm.c:80:18: note: (near initialization for ‘keys[1].key’) 80 | { #name, cmp_event_ ## compare_key } | ^~~~~~~~~~ builtin-kvm.c:84:9: note: in expansion of macro ‘DEF_SORT_NAME_KEY’ 84 | DEF_SORT_NAME_KEY(time, mean), | ^~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[3]: *** [/var/home/acme/git/perf-tools-next/tools/build/Makefile.build:97: /tmp/build/perf-tools-next/builtin-kvm.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [Makefile.perf:673: /tmp/build/perf-tools-next/perf-in.o] Error 2 make[2]: *** Waiting for unfinished jobs.... CC /tmp/build/perf-tools-next/pmu-events/pmu-events.o LD /tmp/build/perf-tools-next/pmu-events/pmu-events-in.o make[1]: *** [Makefile.perf:236: sub-make] Error 2 make: *** [Makefile:113: install-bin] Error 2 make: Leaving directory '/var/home/acme/git/perf-tools-next/tools/perf' Performance counter stats for 'make -k BUILD_BPF_SKEL=1 CORESIGHT=1 O=/tmp/build/perf-tools-next -C tools/perf install-bin': 46519453561 cycles:u 73484239007 instructions:u # 1.58 insn per cycle 10.053592077 seconds time elapsed 10.925077000 seconds user 8.045887000 seconds sys ⬢[acme@toolbox perf-tools-next]$ git log --oneline -4 40843f667620dcf3 (HEAD) perf kvm: Use subtraction for comparison metrics c6a5a089864171f2 perf kvm: Move up metrics helpers 1d75bc17ffc933aa perf kvm: Add pointer to 'perf_kvm_stat' in kvm event 4568393639938020 perf kvm: Refactor overall statistics ⬢[acme@toolbox perf-tools-next]$ ⬢[acme@toolbox perf-tools-next]$ gcc --version gcc (GCC) 12.2.1 20221121 (Red Hat 12.2.1-4) > Signed-off-by: Leo Yan > --- > tools/perf/builtin-kvm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c > index 62c097a37da9..4e9519390da6 100644 > --- a/tools/perf/builtin-kvm.c > +++ b/tools/perf/builtin-kvm.c > @@ -63,10 +63,10 @@ static u64 get_event_ ##func(struct kvm_event *event, int vcpu) \ > > #define COMPARE_EVENT_KEY(func, field) \ > GET_EVENT_KEY(func, field) \ > -static int cmp_event_ ## func(struct kvm_event *one, \ > +static int64_t cmp_event_ ## func(struct kvm_event *one, \ > struct kvm_event *two, int vcpu) \ > { \ > - return get_event_ ##func(one, vcpu) > \ > + return get_event_ ##func(one, vcpu) - \ > get_event_ ##func(two, vcpu); \ > } > > @@ -523,7 +523,7 @@ static void insert_to_result(struct rb_root *result, struct kvm_event *event, > p = container_of(*rb, struct kvm_event, rb); > parent = *rb; > > - if (bigger(event, p, vcpu)) > + if (bigger(event, p, vcpu) > 0) > rb = &(*rb)->rb_left; > else > rb = &(*rb)->rb_right; > -- > 2.34.1 > -- - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DA12C61DA4 for ; Mon, 13 Mar 2023 17:59:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xwd7pdSDPXsJRWBgl4z27aHp3cBYgN/YNCRf9Xjy2IQ=; b=OQvlT/jGE9Qk19 2oJUW1y7FcEtyIO+9QRN8L4GN7bPnny0u6HQYtOt022NQU1pgCp0bQyNPXW/UVpe+ILucV4fHU5cL PfFnXZYsACNETqG/xwPI8OBSGWTyir34bXwMdDiowj4qQesNJXGSmosB3vd3e7s82Wj5xhObR8OKA r+zvpRvXGCO3AWUNl2E7ogqhPrPgasz4bgWOGtEaCuEUnXFMTF+XBb6mHdNIdD7xa397h/OmkWRu4 2kLWoGpll0aysOJZ0eIu+c2nVKqDeiifLQDI1k84pGncSyaR+GDTmuS4bdk4VzEpGWoGAdhZGpImr L6Y1mbHMVzJ2EiSgVQzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbmRK-007D0d-Qg; Mon, 13 Mar 2023 17:58:30 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbmRJ-007D0P-7y for linux-arm-kernel@bombadil.infradead.org; Mon, 13 Mar 2023 17:58:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=npX516xDiNW3apz0wbtZxe3hDOqUAMl1utXB/GY895I=; b=IXVBxSpGMLbhuHbZQMgd/4g+iE g/2+ODldO8vF9Lm4QkwcW9ZPPZfAw7PMPSXk9ziRH/WJZ34BEmzytN0RTyR9XWNOkey84uPvpFopT CBgfKX6Rc+Dnm9xJ+aTncJYuMjtbIVh9xvgY8d/XYs0b+Gevmi0a8RiLVI/cv8eUI+GLy00z0NGSL S3QLt5NY35YRwhn1r7oEtxVH4Fxx6dlKRvY9I95gHPPiwkgwC1wSqfwDUA6sxqujodQZ/BoUNPy1E ZxzqENC1LLR0KDR3PkGCy/IYaQz1IxOw1yqKE+f50ExpuerkfAIta+uq1KD7TSCVNdB1LJPCiZoO3 gkWvXXXg==; Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbmRG-00C9xX-6V; Mon, 13 Mar 2023 17:58:27 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 2C6974049F; Mon, 13 Mar 2023 14:58:22 -0300 (-03) Date: Mon, 13 Mar 2023 14:58:22 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Jiri Olsa , Namhyung Kim , Ian Rogers , John Garry , James Clark , Adrian Hunter , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 04/16] perf kvm: Use subtraction for comparison metrics Message-ID: References: <20230313114018.543254-1-leo.yan@linaro.org> <20230313114018.543254-5-leo.yan@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230313114018.543254-5-leo.yan@linaro.org> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RW0gTW9uLCBNYXIgMTMsIDIwMjMgYXQgMDc6NDA6MDZQTSArMDgwMCwgTGVvIFlhbiBlc2NyZXZl dToKPiBDdXJyZW50bHkgdGhlIG1ldHJpY3MgY29tcGFyaXNvbiB1c2VzIGdyZWF0ZXIgb3BlcmF0 b3IgKD4pLCBpdCByZXR1cm5zCj4gdGhlIGJvb2xlYW4gdmFsdWUgKDAgb3IgMSkuCj4gCj4gVGhp cyBwYXRjaCBjaGFuZ2VzIHRvIHVzZSBzdWJ0cmFjdGlvbiBhcyBjb21wYXJpc29uIHJlc3VsdCwg d2hpY2ggY2FuCj4gYmUgdXNlZCBieSBoaXN0b2dyYW1zIHNvcnRpbmcuICBTaW5jZSB0aGUgc3Vi dHJhY3Rpb24gcmVzdWx0IGlzIHU2NAo+IHR5cGUsIHdlIGNoYW5nZSB0aGUgZnVuY3Rpb24gcmV0 dXJuIHR5cGUgZnJvbSBpbnQgdG8gaW50NjRfdCB0byBhdm9pZAo+IG92ZXJmbG93LgoKTm90IGJ1 aWxkaW5nIGF0IGhpcyBwb2ludCBpbiB0aGUgc2VyaWVzOgoKICBMRCAgICAgIC90bXAvYnVpbGQv cGVyZi10b29scy1uZXh0L3V0aWwvcGVyZi1pbi5vCmJ1aWx0aW4ta3ZtLmM6ODA6MTg6IGVycm9y OiBpbml0aWFsaXphdGlvbiBvZiDigJhpbnQgKCopKHN0cnVjdCBrdm1fZXZlbnQgKiwgc3RydWN0 IGt2bV9ldmVudCAqLCBpbnQp4oCZIGZyb20gaW5jb21wYXRpYmxlIHBvaW50ZXIgdHlwZSDigJhp bnQ2NF90ICgqKShzdHJ1Y3Qga3ZtX2V2ZW50ICosIHN0cnVjdCBrdm1fZXZlbnQgKiwgaW50KeKA mSB7YWthIOKAmGxvbmcgaW50ICgqKShzdHJ1Y3Qga3ZtX2V2ZW50ICosIHN0cnVjdCBrdm1fZXZl bnQgKiwgaW50KeKAmX0gWy1XZXJyb3I9aW5jb21wYXRpYmxlLXBvaW50ZXItdHlwZXNdCiAgIDgw IHwgICAgICAgICB7ICNuYW1lLCBjbXBfZXZlbnRfICMjIGNvbXBhcmVfa2V5IH0KICAgICAgfCAg ICAgICAgICAgICAgICAgIF5+fn5+fn5+fn4KYnVpbHRpbi1rdm0uYzo4Mzo5OiBub3RlOiBpbiBl eHBhbnNpb24gb2YgbWFjcm8g4oCYREVGX1NPUlRfTkFNRV9LRVnigJkKICAgODMgfCAgICAgICAg IERFRl9TT1JUX05BTUVfS0VZKHNhbXBsZSwgY291bnQpLAogICAgICB8ICAgICAgICAgXn5+fn5+ fn5+fn5+fn5+fn4KYnVpbHRpbi1rdm0uYzo4MDoxODogbm90ZTogKG5lYXIgaW5pdGlhbGl6YXRp b24gZm9yIOKAmGtleXNbMF0ua2V54oCZKQogICA4MCB8ICAgICAgICAgeyAjbmFtZSwgY21wX2V2 ZW50XyAjIyBjb21wYXJlX2tleSB9CiAgICAgIHwgICAgICAgICAgICAgICAgICBefn5+fn5+fn5+ CmJ1aWx0aW4ta3ZtLmM6ODM6OTogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKAmERFRl9T T1JUX05BTUVfS0VZ4oCZCiAgIDgzIHwgICAgICAgICBERUZfU09SVF9OQU1FX0tFWShzYW1wbGUs IGNvdW50KSwKICAgICAgfCAgICAgICAgIF5+fn5+fn5+fn5+fn5+fn5+CmJ1aWx0aW4ta3ZtLmM6 ODA6MTg6IGVycm9yOiBpbml0aWFsaXphdGlvbiBvZiDigJhpbnQgKCopKHN0cnVjdCBrdm1fZXZl bnQgKiwgc3RydWN0IGt2bV9ldmVudCAqLCBpbnQp4oCZIGZyb20gaW5jb21wYXRpYmxlIHBvaW50 ZXIgdHlwZSDigJhpbnQ2NF90ICgqKShzdHJ1Y3Qga3ZtX2V2ZW50ICosIHN0cnVjdCBrdm1fZXZl bnQgKiwgaW50KeKAmSB7YWthIOKAmGxvbmcgaW50ICgqKShzdHJ1Y3Qga3ZtX2V2ZW50ICosIHN0 cnVjdCBrdm1fZXZlbnQgKiwgaW50KeKAmX0gWy1XZXJyb3I9aW5jb21wYXRpYmxlLXBvaW50ZXIt dHlwZXNdCiAgIDgwIHwgICAgICAgICB7ICNuYW1lLCBjbXBfZXZlbnRfICMjIGNvbXBhcmVfa2V5 IH0KICAgICAgfCAgICAgICAgICAgICAgICAgIF5+fn5+fn5+fn4KYnVpbHRpbi1rdm0uYzo4NDo5 OiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8g4oCYREVGX1NPUlRfTkFNRV9LRVnigJkKICAg ODQgfCAgICAgICAgIERFRl9TT1JUX05BTUVfS0VZKHRpbWUsIG1lYW4pLAogICAgICB8ICAgICAg ICAgXn5+fn5+fn5+fn5+fn5+fn4KYnVpbHRpbi1rdm0uYzo4MDoxODogbm90ZTogKG5lYXIgaW5p dGlhbGl6YXRpb24gZm9yIOKAmGtleXNbMV0ua2V54oCZKQogICA4MCB8ICAgICAgICAgeyAjbmFt ZSwgY21wX2V2ZW50XyAjIyBjb21wYXJlX2tleSB9CiAgICAgIHwgICAgICAgICAgICAgICAgICBe fn5+fn5+fn5+CmJ1aWx0aW4ta3ZtLmM6ODQ6OTogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3Jv IOKAmERFRl9TT1JUX05BTUVfS0VZ4oCZCiAgIDg0IHwgICAgICAgICBERUZfU09SVF9OQU1FX0tF WSh0aW1lLCBtZWFuKSwKICAgICAgfCAgICAgICAgIF5+fn5+fn5+fn5+fn5+fn5+CmNjMTogYWxs IHdhcm5pbmdzIGJlaW5nIHRyZWF0ZWQgYXMgZXJyb3JzCm1ha2VbM106ICoqKiBbL3Zhci9ob21l L2FjbWUvZ2l0L3BlcmYtdG9vbHMtbmV4dC90b29scy9idWlsZC9NYWtlZmlsZS5idWlsZDo5Nzog L3RtcC9idWlsZC9wZXJmLXRvb2xzLW5leHQvYnVpbHRpbi1rdm0ub10gRXJyb3IgMQptYWtlWzNd OiAqKiogV2FpdGluZyBmb3IgdW5maW5pc2hlZCBqb2JzLi4uLgptYWtlWzJdOiAqKiogW01ha2Vm aWxlLnBlcmY6NjczOiAvdG1wL2J1aWxkL3BlcmYtdG9vbHMtbmV4dC9wZXJmLWluLm9dIEVycm9y IDIKbWFrZVsyXTogKioqIFdhaXRpbmcgZm9yIHVuZmluaXNoZWQgam9icy4uLi4KICBDQyAgICAg IC90bXAvYnVpbGQvcGVyZi10b29scy1uZXh0L3BtdS1ldmVudHMvcG11LWV2ZW50cy5vCiAgTEQg ICAgICAvdG1wL2J1aWxkL3BlcmYtdG9vbHMtbmV4dC9wbXUtZXZlbnRzL3BtdS1ldmVudHMtaW4u bwptYWtlWzFdOiAqKiogW01ha2VmaWxlLnBlcmY6MjM2OiBzdWItbWFrZV0gRXJyb3IgMgptYWtl OiAqKiogW01ha2VmaWxlOjExMzogaW5zdGFsbC1iaW5dIEVycm9yIDIKbWFrZTogTGVhdmluZyBk aXJlY3RvcnkgJy92YXIvaG9tZS9hY21lL2dpdC9wZXJmLXRvb2xzLW5leHQvdG9vbHMvcGVyZicK CiBQZXJmb3JtYW5jZSBjb3VudGVyIHN0YXRzIGZvciAnbWFrZSAtayBCVUlMRF9CUEZfU0tFTD0x IENPUkVTSUdIVD0xIE89L3RtcC9idWlsZC9wZXJmLXRvb2xzLW5leHQgLUMgdG9vbHMvcGVyZiBp bnN0YWxsLWJpbic6CgogICAgICAgNDY1MTk0NTM1NjEgICAgICBjeWNsZXM6dQogICAgICAgNzM0 ODQyMzkwMDcgICAgICBpbnN0cnVjdGlvbnM6dSAgICAgICAgICAgICAgICAgICAjICAgIDEuNTgg IGluc24gcGVyIGN5Y2xlCgogICAgICAxMC4wNTM1OTIwNzcgc2Vjb25kcyB0aW1lIGVsYXBzZWQK CiAgICAgIDEwLjkyNTA3NzAwMCBzZWNvbmRzIHVzZXIKICAgICAgIDguMDQ1ODg3MDAwIHNlY29u ZHMgc3lzCgoK4qyiW2FjbWVAdG9vbGJveCBwZXJmLXRvb2xzLW5leHRdJCBnaXQgbG9nIC0tb25l bGluZSAtNAo0MDg0M2Y2Njc2MjBkY2YzIChIRUFEKSBwZXJmIGt2bTogVXNlIHN1YnRyYWN0aW9u IGZvciBjb21wYXJpc29uIG1ldHJpY3MKYzZhNWEwODk4NjQxNzFmMiBwZXJmIGt2bTogTW92ZSB1 cCBtZXRyaWNzIGhlbHBlcnMKMWQ3NWJjMTdmZmM5MzNhYSBwZXJmIGt2bTogQWRkIHBvaW50ZXIg dG8gJ3BlcmZfa3ZtX3N0YXQnIGluIGt2bSBldmVudAo0NTY4MzkzNjM5OTM4MDIwIHBlcmYga3Zt OiBSZWZhY3RvciBvdmVyYWxsIHN0YXRpc3RpY3MK4qyiW2FjbWVAdG9vbGJveCBwZXJmLXRvb2xz LW5leHRdJAoK4qyiW2FjbWVAdG9vbGJveCBwZXJmLXRvb2xzLW5leHRdJCBnY2MgLS12ZXJzaW9u CmdjYyAoR0NDKSAxMi4yLjEgMjAyMjExMjEgKFJlZCBIYXQgMTIuMi4xLTQpCiAKPiBTaWduZWQt b2ZmLWJ5OiBMZW8gWWFuIDxsZW8ueWFuQGxpbmFyby5vcmc+Cj4gLS0tCj4gIHRvb2xzL3BlcmYv YnVpbHRpbi1rdm0uYyB8IDYgKysrLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMo KyksIDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL3BlcmYvYnVpbHRpbi1r dm0uYyBiL3Rvb2xzL3BlcmYvYnVpbHRpbi1rdm0uYwo+IGluZGV4IDYyYzA5N2EzN2RhOS4uNGU5 NTE5MzkwZGE2IDEwMDY0NAo+IC0tLSBhL3Rvb2xzL3BlcmYvYnVpbHRpbi1rdm0uYwo+ICsrKyBi L3Rvb2xzL3BlcmYvYnVpbHRpbi1rdm0uYwo+IEBAIC02MywxMCArNjMsMTAgQEAgc3RhdGljIHU2 NCBnZXRfZXZlbnRfICMjZnVuYyhzdHJ1Y3Qga3ZtX2V2ZW50ICpldmVudCwgaW50IHZjcHUpCQlc Cj4gIAo+ICAjZGVmaW5lIENPTVBBUkVfRVZFTlRfS0VZKGZ1bmMsIGZpZWxkKQkJCQkJXAo+ICBH RVRfRVZFTlRfS0VZKGZ1bmMsIGZpZWxkKQkJCQkJCVwKPiAtc3RhdGljIGludCBjbXBfZXZlbnRf ICMjIGZ1bmMoc3RydWN0IGt2bV9ldmVudCAqb25lLAkJCVwKPiArc3RhdGljIGludDY0X3QgY21w X2V2ZW50XyAjIyBmdW5jKHN0cnVjdCBrdm1fZXZlbnQgKm9uZSwJCVwKPiAgCQkJICAgICAgc3Ry dWN0IGt2bV9ldmVudCAqdHdvLCBpbnQgdmNwdSkJCVwKPiAgewkJCQkJCQkJCVwKPiAtCXJldHVy biBnZXRfZXZlbnRfICMjZnVuYyhvbmUsIHZjcHUpID4JCQkJXAo+ICsJcmV0dXJuIGdldF9ldmVu dF8gIyNmdW5jKG9uZSwgdmNwdSkgLQkJCQlcCj4gIAkgICAgICAgZ2V0X2V2ZW50XyAjI2Z1bmMo dHdvLCB2Y3B1KTsJCQkJXAo+ICB9Cj4gIAo+IEBAIC01MjMsNyArNTIzLDcgQEAgc3RhdGljIHZv aWQgaW5zZXJ0X3RvX3Jlc3VsdChzdHJ1Y3QgcmJfcm9vdCAqcmVzdWx0LCBzdHJ1Y3Qga3ZtX2V2 ZW50ICpldmVudCwKPiAgCQlwID0gY29udGFpbmVyX29mKCpyYiwgc3RydWN0IGt2bV9ldmVudCwg cmIpOwo+ICAJCXBhcmVudCA9ICpyYjsKPiAgCj4gLQkJaWYgKGJpZ2dlcihldmVudCwgcCwgdmNw dSkpCj4gKwkJaWYgKGJpZ2dlcihldmVudCwgcCwgdmNwdSkgPiAwKQo+ICAJCQlyYiA9ICYoKnJi KS0+cmJfbGVmdDsKPiAgCQllbHNlCj4gIAkJCXJiID0gJigqcmIpLT5yYl9yaWdodDsKPiAtLSAK PiAyLjM0LjEKPiAKCi0tIAoKLSBBcm5hbGRvCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==