From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B74E5C64EC4 for ; Mon, 6 Mar 2023 17:41:20 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 976C7113A; Mon, 6 Mar 2023 18:40:28 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 976C7113A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1678124478; bh=sVdZcAMMU1pp37zbXlyAkpW1ZICsPwIolSPJsPbvJwo=; h=Date:From:To:Subject:References:In-Reply-To:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=A072hYER9xM9xe1B0p/5ZRSV/S0jzEvkZXsLalTbzqkqznGyEJNIYkCjMT+ktgnL9 U+0HzEd9QUO/IJW0dv5zT8KXD0XK5HdQe+xCAnX8r/EYimrblTmijilJidVYaxypBL X2rm+fLahVg0UfFO0qwjljm09gM/H70Qq99+TTxI= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 41E8DF80553; Mon, 6 Mar 2023 18:38:54 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CE129F80266; Thu, 2 Mar 2023 13:46:00 +0100 (CET) Received: from out-47.mta0.migadu.com (out-47.mta0.migadu.com [IPv6:2001:41d0:1004:224b::2f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DE16DF800DF for ; Thu, 2 Mar 2023 13:45:53 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DE16DF800DF Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=kkaqAPLJ Date: Thu, 2 Mar 2023 13:45:50 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1677761152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6NPpn9lnE9VN46m7Kz9u5WpXlX7L7nN99uIr6gXUSh8=; b=kkaqAPLJxMlF5jBJFTUgdiZbbOF8VbSmmAy0Y2OOaabuY0Mt67pKg+p1NiZdVukSscLx5j p9lz5GTqXUhiS2fEdyRU0I+oZtD/aj5UxRScNqBPjTYPvOW/3qQHdPH6yEg1kqd0tmeB6g GQu3l/NhZIl7D4tJFN3vYJFcdut4Wek= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Richard Leitner To: Mark Brown Subject: Re: [PATCH 3/3] ASoC: maxim,max9867: add "mclk" support Message-ID: References: <20230302-max9867-v1-0-aa9f7f25db5e@skidata.com> <20230302-max9867-v1-3-aa9f7f25db5e@skidata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-MailFrom: richard.leitner@linux.dev X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: UULTRP3JTCG3TWEJZNVYTJS2EBBQ7EWI X-Message-ID-Hash: UULTRP3JTCG3TWEJZNVYTJS2EBBQ7EWI X-Mailman-Approved-At: Mon, 06 Mar 2023 17:38:44 +0000 CC: Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Ladislav Michl , Takashi Iwai , Benjamin Bara , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Leitner X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, Mar 02, 2023 at 12:20:18PM +0000, Mark Brown wrote: > On Thu, Mar 02, 2023 at 12:55:03PM +0100, richard.leitner@linux.dev wrote: > > > + max9867->mclk = devm_clk_get(&i2c->dev, "mclk"); > > + if (IS_ERR(max9867->mclk)) > > + return PTR_ERR(max9867->mclk); > > + ret = clk_prepare_enable(max9867->mclk); > > + if (ret < 0) > > + dev_err(&i2c->dev, "Failed to enable MCLK: %d\n", ret); > > + > > Nothing ever disables the clock - we need a disable in the remove path > at least. Sure. Sorry for missing that. I will send a v2 later today. regards;rl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42A32C6FA8E for ; Thu, 2 Mar 2023 12:45:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229595AbjCBMp5 (ORCPT ); Thu, 2 Mar 2023 07:45:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229513AbjCBMp4 (ORCPT ); Thu, 2 Mar 2023 07:45:56 -0500 X-Greylist: delayed 3279 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 02 Mar 2023 04:45:54 PST Received: from out-31.mta0.migadu.com (out-31.mta0.migadu.com [IPv6:2001:41d0:1004:224b::1f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 047D510A99 for ; Thu, 2 Mar 2023 04:45:54 -0800 (PST) Date: Thu, 2 Mar 2023 13:45:50 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1677761152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6NPpn9lnE9VN46m7Kz9u5WpXlX7L7nN99uIr6gXUSh8=; b=kkaqAPLJxMlF5jBJFTUgdiZbbOF8VbSmmAy0Y2OOaabuY0Mt67pKg+p1NiZdVukSscLx5j p9lz5GTqXUhiS2fEdyRU0I+oZtD/aj5UxRScNqBPjTYPvOW/3qQHdPH6yEg1kqd0tmeB6g GQu3l/NhZIl7D4tJFN3vYJFcdut4Wek= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Richard Leitner To: Mark Brown Cc: Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Ladislav Michl , Jaroslav Kysela , Takashi Iwai , Benjamin Bara , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Leitner Subject: Re: [PATCH 3/3] ASoC: maxim,max9867: add "mclk" support Message-ID: References: <20230302-max9867-v1-0-aa9f7f25db5e@skidata.com> <20230302-max9867-v1-3-aa9f7f25db5e@skidata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Mar 02, 2023 at 12:20:18PM +0000, Mark Brown wrote: > On Thu, Mar 02, 2023 at 12:55:03PM +0100, richard.leitner@linux.dev wrote: > > > + max9867->mclk = devm_clk_get(&i2c->dev, "mclk"); > > + if (IS_ERR(max9867->mclk)) > > + return PTR_ERR(max9867->mclk); > > + ret = clk_prepare_enable(max9867->mclk); > > + if (ret < 0) > > + dev_err(&i2c->dev, "Failed to enable MCLK: %d\n", ret); > > + > > Nothing ever disables the clock - we need a disable in the remove path > at least. Sure. Sorry for missing that. I will send a v2 later today. regards;rl