From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25B2FC678D4 for ; Thu, 2 Mar 2023 14:03:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229781AbjCBODL (ORCPT ); Thu, 2 Mar 2023 09:03:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229758AbjCBODJ (ORCPT ); Thu, 2 Mar 2023 09:03:09 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63D8A1420F for ; Thu, 2 Mar 2023 06:03:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pUNnfLxusFZn4Q8JyBqAa2cH1Fz9OVudplm9AoohRDI=; b=qXgA4/snBz7NrJAAOiUHOwF0jm dUlUxdORIx842bJHkkJ8mvzvpad5vl/fIDCrg+lMwuw9ktY2ZvL8ag6V+Q0Id+FGiPLzjavVQ74Jp hYLsN0wF1cz+6881ZQO4EoviZURoybXWfV5in7JGLUZHfjG64Gp9ElfrW0sZdwLymTTr14v2XSR95 R/9CHesu3mvfdlQGbfxTGriDbg6mbY9Y6dlNKN9ZNbyU21yv4JnKAo/CE6Yeb8jAMSQBJPPpLMA3D NfsapuCjgrNL7YEtteTU4oDnOkrvp6AakBW+qjk3dK1J4605MOPDuqXg0Qh9DKvSvWb1L0YgN/qUX M+DeiW1w==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pXjWT-002P66-OD; Thu, 02 Mar 2023 14:03:05 +0000 Date: Thu, 2 Mar 2023 06:03:05 -0800 From: Christoph Hellwig To: Johannes Thumshirn Cc: Qu Wenruo , David Sterba , "linux-btrfs@vger.kernel.org" , Josef Bacik , Christoph Hellwig Subject: Re: [PATCH v7 04/13] btrfs: add support for inserting raid stripe extents Message-ID: References: <94293952cdc120b46edf82672af874b0877e1e83.1677750131.git.johannes.thumshirn@wdc.com> <3e2d5ede-fb00-3aa8-e55e-d088b8df9e60@gmx.com> <2648e7a4-271d-b49e-5ea6-6d3826f42f59@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2648e7a4-271d-b49e-5ea6-6d3826f42f59@wdc.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, Mar 02, 2023 at 11:45:44AM +0000, Johannes Thumshirn wrote: > + wait_event(fs_info->ordered_stripe_wait, > + !btrfs_ordered_stripes_pending(fs_info)); Ugg. Waiting for processing from one workqueue from another one is really a big fat warning sign you are in workqueue hell. Let's take a step back and solve this properly.