From: Mingwei Zhang <mizhang@google.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Sagi Shahar <sagis@google.com>,
Erdem Aktas <erdemaktas@google.com>,
Peter Shier <pshier@google.com>,
Anish Ghulati <aghulati@google.com>,
Oliver Upton <oliver.upton@linux.dev>,
James Houghton <jthoughton@google.com>,
Anish Moorthy <amoorthy@google.com>,
Ben Gardon <bgardon@google.com>,
David Matlack <dmatlack@google.com>,
Ricardo Koller <ricarkol@google.com>,
Axel Rasmussen <axelrasmussen@google.com>,
Aaron Lewis <aaronlewis@google.com>,
Ashish Kalra <ashish.kalra@amd.com>,
Babu Moger <babu.moger@amd.com>, Chao Gao <chao.gao@intel.com>,
Chao Peng <chao.p.peng@linux.intel.com>,
Chenyi Qiang <chenyi.qiang@intel.com>,
David Woodhouse <dwmw@amazon.co.uk>,
Emanuele Giuseppe Esposito <eesposit@redhat.com>,
Gavin Shan <gshan@redhat.com>, Guang Zeng <guang.zeng@intel.com>,
Hou Wenlong <houwenlong.hwl@antgroup.com>,
Jiaxi Chen <jiaxi.chen@linux.intel.com>,
Jim Mattson <jmattson@google.com>, Jing Liu <jing2.liu@intel.com>,
Junaid Shahid <junaids@google.com>,
Kai Huang <kai.huang@intel.com>,
Leonardo Bras <leobras@redhat.com>,
Like Xu <like.xu.linux@gmail.com>,
Li RongQing <lirongqing@baidu.com>,
"Maciej S . Szmigiero" <maciej.szmigiero@oracle.com>,
Maxim Levitsky <mlevitsk@redhat.com>,
Michael Roth <michael.roth@amd.com>, Michal Luczaj <mhal@rbox.co>,
Nikunj A Dadhania <nikunj@amd.com>,
Paul Durrant <pdurrant@amazon.com>,
Peng Hao <flyingpenghao@gmail.com>,
Peter Gonda <pgonda@google.com>, Peter Xu <peterx@redhat.com>,
Robert Hoo <robert.hu@linux.intel.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Vipin Sharma <vipinsh@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Wei Wang <wei.w.wang@intel.com>,
Xiaoyao Li <xiaoyao.li@intel.com>,
Yu Zhang <yu.c.zhang@linux.intel.com>,
Zhenzhong Duan <zhenzhong.duan@intel.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Documentation/process: Add a maintainer handbook for KVM x86
Date: Thu, 2 Mar 2023 18:46:42 +0000 [thread overview]
Message-ID: <ZADvEmVmCOB5Db6z@google.com> (raw)
In-Reply-To: <Y/VhzWCcC7LtGm4D@google.com>
On Tue, Feb 21, 2023, Sean Christopherson wrote:
> On Sat, Feb 18, 2023, Mingwei Zhang wrote:
> > On Fri, Feb 17, 2023, Sean Christopherson wrote:
> > > +Coding Style
> > > +~~~~~~~~~~~~
> > > +When it comes to style, naming, patterns, etc., consistency is the number one
> > > +priority in KVM x86. If all else fails, match what already exists.
> > > +
> > > +With a few caveats listed below, follow the tip tree maintainers' preferred
> > > +:ref:`maintainer-tip-coding-style`, as patches/series often touch both KVM and
> > > +non-KVM x86 files, i.e. draw the attention of KVM *and* tip tree maintainers.
> > > +
> > > +Using reverse fir tree for variable declarations isn't strictly required,
> > > +though it is still preferred.
> >
> > What is the 'reverse fir tree'? Maybe, "Reverse Christmas Tree" is
> > better to understand.
>
> For some parts of the world, but not all. For this, I want to follow whatever
> description the tip tree uses, which as of today is "reverse fir tree", as this
> is really a qualifier on the tip tree rules.
Some parts of the world is correct. In fact, in our world, we use
'reverse Christmas Tree' more than the other. Check lore.kernel.org:
https://lore.kernel.org/all/?q=reverse+christmas+tree
https://lore.kernel.org/all/?q=reverse+fir+tree
You will find the former is used 10x more frequent than the latter.
Overall, I don't hold a strong opinion immediately after I understand
the meaning of 'reverse fir tree' and I do agree that it is safer to
follow the Linux Tip Tree Handbook.
Also, thanks for the whole guideline.
-Mingwei
next prev parent reply other threads:[~2023-03-02 18:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 22:54 [PATCH 0/2] Documentation/process: Add a maintainer handbook for KVM x86 Sean Christopherson
2023-02-17 22:54 ` [PATCH 1/2] Documentation/process: Add a label for the tip tree handbook's coding style Sean Christopherson
2023-02-17 22:54 ` [PATCH 2/2] Documentation/process: Add a maintainer handbook for KVM x86 Sean Christopherson
2023-02-18 1:52 ` Mingwei Zhang
2023-02-22 0:29 ` Sean Christopherson
2023-03-02 18:46 ` Mingwei Zhang [this message]
2023-02-20 8:10 ` Yuan Yao
2023-02-20 10:07 ` Like Xu
2023-02-22 1:55 ` Sean Christopherson
2023-02-20 23:17 ` David Woodhouse
2023-02-21 19:54 ` Sean Christopherson
2023-02-21 11:06 ` Yu Zhang
2023-02-22 0:25 ` Sean Christopherson
2023-02-24 9:44 ` Yu Zhang
2023-02-22 19:26 ` Maciej S. Szmigiero
2023-02-22 21:25 ` Sean Christopherson
2023-02-22 22:09 ` Maciej S. Szmigiero
2023-02-28 14:45 ` Robert Hoo
2023-03-07 17:53 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZADvEmVmCOB5Db6z@google.com \
--to=mizhang@google.com \
--cc=aaronlewis@google.com \
--cc=aghulati@google.com \
--cc=amoorthy@google.com \
--cc=ashish.kalra@amd.com \
--cc=axelrasmussen@google.com \
--cc=babu.moger@amd.com \
--cc=bgardon@google.com \
--cc=bp@alien8.de \
--cc=chao.gao@intel.com \
--cc=chao.p.peng@linux.intel.com \
--cc=chenyi.qiang@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dmatlack@google.com \
--cc=dwmw@amazon.co.uk \
--cc=eesposit@redhat.com \
--cc=erdemaktas@google.com \
--cc=flyingpenghao@gmail.com \
--cc=gshan@redhat.com \
--cc=guang.zeng@intel.com \
--cc=houwenlong.hwl@antgroup.com \
--cc=jiaxi.chen@linux.intel.com \
--cc=jing2.liu@intel.com \
--cc=jmattson@google.com \
--cc=jthoughton@google.com \
--cc=junaids@google.com \
--cc=kai.huang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=leobras@redhat.com \
--cc=like.xu.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=maciej.szmigiero@oracle.com \
--cc=mhal@rbox.co \
--cc=michael.roth@amd.com \
--cc=mingo@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=nikunj@amd.com \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=pdurrant@amazon.com \
--cc=peterx@redhat.com \
--cc=pgonda@google.com \
--cc=pshier@google.com \
--cc=ricarkol@google.com \
--cc=robert.hu@linux.intel.com \
--cc=sagis@google.com \
--cc=seanjc@google.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=vipinsh@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=wei.w.wang@intel.com \
--cc=xiaoyao.li@intel.com \
--cc=yu.c.zhang@linux.intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.