From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it, "Liam R. Howlett" <Liam.Howlett@oracle.com>
Subject: Re: [LTP] [PATCH v2] mprotect: Add mprotect05 testcase
Date: Thu, 2 Mar 2023 21:09:10 +0100 [thread overview]
Message-ID: <ZAECZhVuBCX2WTl7@yuki> (raw)
In-Reply-To: <20230302141956.GA20234@pevik>
Hi!
> > Add a test that uses mprotect to split and combine VMAs. Created to
> > ensure the correctness of the VMA iterator after a bug report.
>
> LGTM, thank you.
>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>
> ...
> > +/*\
> > + * [Description]
> > + *
> > + * Testcase to check the mprotect(2) system call split and merge
> > + *
> > + * Reference links:
> > + * - https://bugzilla.kernel.org/show_bug.cgi?id=217061
> This would be formatted as inline in our docs.
> > + *
> > + */
> > +
> > +#include <errno.h>
> > +#include <stdio.h>
> These aren't needed.
>
> Waiting little longer for any feedback before merging with the diff below.
Can we also add a git tag to the test? It looks like fix is in mainline
in:
commit 2fcd07b7ccd5fd10b2120d298363e4e6c53ccf9c
Author: Liam R. Howlett <Liam.Howlett@oracle.com>
Date: Fri Feb 24 16:20:55 2023 -0500
mm/mprotect: Fix successful vma_merge() of next in do_mprotect_pkey()
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-03-02 20:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 19:33 [LTP] [PATCH v2] mprotect: Add mprotect05 testcase Liam R. Howlett
2023-03-02 14:19 ` Petr Vorel
2023-03-02 20:09 ` Cyril Hrubis [this message]
2023-03-03 7:46 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAECZhVuBCX2WTl7@yuki \
--to=chrubis@suse.cz \
--cc=Liam.Howlett@oracle.com \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.