From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Xiangyu Chen <xiangyu.chen@eng.windriver.com>
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][PATCH 0/1] lxc: templates/lxc-busybox.in: if busybox contains init then use it
Date: Thu, 2 Mar 2023 16:24:51 -0500 [thread overview]
Message-ID: <ZAEUIxX+2N+Xt6Ez@gmail.com> (raw)
In-Reply-To: <20230301023825.124974-1-xiangyu.chen@eng.windriver.com>
In message: [meta-virtualization][PATCH 0/1] lxc: templates/lxc-busybox.in: if busybox contains init then use it
on 01/03/2023 Xiangyu Chen wrote:
> From: Xiangyu Chen <xiangyu.chen@windriver.com>
>
> Hi Bruce,
>
> Recently we found that the lxc ptest has lots of failure cases as below log-1, after checking the
> code, some cases failed due to related the init progess. For example, lxc-test-exit-code need to
> start container as daemon, but if using bash as init, the container cannot start correctly.
Is there an indication of what busybox is providing that bash isn't ?
I don't like to force this in the ptest, while for actual lxc containers
we still allow bash, which means it may not be functional.
There are other init options in meta-virt, like the docker tini, if we
had to enforce something, I'd rather that than busybox.
Bruce
>
> So added a busybox init utils checking in lxc-busybox template, if current system busybox contains
> init then use it, after applying this patch, the ptest result as log-2.
>
>
> ######## 1og-1: ptest without patch #######
>
> Starting LXC ptest ###
> FAIL: lxc-test-api-reboot
> SKIPPED: lxc-test-apparmor
> PASS: lxc-test-apparmor-generated
> FAIL: lxc-test-apparmor-mount
> PASS: lxc-test-arch-parse
> FAIL: lxc-test-attach
> PASS: lxc-test-automount
> FAIL: lxc-test-autostart
> PASS: lxc-test-basic
> FAIL: lxc-test-capabilities
> FAIL: lxc-test-cgpath
> PASS: lxc-test-checkpoint-restore
> FAIL: lxc-test-cloneconfig
> FAIL: lxc-test-clonetest
> FAIL: lxc-test-concurrent
> PASS: lxc-test-config-jump-table
> FAIL: lxc-test-console
> FAIL: lxc-test-console-log
> FAIL: lxc-test-containertests
> FAIL: lxc-test-createconfig
> FAIL: lxc-test-createtest
> PASS: lxc-test-criu-check-feature
> FAIL: lxc-test-cve-2019-5736
> FAIL: lxc-test-destroytest
> FAIL: lxc-test-device-add-remove
> FAIL: lxc-test-exit-code
> FAIL: lxc-test-get_item
> PASS: lxc-test-getkeys
> PASS: lxc-test-list
> PASS: lxc-test-locktests
> FAIL: lxc-test-lxc-attach
> PASS: lxc-test-lxcpath
> PASS: lxc-test-may-control
> FAIL: lxc-test-mount-injection
> FAIL: lxc-test-no-new-privs
> PASS: lxc-test-parse-config-file
> FAIL: lxc-test-proc-pid
> FAIL: lxc-test-procsys
> PASS: lxc-test-raw-clone
> PASS: lxc-test-reboot
> FAIL: lxc-test-rootfs
> FAIL: lxc-test-rootfs-options
> FAIL: lxc-test-saveconfig
> FAIL: lxc-test-share-ns
> FAIL: lxc-test-shortlived
> SKIPPED: lxc-test-shutdowntest
> FAIL: lxc-test-snapdeps
> FAIL: lxc-test-snapshot
> FAIL: lxc-test-startone
> SKIPPED: lxc-test-state-server
> FAIL: lxc-test-symlink
> FAIL: lxc-test-sys-mixed
> FAIL: lxc-test-sysctls
> FAIL: lxc-test-unpriv
> FAIL: lxc-test-usernic
> PASS: lxc-test-usernsexec
> PASS: lxc-test-utils
>
>
>
>
>
> Results:
> PASSED = 17
> FAILED = 37
> SKIPPED = 3
> (for details check individual test log in ./logs directory)
>
>
> ###########log-2: ptest with patch ###################
> root@intel-x86-64:/usr/lib64/lxc/ptest# ./run-ptest
> ### Starting LXC ptest ###
> PASS: lxc-test-api-reboot
> SKIPPED: lxc-test-apparmor
> PASS: lxc-test-apparmor-generated
> FAIL: lxc-test-apparmor-mount
> PASS: lxc-test-arch-parse
> PASS: lxc-test-attach
> PASS: lxc-test-automount
> PASS: lxc-test-autostart
> PASS: lxc-test-basic
> PASS: lxc-test-capabilities
> PASS: lxc-test-cgpath
> PASS: lxc-test-checkpoint-restore
> FAIL: lxc-test-cloneconfig
> PASS: lxc-test-clonetest
> PASS: lxc-test-concurrent
> PASS: lxc-test-config-jump-table
> PASS: lxc-test-console
> PASS: lxc-test-console-log
> PASS: lxc-test-containertests
> PASS: lxc-test-createconfig
> PASS: lxc-test-createtest
> PASS: lxc-test-criu-check-feature
> PASS: lxc-test-cve-2019-5736
> PASS: lxc-test-destroytest
> PASS: lxc-test-device-add-remove
> PASS: lxc-test-exit-code
> FAIL: lxc-test-get_item
> PASS: lxc-test-getkeys
> PASS: lxc-test-list
> PASS: lxc-test-locktests
> PASS: lxc-test-lxc-attach
> PASS: lxc-test-lxcpath
> PASS: lxc-test-may-control
> PASS: lxc-test-mount-injection
> FAIL: lxc-test-no-new-privs
> PASS: lxc-test-parse-config-file
> PASS: lxc-test-proc-pid
> PASS: lxc-test-procsys
> PASS: lxc-test-raw-clone
> PASS: lxc-test-reboot
> PASS: lxc-test-rootfs
> PASS: lxc-test-rootfs-options
> PASS: lxc-test-saveconfig
> PASS: lxc-test-share-ns
> PASS: lxc-test-shortlived
> SKIPPED: lxc-test-shutdowntest
> FAIL: lxc-test-snapdeps
> PASS: lxc-test-snapshot
> PASS: lxc-test-startone
> SKIPPED: lxc-test-state-server
> PASS: lxc-test-symlink
> PASS: lxc-test-sys-mixed
> PASS: lxc-test-sysctls
> FAIL: lxc-test-unpriv
> FAIL: lxc-test-usernic
> PASS: lxc-test-usernsexec
> PASS: lxc-test-utils
>
> Results:
> PASSED = 47
> FAILED = 7
> SKIPPED = 3
> (for details check individual test log in ./logs directory)
>
>
>
>
> Xiangyu Chen (1):
> lxc: templates/lxc-busybox.in: if busybox contains init then use it
>
> ...box-contains-init-use-it-in-containe.patch | 45 +++++++++++++++++++
> recipes-containers/lxc/lxc_git.bb | 1 +
> 2 files changed, 46 insertions(+)
> create mode 100644 recipes-containers/lxc/files/0001-template-if-busybox-contains-init-use-it-in-containe.patch
>
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7908): https://lists.yoctoproject.org/g/meta-virtualization/message/7908
> Mute This Topic: https://lists.yoctoproject.org/mt/97306618/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
next prev parent reply other threads:[~2023-03-02 21:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 2:38 [meta-virtualization][PATCH 0/1] lxc: templates/lxc-busybox.in: if busybox contains init then use it Xiangyu Chen
2023-03-01 2:38 ` [meta-virtualization][PATCH 1/1] " Xiangyu Chen
2023-03-02 21:24 ` Bruce Ashfield [this message]
2023-03-03 1:17 ` [meta-virtualization][PATCH 0/1] " Xiangyu Chen
2023-03-08 4:00 ` Bruce Ashfield
2023-03-09 3:48 ` Xiangyu Chen
2023-03-13 0:46 ` Bruce Ashfield
2023-03-13 7:18 ` Xiangyu Chen
2023-03-17 19:37 ` Bruce Ashfield
2023-03-17 19:42 ` Bruce Ashfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAEUIxX+2N+Xt6Ez@gmail.com \
--to=bruce.ashfield@gmail.com \
--cc=meta-virtualization@lists.yoctoproject.org \
--cc=xiangyu.chen@eng.windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.