From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: William Breathitt Gray <william.gray@linaro.org>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
broonie@kernel.org, techsupport@winsystems.com,
pdemetrotion@winsystems.com, quarium@gmail.com,
jhentges@accesio.com, jay.dolan@accesio.com
Subject: Re: [PATCH v4 0/3] Migrate the PCIe-IDIO-24 and WS16C48 GPIO drivers to the regmap API
Date: Mon, 6 Mar 2023 16:25:31 +0200 [thread overview]
Message-ID: <ZAX3243e4mejPEsS@smile.fi.intel.com> (raw)
In-Reply-To: <cover.1678106722.git.william.gray@linaro.org>
On Mon, Mar 06, 2023 at 07:59:50AM -0500, William Breathitt Gray wrote:
> Changes in v4:
> - Allocate idio24gpio before using it in idio_24_probe()
> Changes in v3:
> - Drop map from set_type_config() parameter list; regmap can be passed
> by irq_drv_data instead
> - Adjust idio_24_set_type_config() for parameter list
> - Add mutex to prevent clobbering the COS_ENABLE register when masking
> IRQ and setting their type configuration
> Changes in v2:
> - Simplify PCIe-IDIO-24 register offset defines to remove superfluous
> arithmetic
> - Check for NULL pointer after chip->irq_drv_data allocation
> - Set gpio_regmap drvdata and use gpio_regmap_get_drvdata() to get the
> regmap in idio_24_reg_map_xlate()
>
> The regmap API supports IO port accessors so we can take advantage of
> regmap abstractions rather than handling access to the device registers
> directly in the driver.
>
> A patch to pass irq_drv_data as a parameter for struct regmap_irq_chip
> set_type_config() is included. This is needed by the
> idio_24_set_type_config() and ws16c48_set_type_config() callbacks in
> order to update the type configuration on their respective devices.
>
> A patch to migrate the WS16C48 GPIO driver to the regmap API is included
> in this series due to its dependence on the struct regmap_irq_chip
> set_type_config() change.
I have found nothing WRT lock type changes.
Can you shed a light on what's going on here?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-03-06 14:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 12:59 [PATCH v4 0/3] Migrate the PCIe-IDIO-24 and WS16C48 GPIO drivers to the regmap API William Breathitt Gray
2023-03-06 12:59 ` [PATCH v4 1/3] regmap: Pass irq_drv_data as a parameter for set_type_config() William Breathitt Gray
2023-03-06 12:59 ` [PATCH v4 2/3] gpio: pcie-idio-24: Migrate to the regmap API William Breathitt Gray
2023-03-06 14:24 ` Andy Shevchenko
2023-03-08 2:29 ` William Breathitt Gray
2023-03-06 14:33 ` Michael Walle
2023-03-06 12:59 ` [PATCH v4 3/3] gpio: ws16c48: " William Breathitt Gray
2023-03-06 14:20 ` Andy Shevchenko
2023-03-08 2:51 ` William Breathitt Gray
2023-03-08 13:06 ` Andy Shevchenko
2023-03-09 19:33 ` William Breathitt Gray
2023-03-06 14:35 ` Michael Walle
2023-03-06 14:25 ` Andy Shevchenko [this message]
2023-03-08 2:11 ` [PATCH v4 0/3] Migrate the PCIe-IDIO-24 and WS16C48 GPIO drivers " William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAX3243e4mejPEsS@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=jay.dolan@accesio.com \
--cc=jhentges@accesio.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pdemetrotion@winsystems.com \
--cc=quarium@gmail.com \
--cc=techsupport@winsystems.com \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.