From: Jason Gunthorpe <jgg@nvidia.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
Nicolin Chen <nicolinc@nvidia.com>,
"Liu, Yi L" <yi.l.liu@intel.com>
Subject: Re: [PATCH v3 08/12] iommufd/selftest: Rename domain_id to stdev_id for FIXTURE iommufd_ioas
Date: Mon, 6 Mar 2023 10:50:16 -0400 [thread overview]
Message-ID: <ZAX9qDZdM5h+TiYH@nvidia.com> (raw)
In-Reply-To: <BN9PR11MB52767FE47436B23EA38CFCE68CB29@BN9PR11MB5276.namprd11.prod.outlook.com>
On Thu, Mar 02, 2023 at 01:23:48AM +0000, Tian, Kevin wrote:
> > {
> > - if (self->domain_id) {
> > + if (self->stdev_id) {
> > /* IOAS cannot be freed while a domain is on it */
> > EXPECT_ERRNO(EBUSY,
> > _test_ioctl_destroy(self->fd, self->ioas_id));
>
> it's easier to understand this comment.
I changed this comment to use the right language:
if (self->stdev_id) {
/* IOAS cannot be freed while a device has a HWPT using it */
EXPECT_ERRNO(EBUSY,
_test_ioctl_destroy(self->fd, self->ioas_id));
Thanks,
Jason
next prev parent reply other threads:[~2023-03-06 14:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 19:30 [PATCH v3 00/12] Revise the hwpt lifetime model Jason Gunthorpe
2023-03-01 19:30 ` [PATCH v3 01/12] iommufd: Assert devices_lock for iommufd_hw_pagetable_has_group() Jason Gunthorpe
2023-03-01 19:30 ` [PATCH v3 02/12] iommufd: Add iommufd_lock_obj() around the auto-domains hwpts Jason Gunthorpe
2023-03-01 19:30 ` [PATCH v3 03/12] iommufd: Consistently manage hwpt_item Jason Gunthorpe
2023-03-02 1:20 ` Tian, Kevin
2023-03-01 19:30 ` [PATCH v3 04/12] iommufd: Move ioas related HWPT destruction into iommufd_hw_pagetable_destroy() Jason Gunthorpe
2023-03-02 1:21 ` Tian, Kevin
2023-03-01 19:30 ` [PATCH v3 05/12] iommufd: Move iommufd_device to iommufd_private.h Jason Gunthorpe
2023-03-01 19:30 ` [PATCH v3 06/12] iommufd: Make iommufd_hw_pagetable_alloc() do iopt_table_add_domain() Jason Gunthorpe
2023-03-01 19:30 ` [PATCH v3 07/12] iommufd/selftest: Rename the sefltest 'device_id' to 'stdev_id' Jason Gunthorpe
2023-03-02 1:21 ` Tian, Kevin
2023-03-01 19:30 ` [PATCH v3 08/12] iommufd/selftest: Rename domain_id to stdev_id for FIXTURE iommufd_ioas Jason Gunthorpe
2023-03-02 1:23 ` Tian, Kevin
2023-03-06 14:50 ` Jason Gunthorpe [this message]
2023-03-01 19:30 ` [PATCH v3 09/12] iommufd/selftest: Rename domain_id to hwpt_id for FIXTURE iommufd_mock_domain Jason Gunthorpe
2023-03-02 1:24 ` Tian, Kevin
2023-03-01 19:30 ` [PATCH v3 10/12] iommufd/selftest: Rename the remaining mock device_id's to stdev_id Jason Gunthorpe
2023-03-02 1:25 ` Tian, Kevin
2023-03-01 19:30 ` [PATCH v3 11/12] iommufd/selftest: Make selftest create a more complete mock device Jason Gunthorpe
2023-03-01 19:30 ` [PATCH v3 12/12] iommufd/selftest: Add a selftest for iommufd_device_attach() with a hwpt argument Jason Gunthorpe
2023-03-02 1:26 ` Tian, Kevin
2023-03-06 17:16 ` [PATCH v3 00/12] Revise the hwpt lifetime model Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAX9qDZdM5h+TiYH@nvidia.com \
--to=jgg@nvidia.com \
--cc=iommu@lists.linux.dev \
--cc=kevin.tian@intel.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=shuah@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.